Rishi Gupta
16a5540e58
billing: Add comment to downgrading section in views.billing_home.
2018-08-22 19:20:06 -07:00
Rishi Gupta
d081cf7b78
billing: Add transaction.atomic() for Customer creation and logging.
2018-08-22 19:20:06 -07:00
Rishi Gupta
3cf9cd00d6
billing: Remove idempotency key from upgrade process.
...
This would be relevant if we retried on network failure, but we don't.
2018-08-22 19:18:32 -07:00
Shubham Dhama
e784c95d97
guests: Prevent guests from sending to unsubscribed public streams.
...
This matches the overall security model of these users only having
access to streams they are subscribed to.
2018-08-22 17:53:42 -07:00
Shubham Dhama
e70cf3bd67
emails/password_reset: Change text for listing other active accounts.
...
The main benefit of this change is that it reduces the amount of total
string that we might need to tag for translation.
Fixes : #10323 .
2018-08-22 17:49:40 -07:00
Shubham Dhama
aa8b3d2beb
emails/password_reset: Change template string for deactivated users.
2018-08-22 17:43:23 -07:00
Shubham Dhama
491bd6d2c9
emails/password_reset: Refactor and replace no_account_in_realm.
...
In place of no_account_in_realm we will use its negation
active_account_in_realm as a part of refactoring this template.
2018-08-22 17:43:23 -07:00
Shubham Dhama
3fecc71777
emails/password_reset: Make `.txt` template consistent with `.html`.
2018-08-22 17:43:23 -07:00
Shubham Dhama
941cd0bb2f
emails/password_reset: Fix multiple accounts realm uri listing.
2018-08-22 17:43:23 -07:00
Yago González
e7c7b19507
api docs: Document POST /realm/filters.
2018-08-22 17:42:14 -07:00
Yago González
df7234f3a6
api docs: Escape HTML in the examples.
...
Having HTML (or HTML-like) content in the examples was making parts of
the content invisible, since the browser identified them as HTML tags
rather than verbose text.
2018-08-22 17:19:09 -07:00
Yago González
c70d051031
test-api: Add function for server & realm tests.
...
There are some endpoints that don't fall into the currently available
categories, so this new function will be used for calling the tests for
server and realm-related endpoints.
2018-08-22 17:19:09 -07:00
Yago González
fcf1e3cd88
api docs: Add guide for creating narrows.
...
Dramatically edited by tabbott to simplify the discussion and
duplication of content in our main search documentation.
2018-08-22 17:16:27 -07:00
Steve Howell
44756a326d
tests: Test duplicate default stream/groups.
...
This also gets us to 100% line coverage
for actions.py.
2018-08-22 16:52:30 -07:00
Steve Howell
fe6680c316
refactor: Flatten code in check_invite_limit().
...
Using early-exit here allows us to more easily
comment why there are certain exemptions to
this logic.
We also only require callers to pass in realm,
not the whole user object.
2018-08-22 16:52:30 -07:00
Steve Howell
cac9a02d6d
tests: Add coverage for check_invite_limit().
...
The function being tested here was kind of an
emergency response to some spam attacks. It
works for a pretty specific set of circumstances,
so it requires a lot of setup.
We may eliminate this function as we improve
our realm "plan types", and if that happens, we
can either eliminate this test or repurpose it.
2018-08-22 16:52:30 -07:00
Joshua Pan
eca4266cde
drafts: Don't save drafts with 2 or less characters.
...
Fixes #10357 .
2018-08-22 16:52:18 -07:00
Steve Howell
4318f75718
Remove `code` from JsonableError.__init__.
...
Since this class was built, folks have always chosen
to subclass JsonableError for situations where
the default of ErrorCode.BAD_REQUEST is insufficient.
So now we simplify the use cases, which also gets
us 100% coverage on this core module.
2018-08-22 16:51:40 -07:00
Marco Burstein
21d537d3bd
styles: Fix the oversized search bar on mobile.
...
On mobile devices, the search bar appears as too tall for the rest of
the top header. Fix this by setting `#search_query`'s height and
vertical alignment properties.
Fix #10373 .
2018-08-22 13:15:08 -07:00
Rishi Gupta
7dbdea3ad9
plans: Update faq for non-profit discounts.
2018-08-22 12:42:30 -07:00
Tim Abbott
b53a712856
nginx: Update configuration for using certbot certs everywhere.
2018-08-22 11:59:15 -07:00
Rishi Gupta
0de30589b0
plans: Replace hipchat with discord in compare section.
2018-08-22 11:59:15 -07:00
Vishnu Ks
6fcb095e70
activity: Show plan_type in activity page.
2018-08-21 18:15:14 -07:00
Tim Abbott
2e6aaf3215
actions: Use better query for active_mobile_push_notification.
2018-08-21 15:28:05 -07:00
Tim Abbott
887d20795f
message flags: Add where_starred helper and use it.
...
The previous query ended up doing a scan of all a user's UserMessage
rows, not just the ones tracked in the `starred` index.
2018-08-21 15:28:04 -07:00
Tim Abbott
b93d5bd5e8
test-js-with-node: Temporarily remove server_events_dispatch.js.
...
This fixes master failing tests since 2aeabf24a6
.
2018-08-21 14:40:05 -07:00
Tim Abbott
1768fd2f60
Revert "left-sidebar: Add max-height to private message container."
...
This caused ugly scrollbar problems on Linux.
This reverts commit 321b705591
.
2018-08-21 14:03:15 -07:00
Joshua Pan
3ec34eda11
display settings: Implement UI for starred_message_counts.
2018-08-21 13:42:23 -07:00
Joshua Pan
2aeabf24a6
frontend: Create data structure for starred messages.
2018-08-21 13:42:23 -07:00
Joshua Pan
79e2266d6e
models: Create starred_message_counts boolean field.
2018-08-21 13:42:22 -07:00
Joshua Pan
83d8d662dc
events: Query starred message ids in fetch_initial_state_data.
2018-08-21 13:01:41 -07:00
Shubham Padia
8be8f114df
docs: Add fake LDAP auth to subsystems/auth.md.
...
Fixes #10297 .
2018-08-21 12:56:05 -07:00
Shubham Padia
34cb0eae29
tests: Stop using fixtures to test generate_dev_ldap_dir.
...
The output of generate_dev_ldap_dir was being tested against the fixture
located at zerver/tests/fixtures/ldap_dir.json. This didn't make much sense
as generate_dev_ldap_dir was itself used by developers to generate/update
the fixtures. Instead, test_generate_dev_ldap_dir checks the structure of
the dict returned by generate_dev_ldap_dir. The structure is checked by
regex checks, checking whether the dict contains some keys or not, etc.
2018-08-21 12:55:36 -07:00
Tim Abbott
517df26199
docs: Update headings for development auth documentation.
...
Also, we fix an outdated link from /devtools.
2018-08-21 12:55:28 -07:00
Shubham Padia
28cbdb60c6
docs: Rename docs/subsystems/oauth.md to auth.md.
2018-08-21 12:51:24 -07:00
Marco Burstein
fa95ba9812
style: Fix the stream and user list buttons on mobile in night mode.
...
These buttons are displayed with a lighter background than other
buttons. Update their borders and background colors (along with the
border on the search box) so that they match the night theme.
Fix #10301 .
2018-08-21 12:42:06 -07:00
Vishnu Ks
9bb338be11
models: Add plan_type to Realm.
2018-08-21 12:39:06 -07:00
Yashashvi Dave
6031ccff5c
user pills: Every pills-container must include div-input element.
...
Expect div-input element in every pill-container even though pills are
not editable. This is correct, because `input_pill.js` appends pills
before the div-input element.
2018-08-21 12:10:36 -07:00
Yashashvi Dave
4f9ca03c13
user profile popover: Display user pills in custom user field.
...
Display user pills instead of user names in custom user field
on user profile popover.
2018-08-21 12:10:35 -07:00
Yashashvi Dave
9812b81a1e
user pills: Rename class `notmem` to `not-editable` for generalization.
2018-08-21 11:50:01 -07:00
Tim Abbott
5f10fa1692
user_profile_modal: Remove profile_data conditional.
...
It's no longer possible for profile_data to be empty, and the
conditional was in the wrong place anyway.
2018-08-21 11:49:36 -07:00
Yashashvi Dave
92782e2f89
static/js/popovers.js: Modify structure of user popover template data.
...
Modify structure of template data used to render
`user_profile_modal.handlebars`.
This is preparatory commit to display user pills in user profile
popover instead of user names in user type custom fields.
2018-08-21 11:42:59 -07:00
Yashashvi Dave
9e9bb18244
user profile popover: Use long local date format in custom-date-field.
...
Use long local date format `MMMM DD, YYYY` instead of short `MM/DD/YY`
in custom profile date field.
2018-08-21 11:42:59 -07:00
Yashashvi Dave
6622f995b0
user profile popover: Rename user last seen.
...
Rename "Last seen just now" to "Just now",
and "Unknown" to "More than 2 weeks ago"
in user profile popover.
2018-08-21 11:42:59 -07:00
Yashashvi Dave
150ea61271
custom profile field: Improve style of user pills in user type field.
...
Improve style of user pills in user-type-custom-field on
account settings page.
2018-08-21 11:42:59 -07:00
Yashashvi Dave
1e27cb18eb
user profile popover: Hide popover when user clicks on edit-profile-btn.
2018-08-21 11:42:59 -07:00
Yashashvi Dave
583fde4311
custom profile field: Set default values in create-field form on load.
...
Add call of reset function, on load of admin settings page.
This function reset values in create-new-field form, i.e.
field type.
2018-08-21 11:42:59 -07:00
Yashashvi Dave
03f5422ce8
custom profile field: Minor tweaks in field-table in admin settings.
...
This commit add minor changes in profile field table in
admin settings:
- Hide table header if there is no field
- Fix width of table column
2018-08-21 11:42:59 -07:00
Yashashvi Dave
66c2b6d2a6
custom profile field: Remove unnecessary table header from edit form.
...
Remove unnecessary table header in edit-choice-field form.
2018-08-21 11:42:58 -07:00
Yashashvi Dave
d5f3c9b3bc
custom profile field: Rename field types in UI.
2018-08-21 11:37:51 -07:00