c80e6edb4e
mypy: Declare models with null=True Optional.
2017-05-23 14:36:40 -07:00
70d68f7e71
Refactoring: Replace get_user_profile_by_email() in lib/upload.py
2017-05-23 12:37:49 -07:00
484f32646b
Rename file to test_new_users.py.
...
The old file name of test_send_login_emails was
overly specific, and we want to add some tests
related to other parts of the signup process.
2017-05-23 12:34:44 -07:00
dd55d5b683
mypy: Fix bad type annotation
2017-05-23 10:42:44 -07:00
a67e427293
mypy: Add comment for future use of Deque.
...
In the future, the type annotation should use Deque in order to be
compatible with the latest mypy version. See
https://github.com/python/mypy/pull/2845 for more info.
2017-05-23 10:42:44 -07:00
c40759562c
streams: Refactor get_user_profile_by_email to get_user.
2017-05-23 10:32:53 -07:00
dd76222a3f
Fetch system bots using new get_system_bot function.
...
This eliminate a bunch of uninteresting calls to
get_user_profile_by_email.
2017-05-23 10:30:40 -07:00
287aaa21b6
Outgoing Webhook System: Add outgoing webhook queue worker.
2017-05-23 08:21:08 -07:00
c7524f2f38
Outgoing Webhook System: Prevent infinite loops with outgoing webhooks.
2017-05-23 08:20:45 -07:00
53a8b2ac87
Outgoing Webhook System: Add DoRestCall and helper functions
2017-05-23 08:19:16 -07:00
820dc9dd9a
Replace espuser@mit.edu with mit_user('espuser').
2017-05-22 19:02:42 -07:00
99fc0e9e62
Replace starnine@mit.edu with mit_user('starnine').
2017-05-22 19:02:42 -07:00
c680c5f1e8
Replace sipbtest@mit.edu with mit_user('sipbtest').
2017-05-22 19:02:42 -07:00
7f06a7fa2a
Add ZulipTestCase.mit_user() function.
2017-05-22 19:02:42 -07:00
05951074be
Make MITNameTest use ZulipTestCase instead of TestCase.
2017-05-22 19:02:42 -07:00
ed8c6943f2
webhooks/airbrake: Use Markdown macros for documentation.
2017-05-22 18:19:14 -07:00
baff121115
app_filters: Render HTML to render Jinja2 syntax within Markdown macros.
...
If a Markdown macro contains Jinja2 template code, it isn't rendered
because render_markdown_path calls template.render on the including
.md file before the macro has been included. And then the including
.md file is converted to HTML. Therefore, the template code within
a Markdown macro (if any) never gets rendered and is returned as it is.
Now, after the source .md file is converted to HTML,
render_markdown_path renders the resulting HTML so that any template
code within included macros (if any) is finally rendered.
2017-05-22 18:19:14 -07:00
0b88957d12
views: Use property_types for display settings.
...
This reduces semi-duplicated code here.
2017-05-22 18:11:08 -07:00
5eaccc550a
rate_limit: Make retry-after data machine-readable.
...
Fixes #4831 .
2017-05-22 17:35:12 -07:00
01f7d9d651
zerver/lib/events: Refactor get_user_profile_by_email to get_user.
...
Fixes #4831 .
2017-05-22 17:32:36 -07:00
accc7406da
views/presence: Refactor get_user_profile_by_email -> get_user.
2017-05-22 16:43:08 -07:00
7995dd2de6
views/users: Refactor get_user_profile_by_email to get_user.
2017-05-22 16:42:16 -07:00
510b7a0489
mypy: Add ignore type for dynamically added field on LogRecord.
...
mypy will error because of the attribute "request" on the LogRecord
object. Since this field is added in our tests dynamically and is not
on the base object, for now we will ignore the type.
2017-05-22 14:38:39 -07:00
bdf7c6c02f
models: Add get_user function.
...
This is intended to replace get_user_profile_by_email.
2017-05-22 11:26:44 -07:00
040067b2a2
invite: Remove obsolete bulk_invite_users endpoint.
2017-05-17 17:30:15 -07:00
092d670e85
pep8: Add compliance with rule E261 to zerver/views/user_settings.py.
2017-05-18 03:00:32 +05:30
cc2b334020
pep8: Add compliance with rule E261 to zerver/views/streams.py.
2017-05-18 03:00:32 +05:30
11aeeec2ab
pep8: Add compliance with rule E261 to zerver/views/registration.py.
2017-05-18 03:00:32 +05:30
5cdfd899dc
pep8: Add compliance with rule E261 to zerver/views/realm.py.
2017-05-18 03:00:32 +05:30
db3c05002a
pep8: Add compliance with rule E261 to zerver/views/presence.py.
2017-05-18 03:00:32 +05:30
634c08c3dd
pep8: Add compliance with rule E261 to zerver/views/messages.py.
2017-05-18 03:00:32 +05:30
35e3d57ed9
pep8: Add compliance with rule E261 to zerver/views/invite.py.
2017-05-18 03:00:32 +05:30
1979476152
pep8: Add compliance with rule E261 to zerver/views/integrations.py.
2017-05-18 03:00:32 +05:30
fe3b42c8f8
pep8: Add compliance with rule E261 to zerver/views/home.py.
2017-05-18 03:00:32 +05:30
c504b013b1
pep8: Add compliance with rule E261 to views/auth.py.
2017-05-18 03:00:32 +05:30
57bc847874
pep8: Add compliance with rule E261 to test_urls.py.
2017-05-18 03:00:32 +05:30
85aa07e2d4
pep8: Add compliance with rule E261 to zerver/lib/upload.py.
2017-05-18 03:00:32 +05:30
b7c49299a6
pep8: Add compliance with rule E261 to test_runner.py.
2017-05-18 03:00:32 +05:30
e3003653c7
pep8: Add compliance with rule E261 to test_helpers.py.
2017-05-18 03:00:32 +05:30
26ff19f005
pep8: Add compliance with rule E261 to zerver/lib/test_classes.py.
2017-05-18 03:00:32 +05:30
1f1fbd7648
pep8: Add compliance with rule E261 to zerver/lib/notifications.py.
2017-05-18 03:00:32 +05:30
84eadc0562
pep8: Add compliance with rule E261 to zerver/lib/message.py.
2017-05-18 03:00:32 +05:30
03e43b78ee
pep8: Add compliance with rule E261 to zerver/lib/html_diff.py.
2017-05-18 03:00:32 +05:30
b822e75a4b
pep8: Add compliance with rule E261 to export.py.
2017-05-18 03:00:32 +05:30
4c373dde63
pep8: Add compliance with rule E261 to events.py.
2017-05-18 03:00:32 +05:30
1a184263b8
pep8: Add compliance with rule E261 to zerver/lib/db.py.
2017-05-18 03:00:32 +05:30
420230b342
pep8: Add compliance with rule E261 to actions.py.
2017-05-18 03:00:32 +05:30
bc15085098
gcm: Increase retries to 10 while pushing.
2017-05-17 12:14:32 -07:00
38ecc35cd9
push_notifications: Catch IOError while pushing to GCM.
2017-05-17 12:14:32 -07:00
7e8f4ca4e8
push_notifications: Include GCM in end-to-end test.
2017-05-17 08:09:19 -07:00
be3dc12a98
models: Move several __unicode__ methods to abstract classes.
...
This makes it possible to print ArchivedMessage, ArchivedUserMessage,
and ArchivedAttachment objects.
2017-05-16 21:04:58 -07:00
850519b314
api: Move cross_realm_bots into the register_ret response.
...
This is probably not the right long-term solution to the cross-realm
bots problem (that solution is probably to eliminate cross-realm bots
and replace them with per-realm bots). But in the short term, this
will at least make it possible for mobile apps to interact with these
cross-realm bots using the `realm_user` data set.
2017-05-16 20:23:13 -07:00
4f358f4034
webhooks/gitlab: Support pushing a local branch without commits.
...
This mostly just adds a test for GitLab related to the last commit.
2017-05-16 19:33:43 -07:00
5687b2cdc5
webhooks/github*: Support pushing a local branch without commits.
...
Changes made to get_push_commits_event_message in
zerver/lib/webhooks/git.py are common to all Git integrations
that use get_push_commits_event_message. These include github,
github_webhook, gitlab, gogs, bitbucket, bitbucket2. In some
cases (for instance, gitlab), no further changes to gitlab/view.py
will be required to support pushing a local branch without commits;
adding a fixture and tests should suffice.
2017-05-16 23:51:19 -02:30
cab908b664
api: Move notifications_stream into the register_ret API.
...
While we're at it, we at least fix the API to use a stream ID, not a
stream name, to refer to the notifications stream.
2017-05-16 18:57:14 -07:00
0b2388bda9
push_notifications: Remove DeviceTokenType logic.
...
The syntax wasn't valid on Python 3.5, and the new code is somewhat
more readable anyway.
2017-05-16 12:26:55 -07:00
9d63a5ab3a
push_notification: Delete obsolete DBX_IOS_APP_ID code.
...
I'm not sure that this was ever actually used, but it's definitely
just clutter for Zulip today.
2017-05-16 12:26:55 -07:00
286f9a40e7
push_notifications: Bring file to 100% coverage.
2017-05-16 12:26:55 -07:00
fa5c66c439
push_notifications: Add num_push_devices_for_user tests.
2017-05-16 12:26:55 -07:00
88f5d29e19
push_notifications: Add send_to_push_bouncer tests.
2017-05-16 12:26:55 -07:00
af27ad607a
push_notifications: Add handle_push_notification tests.
2017-05-16 12:26:55 -07:00
8a6498f55d
push_notifications: Create BouncerTestCase.
...
Adds bounce_request method to simulate a bounce.
2017-05-16 12:26:55 -07:00
5907877038
push_notifications: Add test for send_notifications_to_bouncer.
2017-05-16 12:26:55 -07:00
fab4249893
push_notifications: Add get_gcm_payload tests.
2017-05-16 12:26:55 -07:00
136a950041
push_notifications: Add test for APNs payload.
2017-05-16 12:26:55 -07:00
47d0f7d996
push_notifications: Add tests for get_alert_from_message.
2017-05-16 12:26:55 -07:00
df0d29aaff
push_notifications: Add response_listener tests.
2017-05-16 12:26:55 -07:00
fc0b9358e7
handle_push_notification: Remove the if condition.
...
'if apple_devices or android_devices' doesn't servce any purpose.
2017-05-16 12:26:55 -07:00
ab411ab7b3
push_notifications: Delete remote server tokens in APNs response.
2017-05-16 12:26:55 -07:00
33332539df
send_android_push_notification: Delete correct tokens.
...
Now this function will delete tokens from RemotePushDeviceToken if it
is running on notification bouncer or PushDeviceToken if it is running
on a server which doesn't use notification bouncer.
2017-05-16 12:26:55 -07:00
4a864c7515
push_notification: Send data to notification bouncer.
2017-05-16 12:26:55 -07:00
4e2a6834d8
authenticated_rest_api_view: Use is_remote_server.
...
Using is_remote_server is more readable and future-proof since
it provides a level of abstraction.
2017-05-16 12:26:55 -07:00
e6cc0ffcdd
Eliminate PMs to non-subscribers when creating streams.
...
This should make stream creation relatively fast again, since we
will no longer send O(N) PMs out to tell folks the stream was
created.
2017-05-16 10:43:27 -07:00
c549dea9ac
bugdown: Fix the regex used for unicode emoji matching.
...
The regex we were using didn't cover all the unicode blocks
to which our emojis belong. This commit fixes the regex to
include all the unicode blocks and also updates the
corresponding JS regex in marked.js.
Fixes : #3460 .
2017-05-16 09:05:42 -07:00
f8824ea623
bugdown: Fix the `unicode_emoji_to_codepoint()` function.
...
Unicode codepoints are of minimum length 4, padded with extra
zeroes if the length is less than 4. This commit fixes the
`unicode_emoji_to_codepoint()` to ensure that the codepoint
it generates are of correct length.
2017-05-16 09:05:42 -07:00
c8dd056ac5
Extract you_were_just_subscribed_message().
2017-05-16 09:01:00 -07:00
bbd8c1c49b
Do not send PMs to subscribers when creating streams.
...
When we create a stream, we usually send a welcome message on the
stream itself as well as an announcement on the announcement stream,
but we no longer PM the individual users. Hopefully this will be
more pleasant for users (less spammy), and it also will make creating a
stream a lot faster.
We still send notifications when we add subscribers to an existing
stream.
2017-05-16 08:58:17 -07:00
847f469cf2
subdomains: Toggle various links with SUBDOMAINS_HOMEPAGE.
2017-05-15 21:54:35 -07:00
e2732dabf3
Send welcome messages as part of /create_realm flow.
...
We now pre-populate the streams in DEFAULT_NEW_REALM_STREAMS
(social/general/zulip, unless somebody changes settings.py) with
welcome messages. This makes the streams appear to be active
right away, and it also gives the Zulip realm less of a
blank-slate feeling when you create it.
This change only affects the normal web-based create-realm flow.
It doesn't impact the management commands for creating realms
or setting default streams.
2017-05-15 20:38:08 -07:00
21e0db03e1
webhooks/appfollow: Migrate docs to Markdown.
2017-05-15 20:14:23 -07:00
0b5711aa7e
webhooks/airbrake: Migrate docs to Markdown.
2017-05-15 20:14:23 -07:00
7227f488c8
webhooks: Add support for a GitHub push event deleting a branch.
...
Fixes : #4742 .
2017-05-16 00:11:20 -02:30
0b46be2fed
Avoid UserActivity logging for RemoteZulipServer requests.
...
We had a somewhat messy bug where we were sending invalid entries to
the UserActivity queue when using the push notification bouncer.
2017-05-15 17:15:01 -07:00
97abaae9af
home: Remove now-unnecessary page_params_core_fields duplication.
...
Also, we update the documentation to make the overall system a bit
clearer.
Fixes #4628 .
2017-05-13 22:58:18 -07:00
f36000d670
docs: Fix last reference to old fixtures directory structure.
2017-05-13 21:39:12 -07:00
597db11a98
webhooks: Rename webhook fixtures to only include event type.
...
All webhook fixtures have now been renamed from
<webhook_name>/fixtures/<webhook_name>_<event_type>.json to
<webhook_name>/fixtures/<event_type>.json.
2017-05-13 20:07:40 -02:30
acb3c1e7ff
test_templates: Fix errors from compare.html template.
2017-05-13 14:57:06 -07:00
10dcc99983
zerver/decorators: Log all exceptions raised in api_key_only_webhook_view.
...
Fixes #4742 .
2017-05-13 14:53:47 -07:00
51978d0f89
tests: Fix failing login tests.
...
Apparently I missed these when updating
4d2bb0dec8
2017-05-13 13:05:15 -07:00
4d2bb0dec8
templates: Clean up visuals for account-not-found SSO flow.
...
Also, clarify that the account that isn't found is your Zulip account,
not a GitHub/Google Oauth account.
2017-05-13 12:46:05 -07:00
0b5954feee
Increase initial messages on user creation from 100 to 1000.
...
This makes the new user experience in an active community like
chat.zulip.org substantially nicer, since the new user will have the
same level of initial messages to populate topics (etc.) as an
existing user who is caught up.
Without this, there was an undue level of fading-for-inactivity in the
default streams.
2017-05-13 12:16:05 -07:00
25516c6949
models: Update comment explaining order of display recipients.
2017-05-12 13:53:06 -07:00
72abd4f12d
mentions: Fix subject line and sender for missed-message mentions.
...
This fixes 2 issues:
* The term "@-mentioned" is simplified to "mentioned".
* We would incorrectly list other people who sent context messages as
among the people who mentioned you.
2017-05-12 13:50:25 -07:00
0facaa0797
Changes sender and subject lines for missed message emails.
...
Now, in the event of messages between two other members of a huddle,
the missed message emails are threaded in "Group PMs with name1 and
name2" and not in separate threads by sender.
Also, now the order of recipients in get_display_recipient consistent
with the order of names that appears in the list of personal messages
on the left sidebar.
Fixes most of #4553 .
2017-05-12 13:29:43 -07:00
13a37f74a1
users: Ban names shorter than 3 characters.
...
The empty string is not a reasonable name.
2017-05-11 19:21:51 -07:00
b1bfe9f42e
Add migration to force lowercase existing realm emoji.
...
Since realm emoji are now required to be lowercase,
an appropriate migration was added to retroactively
fix any emoji that might have contained uppercase
letters.
Also, the validator on the model was changed to
reject uppercase letters.
2017-05-11 19:10:21 -07:00
68e5898a07
emoji.py: Add restriction that realm emoji must be lowercase.
...
Raises error if emoji name has an uppercase letter in it.
2017-05-11 19:10:21 -07:00
6eada74bfe
portico: Fix exception if no realm description is set.
...
This was caught via Casper tests, which I regret not running.
2017-05-11 14:23:46 -07:00
223624be25
settings: Add support for longer, markdown-powered realm descriptions.
...
This makes it possible to create much prettier login pages.
Further work on styling may be necessary.
2017-05-11 13:59:46 -07:00
329b377e6a
push_notification: Add uses_notification_bouncer().
...
This function abstracts the logic to ascertain if we are using
notification bouncer service or not. Makes our code more
maintainable.
2017-05-11 12:04:16 -07:00
Christian Hudon
Rick Chern
Steve Howell
umkay
Konstantin Gukov
vaibhav
Vishnu Ks
Eeshan Garg
JoshuaGoldin
Lukasz Prasol
Tim Abbott
Lech Kaiel
Aditya Bansal
Umair Khan
Harshit Bansal
James Rowan
Cory Lynch