5cd4a8c8e5
pills: Express pill-container spacing on base class.
2024-06-23 22:00:18 -07:00
780391fd43
pills: Better express pill-container outer spacing.
2024-06-23 22:00:18 -07:00
9f24b30e78
test_push_notifs: Adjust .filter() in test_analytics_api.
...
The test asserts entries about the zephyr realm anyway. The reason the
filter hasn't been limiting the query to zephyr is that we might
simultaneously want to ensure no other realms received changes - but
that doesn't seem quite right, given that the test doesn't dilligently
set up the initial conditions for all realms to have control over what
exactly happens with them. That makes this logic pretty fragile since if
some new (potentially unrelated) changes to Realm/RemoteRealm initial
state make it so some updates to other realms occur during the early
analytics upload calls in the test, the remote_audit_logs asserts here
will break in a very annoying to debug way.
If we want this query to be general, without limiting to the zephyr
realm, we could alter the test a bit to set up initial conditions
precisely.
2024-06-23 07:44:11 -07:00
f8616fa013
analytics: Send ZULIP_MERGE_BASE to the bouncer.
2024-06-23 07:44:11 -07:00
95a2ce6ed6
ui_init: Restore guard against direct use of page_params.state_data.
...
Before commit fd253539e0#30519 ), each
part of state_data was removed by pop_fields, to ensure that it was
only used by its associated module and not manipulated directly.
Restore this guarantee by removing page_params.state_data itself.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-23 07:42:28 -07:00
3a7f5da717
page_params: Add a separate error message for missing #page-params.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-22 21:50:51 -07:00
2d79ce2e93
invite: Replace stream checkboxes list with stream pills.
...
Introduce an input field with typeahead functionality, initially
populated with the default streams for the organization.
Fixes #26871 .
2024-06-22 20:04:28 -07:00
445ff79e10
stream_pill: Update `format_stream_name_and_subscriber_count`.
...
Use `$t` to ensure the function returns a translatable string.
2024-06-22 20:04:28 -07:00
7580130873
stream_pill: Rename `stream_display_pill`.
2024-06-22 20:04:28 -07:00
d1d8963bd5
app: Sink z-index of loading overlay below alert popups.
...
This makes early blueslip errors visible.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-22 19:18:10 -07:00
0b3cf78333
blueslip: Untangle from page_params.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-22 19:18:10 -07:00
f7eecb0e03
sentry: Untangle from page_params.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-22 18:53:56 -07:00
3db05666ac
state_data: Accept null for ProfileDatum["rendered_value"].
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-22 11:21:54 -07:00
ca5fba258e
giphy: Split is_giphy_enabled to a separate module.
...
This removes giphy from the critical path of the TypeScript migration.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-22 08:21:08 -07:00
4d84ed305e
stream_color: Fix stream icon color not changing on theme change.
...
Changing theme didn't change the color of the stream icons.
2024-06-22 08:20:23 -07:00
00240b6dbe
compose: Reduce space between recipient area and textbox.
2024-06-21 17:29:56 -07:00
878d02cf5c
compose: Redesign control buttons row and textbox to look like 1 unit.
...
The row of buttons is placed using CSS grid template areas so that
visually it is now inside the bottom edge of the textbox. The color of
the buttons row and individual buttons is changed to match the color of
the textbox. All textbox border / box shadow properties are now applied
to its parent instead which is extended under the buttons' row, so that
its border snuggly fits around the buttons row too.
Notable side effects:
- In dark mode the textbox in focused state now has a light border which
does not match the recipient input's current border which doesn't change
when focused. Likely, the recipient input should be updated to match the
textbox's border color.
- The dividers in the formatting buttons row are not vertically centered
now. This should be figured out soon.
Fixes : #28702 .
2024-06-21 17:29:56 -07:00
ac002b358c
markdown: Improve alignment, spacing around horizontal rules.
2024-06-21 16:45:16 -07:00
7febb78b3b
markdown: Use interelement spacing on horizontal rules.
2024-06-21 16:45:16 -07:00
6b255fcc14
custom_profile_fields: Rename is_editable variable for clarity.
...
The variable is renamed to is_target_element_editable. This makes it
explicit that this variable is referring to HTML structure and not a
property of the field.
This is a prep commit for #22883 which allows admins to restrict users
from modifying field values.
2024-06-21 16:32:18 -07:00
9af71c690f
custom_profile_fields: Fix "required" field in OpenAPI documentation.
...
This is not an optional field and should be present in all API responses
of custom profile field object.
2024-06-21 16:32:15 -07:00
b6231f5568
zulip.yaml: Fix typo in IncludeCustomProfileFields description.
2024-06-21 16:32:15 -07:00
4ddc8f406d
onboarding_steps: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
72902d70f3
presence: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
438509a8f1
presence: Fix presence_last_update_id type.
...
It’s undefined for spectators.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
1a73101371
bot_data: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
bf8fc8429b
unread: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
9c2ab2842f
unread: Ignore deprecated sender_id synonym.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
ca99016f04
user_status: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
4b4ef75729
muted_users: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
8ce77cabae
user_topics: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
6bff8161ea
user_topics: Remove stream__name from user_topic_schema.
...
This field is internal to the backend and never escapes to the
frontend.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
97907b0a9c
pm_conversations: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
e28240a9ac
stream_data: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
9b511f5caa
sub_store: Fix ApiStreamSubscription["email_address"] type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
370a6c350e
local_message: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
788552b916
alert_words: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
1ee5c46a20
user_groups: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
41ec6c9b7c
user_groups: Fix UserGroupRaw["direct_subgroup_ids"] type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
d5cc7d7b79
emoji: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
3a4719915c
compose: Let pill-container dictate spacing of pills.
...
The 2px and 6px values expressed as variables here are taken from
@terpimost's mocks in Figma.
2024-06-21 14:46:44 -07:00
0844e2cba9
pills: Size pill components and inputs in ems.
2024-06-21 14:46:44 -07:00
39d4ddaa96
stream_edit_subscribers: Rename misleading variable.
...
.safeParse does not return a “schema”.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 14:44:52 -07:00
15d4866856
stream_edit_subscribers: Fix incorrect error result test.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 14:44:52 -07:00
5413002b5f
squash: Alya's edits.
2024-06-21 13:41:39 -07:00
73107c5de7
help-billing: Add information about international bank transfers.
2024-06-21 13:41:39 -07:00
05a480f1d1
zcommand: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
87a9877a93
attachments_ui: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
f2c3207538
stream_topic_history_util: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
3d64fb6cda
message_edit_history: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Karl Stolley
Mateusz Mandera
Anders Kaseorg
sanchi-t
Aman Agrawal
N-Shar-ma
tnmkr
Alya Abbott
Lauryn Menard
Varun Singh