1d4797834e
modals: Rename close_modal to close.
2023-10-10 16:43:57 -07:00
c809abf07f
modals: Rename close_modal_if_open to close_if_open.
2023-10-10 16:43:57 -07:00
0c7184aaa0
modals: Rename close_modal_active to close_active.
2023-10-10 16:43:57 -07:00
d54a917104
modals: Rename is_modal_open to is_open.
2023-10-10 16:43:57 -07:00
577a384845
overlays: Extract modal methods in separate file.
2023-10-10 16:43:57 -07:00
6713ad9d4d
overlays: Extract function checking if overlays or modals are open.
2023-10-10 16:43:57 -07:00
63c1c9a37a
overlays: Extract enable / disable scrolling to a util module.
2023-10-10 16:43:57 -07:00
065420853f
overlays: Fix spelling.
2023-10-10 16:43:57 -07:00
325b308ed5
about_zulip: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 13:20:31 -07:00
ce48aac3db
inbox: Fix stream name wrapping to next line.
2023-10-10 13:06:46 -07:00
e4252f8f08
settings_config: Change order of option for default view.
...
Inbox > Recent conversations > All messages
2023-10-10 13:06:46 -07:00
3a2fbfc2fd
inbox_ui: Fix mute / unmute not working.
...
This is fix for the old version of mute / unmute buttons.
Code borrowed from click_handlers.
2023-10-10 12:47:42 -07:00
881da05cd3
stream_settings_ui: Extract stream_settings_components module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 12:09:15 -07:00
22f4ecdad6
message_fetch: Don't use MessageList to fetch data for recent view.
...
Since load_messages now supports fetching data with only
MessageListData, we can just use it and avoid calling
MessageListView which also caused our polls and TODO widgets to
not render occasionally.
2023-10-10 11:11:19 -07:00
69e10b4dae
message_fetch: Handle MessageListData directly passed to load_messages.
...
This will allow us to use load_messages to fetch data using it
without initializing a MessageList.
2023-10-10 11:11:19 -07:00
88f4ecc943
compose_banner: Restore CSS overzealously removed in #27097 .
...
This also includes a comment for future contributors, explaining
why these styles are necessary.
2023-10-10 10:01:11 -07:00
521cb15a07
stream_ui_updates: Cut import of stream_settings_ui.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 09:08:53 -07:00
b9bb0d5aa8
settings_org: Cut import of settings_realm_user_settings_defaults.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 09:06:28 -07:00
1d43a4cccb
stream_edit: Extract toggler to new stream_edit_toggler module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 23:19:59 -07:00
3cac29a8e1
settings_org: Extract settings_components module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 17:26:49 -07:00
9ab1a726a0
inbox: Add page up/down support similar to recent topics.
...
Leaving page up / down to browser doesn't work very well due to
our custom header, filters and compose.
2023-10-09 16:36:24 -07:00
9fc6af220e
inbox: Handle latest message not fetched when replying.
...
Since inbox is populated based on unread data which is part
of /register request, it is possible that we don't have the
actual message in our message_store. In that case, we return
a fake message object.
2023-10-09 16:36:24 -07:00
2c4156e239
compose_reply: Remove unnecessary pm_recipient being set.
...
`pm_recipient` is already set in `else` case unconditionally,
so setting it early is not required.
2023-10-09 16:36:24 -07:00
bb740ca65e
inbox: Fill compose with dm/stream info for `reply` on inbox-header.
2023-10-09 16:36:24 -07:00
2561e7f2d8
inbox: Set compose recipient according to focused row on `reply`.
...
Fill compose recipient based on the latest message of the focused
row.
2023-10-09 16:36:24 -07:00
50a356389c
inbox: Update closed compose text based on focused element.
...
For header rows, search and filters we just show default text.
2023-10-09 16:36:24 -07:00
3ac6f447d9
inbox_ui: Change current_focus_id when clicking on inbox search.
2023-10-09 16:36:24 -07:00
64cc24722f
inbox_ui: Rename function to reflect it only works for focus in list.
2023-10-09 16:36:24 -07:00
3cbd772b8d
inbox: Make focus outline around unread count wider.
2023-10-09 16:36:24 -07:00
80a7e995af
inbox: Fix spelling mistakes.
...
Found a good spell checker, hopefully no more of those.
2023-10-09 16:36:24 -07:00
e9c86dc524
inbox: Add topic visibility indicator.
2023-10-09 16:36:24 -07:00
8c619d6938
inbox: Rename variable for readability.
2023-10-09 16:36:24 -07:00
49f553ebfc
inbox: Add rectangle focus border around inbox header name.
2023-10-09 16:36:24 -07:00
50928314f2
settings_users: Remove get_status_field.
...
It’s effectively unused since commit
2d5c678614#25061 ), as predicted by
commit d45f0171cb#14919 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 16:05:31 -07:00
95b9d6f7e2
settings: Move set_settings_header to settings_panel_menu.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 16:04:30 -07:00
9abc2cb3fd
signup: Add link to redirect user to login page in the form.
2023-10-09 14:36:54 -07:00
8f564749bb
dependencies: Upgrade JavaScript dependencies.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 14:16:23 -07:00
835ee69c80
docs: Fix grammar errors found by mwic.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 13:24:09 -07:00
4cb2eded68
typos: Fix typos caught by typos.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 11:55:16 -07:00
7b4a74cc4d
codespell: Fix typos caught by codespell.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 11:55:15 -07:00
eea59e2edc
compose_banners: Hide upload progress banner on error.
2023-10-09 11:55:01 -07:00
d887fb57e7
compose_banners: Better align action and cancel buttons.
...
This uses the banner message's line-height to set a
max-height on the action and cancel buttons to maintain
a consistent vertical spacing.
Additional uses of flexbox here:
1. help the button to remain shorter when it's adjacent a
single-line banner message, and
2. center the closing X icon relative to the current size
of the action button, when one is present
2023-10-09 11:55:01 -07:00
fe8fc98912
compose_banners: Structure innner <p> elements with .banner_message class.
...
This also styles those inner .banner_message elements to lose
margin inherited from Bootstrap. (This is now also applied to
the upload-message banner.)
It's better to achieve that with a class selector; using a `p`
element selector would mean that such a style would be evaluated
for all `<p>` elements in the DOM. Which is of course a whole lot,
thanks to Markdown alone.
Fixes : #26922
2023-10-09 11:55:01 -07:00
1581c6f847
compose_banners: Add .banner_content to elements that need it.
2023-10-09 11:55:01 -07:00
3fdf85872e
compose_banners: Remove unnecessary upload-message styles.
2023-10-09 11:55:01 -07:00
756b465b47
bootstrap: Remove last vestiges of bootstrap-tooltip library.
...
Everything but this sliver of CSS has been deleted previously as part
of our migration off Bootstrap.
2023-10-09 11:39:12 -07:00
c69fe4b6a0
popover: Remove `.popover` class.
...
Since we are not using bootstrap popover, we don't have popovers
with that class.
2023-10-09 11:39:12 -07:00
8430674aee
popovers: Remove unused popover-content class.
...
Fixes #26821
2023-10-09 11:39:12 -07:00
a04117b6d3
user_group_info_popover: Remove bootstrap popover classes.
...
Added a `group-info-content` inplace of them and added the required
CSS.
2023-10-09 11:39:12 -07:00
04c4b6e8b8
giphy: Move `popover-content` styles to `giphy-scrolling-container`.
2023-10-09 11:39:12 -07:00
094ac010fb
user_card_popover: Remove popover content class.
...
Added CSS styles that were removed due to this back. No visual
changes.
2023-10-09 11:39:12 -07:00
ce656da8d7
emoji_popover: Remove popover-content div.
...
`popover-content` class had no effect on emoji popover since
it was resetting `padding: 0` and background color was
already applied by tippy theme.
In short, removing `popover-content` had no visual changes.
2023-10-09 11:39:12 -07:00
5cd2b0ed86
giphy: Remove old comment.
...
Destroying popover_instance is now part of how tippy popovers work.
2023-10-09 11:39:12 -07:00
0976b9006e
popover-title: Remove class.
...
Remove bootstrap-tooltip class `popover-title` from code.
It was only used in user_card_popover for showing user avatar,
so cleaned up properties that were duplicated or not required.
2023-10-09 11:39:12 -07:00
b9fe1947f8
navigate: Move scroll_to_selected to message_viewport.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 11:32:16 -07:00
18bdfde9e7
recent_view_ui: Cut import of unread_ops.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 11:32:16 -07:00
95785739ac
navbar_alerts: Move resize_app to resize.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 11:32:16 -07:00
7ffdeecd86
styles: Remove CSS for ".modal-header".
...
We do not use "modal-header" on any elements now, so
we can remove the redundant CSS rules defined for it.
2023-10-09 11:25:26 -07:00
747b62d050
bootstrap: Remove code for bootstrap modals.
...
We use micromodal library for all the modals now and thus
we no longer require the bootstrap modal code.
2023-10-09 11:25:26 -07:00
37d12250ed
modal: Re-add required bootstrap CSS for ".modal-body".
...
This commit adds the required bootstrap CSS rules for
".modal-body" elements to modal.css so that we can remove
them from bootstrap.css.
2023-10-09 11:25:26 -07:00
5e263fc4ed
subscriptions: Re-add bootstrap CSS for modal-footer elements.
...
We use "modal-footer" class in stream and user group creation form
and this commit adds bootstrap CSS rules for it to subscriptions.css
so that we can remove the CSS from bootstrap.css.
2023-10-09 11:25:26 -07:00
5b7014e7d6
server_history: Prevent concurrent requests for the same stream_id.
...
This commit updates the 'get_server_history' function to return
early if a request is already in progress for a given stream_id,
thus preventing concurrent requests for a single stream_id.
We maintain a set 'request_pending_stream_ids', which contains all
the stream IDs for whom requests are in progress.
Using this set, we return early.
Fixes #26915 .
2023-10-09 11:17:03 -07:00
0cdb54cf65
compose: Ensure cursor is scrolled into view after content is inserted.
...
This fixes the bug where on pressing enter after the last line in a
textarea, the cursor would go to the new line but the textarea would
not scroll it into view unless more was typed. This was observed on
chromium browsers.
A new function `insert_and_scroll_into_view` is added to `compose_ui.js`
which blurs and refocuses the textarea after inserting the content, then
autosizes the textarea.
2023-10-09 11:13:53 -07:00
acdae9eae2
reload: Don't reload on 403 error for spectators.
...
Fixes #26280
2023-10-09 11:00:33 -07:00
8299506e7a
reload: Handle early attempts at reload when loading the app.
...
Trying to preserve state when app modules like message_lists
haven't been init results in errors.
2023-10-09 11:00:33 -07:00
5327bcc5ac
user_group_settings_ui: Merge into user_group_edit.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 10:58:50 -07:00
63b4e74cea
views_util: Cut import of narrow.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 10:54:00 -07:00
e8ced3e74a
hello: Fix google analytics not working.
...
Since GA was only imported in portico bundle which we don't use
in hello page due to bootstrap, GA was not loaded.
2023-10-08 17:30:02 -07:00
70748181da
recent_view_ui: Cut import of user_card_popover.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 19:45:13 -07:00
27991bd5b0
topic_zoom: Merge into stream_list.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 19:43:55 -07:00
a43ea3efaa
pm_list: Cut import of topic_zoom.
...
topic_zoom.is_zoomed_in() can’t be true in pm_list.zoom_in, because
“more conversations” would not be visible in that state. And it can’t
be true when pm_list.handle_narrow_activated calls pm_list.expand,
because “more topics” would not be visible in an all-DM view. So the
only non-inert call is via click_handlers; move it there.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 19:43:55 -07:00
564e91f3a8
narrow: Cut import of hashchange.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 19:41:59 -07:00
4adfd57378
message_fetch: Rename batch size constants to specify narrow views.
...
This is in preparation for introducing a batch size constant for
the recent view.
2023-10-06 17:30:33 -07:00
ba1895cb1c
notifications: Rename to desktop_notifications.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
fcaf1fe7d5
notifications: Split out audible_notifications module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
6ef08873d8
notifications: Split out compose_notifications module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
db20fd12e0
notifications: Split out message_notifications module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
e48771993b
widgetize: Move widget registration to new widgets module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 13:17:51 -07:00
0c991d813f
sent_messages: Lift event loop restarting to transmit.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 13:17:51 -07:00
339b1351f8
echo: Pass transmit.send_message as a callback.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 13:17:51 -07:00
b9dd4a14c9
hello: Write better variable names.
2023-10-06 12:51:57 -07:00
cbb09f4ee6
hello: Fix client logos not changing on hello page.
...
Since `zulip.com` doesn't has `/hello` in URL, the JS code
for hello page events was not running. We extract it to a new
file and just always run it.
2023-10-06 12:51:57 -07:00
b274169ccc
util: Fix the 'find_wildcard_mentions' function.
...
The function considers @**all**, @**everyone**, @**stream**,
and @**topic** as wildcard mentions.
Earlier, the function didn't have a check to match @**topic**
in the message_content.
2023-10-06 11:38:37 -07:00
1a867a43a7
left_sidebar_inbox_popover: Move to new popovers folder.
2023-10-06 11:24:40 -07:00
115de0e847
inbox_ui: Fix unable to insert new stream.
...
There were 2 issues:
* Wrong format for creating new Map object used.
* Use of `topic_dict` instead of `topics_dict`, which resulted
in `stream_key` being present in `topics_dict` even after stream
has been marked as read. This made inbox believe that the
stream was already rendered even though it was not.
2023-10-06 10:50:34 -07:00
9dc1e8ed17
sent_messages: Finish .received → .saw_event rename.
...
Commit 3cc2adcd3b#25423 ) missed this
in the rename, resulting in extra creation of no-op timers.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 10:49:42 -07:00
4e9c1293e2
compose: Only save as draft when the compose state is about to change.
...
Up until now, we unconditionally saved any message content as a draft
whenever the composebox was `start`ed. This led to a lot of unnecessary
saving of drafts even when the composebox stayed undisturbed.
To fix this, now we only save the draft when the compose state is about
to be overidden, which is by either changing the recipient narrow or by
restoring another draft.
Fixes : #26976 .
2023-10-06 09:22:41 -07:00
895439ad83
register: Move style to css file.
2023-10-06 09:19:01 -07:00
e1b22a04e7
register: Fix for small widths.
2023-10-06 09:19:01 -07:00
15e837ff25
org_registration: Fix page for mobile widths.
2023-10-06 09:19:01 -07:00
f19d7e36ee
recipient-row: Remove logic for floating recipient bar.
...
In #23900 , the floating recipient bar was replaced with a sticky
recipient bar. The logic in `id_for_recipient_row` was not updated
for that change, so we update that function to just get the first
message in the group and return that message ID.
2023-10-06 09:13:27 -07:00
971a003180
compose_actions: Extract compose_reply module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 09:07:43 -07:00
f85f904fc1
user_profile: Remove redundant call to popovers.hide_all.
...
`show_user_profile` is only triggered by clicks. Even `enter`
keypress is triggers a click via
`popover_items_handle_keyboard_with_overrides`.
2023-10-06 09:03:46 -07:00
6cfb7239c8
popover_menus: Remove hide_all from on_show functions.
...
Since popovers only open after a click, all popovers hide already
if the clicks were outside them.
2023-10-06 09:03:46 -07:00
4e4daf2ce5
overlays: Call open and close hooks for modals too.
...
Right now, the hooks only have a popovers.hide_all call but this
may need to audited when used in future. Added a comment to
that effect.
2023-10-06 09:03:46 -07:00
3cbfe6f31f
tests: Remove unnecessary mocks of recent_view_util.
...
Since is_visible was refactored to use a variable, these mocks
are not required.
Also, since is_visible return `false` by default, mocking it
to return false is not required.
2023-10-06 08:35:21 -07:00
c56f784489
compose: Move update_email to compose_state.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 08:34:39 -07:00
833a15e121
compose: Move call button display functions to compose_call_ui.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 08:34:39 -07:00
9c70f92514
reload: Move initialize to new reload_setup module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 08:34:39 -07:00
c4d338a6ab
drafts: Extract drafts_overlay_ui module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 08:30:31 -07:00
Aman Agrawal
Anders Kaseorg
Karl Stolley
Tim Abbott
Sahil Batra
Prakhar Pratyush
N-Shar-ma
evykassirer
Prakhar Pratyush
Lauryn Menard