zulip

Commit Graph

Author	SHA1	Message	Date
Mohit Gupta	42d886a6d5	messages: Add loading spinner for deleting messages. User was able to click delete button multiple time which could cause multiple delete requests. This commit disables and hides the delete message button after the first click and shows a spinner until http the delete request responds. Also adds a casperjs test to ensure that spinner becomes visible and delete button becomes invisible after clicking on delete button for first time and hides spinner and show delete buttton when message is deleted. Fixes: #11219.	2019-01-25 11:07:02 -08:00
Umair Khan	6ee08e0602	casper: Fix waiting condition in message deletion tests. We now specifically wait for the length to decrease by one. This seems like a more deterministic condition to wait on. Previously we were waiting till the id of the deleted message remained visible; intuitively, this should have worked but it seems that there is some race condition that was causing the test to fail sporadically.	2017-05-30 22:49:59 -07:00
K.Kanakhin	2434f2d96c	messages: Add support for admins deleting messages. This makes it possible for Zulip administrators to delete messages. This is primarily intended for use in deleting early test messages, but it can solve other problems as well. Later we'll want to play with the permissions model for this, but for now, the goal is just to integrate the feature. Note that it saves the deleted messages for some time using the same approach as Zulip's message retention policy feature. Fixes #135.	2017-05-29 21:59:38 -07:00

Author

SHA1

Message

Date

Mohit Gupta

42d886a6d5

messages: Add loading spinner for deleting messages.

User was able to click delete button multiple time which could cause
multiple delete requests. This commit disables and hides the delete
message button after the first click and shows a spinner until http
the delete request responds.

Also adds a casperjs test to ensure that spinner becomes visible and
delete button becomes invisible after clicking on delete button for
first time and hides spinner and show delete buttton when message is
deleted.

Fixes: #11219.

2019-01-25 11:07:02 -08:00

Umair Khan

6ee08e0602

casper: Fix waiting condition in message deletion tests.

We now specifically wait for the length to decrease by one. This seems
like a more deterministic condition to wait on.

Previously we were waiting till the id of the deleted message remained
visible; intuitively, this should have worked but it seems that there
is some race condition that was causing the test to fail sporadically.

2017-05-30 22:49:59 -07:00

K.Kanakhin

2434f2d96c

messages: Add support for admins deleting messages.

This makes it possible for Zulip administrators to delete messages.
This is primarily intended for use in deleting early test messages,
but it can solve other problems as well.

Later we'll want to play with the permissions model for this, but for
now, the goal is just to integrate the feature.

Note that it saves the deleted messages for some time using the same
approach as Zulip's message retention policy feature.

Fixes #135.

2017-05-29 21:59:38 -07:00

3 Commits