6 Commits

Author	SHA1	Message	Date
Steve Howell	2a19468432	subscribers: Use current_stream_id to track current stream.	2021-12-30 11:36:52 -08:00
Steve Howell	208cec2848	refactor: Move update_subscribers_list. ... We should be able to solve the import back to stream_edit in an upcoming commit.	2021-12-30 11:36:52 -08:00
Steve Howell	49a1d5a9a3	refactor: Reduce scope of message var.	2021-12-30 11:36:52 -08:00
Steve Howell	d7f90acbf6	refactor: Extract remove_subscriber.	2021-12-30 11:36:52 -08:00
Steve Howell	e742ebb8e8	refactor: Limit scope of e.target. ... Now our click handlers get stream_id directly from e.target, and then downstream code is no longer coupled to the event semantics. Note that we'll probably just know the stream_id more directly after future commits. We also remove a little bit of redundant error handling.	2021-12-30 11:36:52 -08:00
Steve Howell	0777cd73bb	stream edit: Extract stream_subscribers_ui.js. ... This is a fairly straightforward extraction. It's good to test this with Iago, and then go into Manage Streams and add/remove subscribers for a stream like devel. I copy/pasted two small functions that will soon diverge from stream_edit. The get_stream_id function will either use a module variable (since we're generally only editing subscribers for one stream, and we already have the singleton assumption with `input_pill`) or a more strict CSS selector. And then get_sub_for_target depends on get_stream_id. We may not always need full subs, anyway, and when we adapt some of this code for creating streams, things are likely to change. I stopped exporting a couple functions that have no callers outside of this module. The main entry point for the module is enable_subscriber_management. We continue to export invite_user_to_stream and remove_user_from_stream, which should possibly be just pulled into their own module to lessen some dependencies, but they don't have too much baggage, since they just wrap channel calls.	2021-12-30 11:36:52 -08:00