966e161fb2
Fix ui.home_tab_obscured to detect modals open.
...
All open modals now should have the selector ".overlay.show",
so checking if a modal is open is as simple as checking the length
of the selection ".overlay.show".
Fixes #3655 .
2017-03-15 15:45:10 -07:00
17c8527856
nagios: Clean up check_send_receive_time arguments.
2017-03-15 12:52:27 -07:00
0ff1f3d663
nagios: Error on heartbeat events in check_send_receive_time.
...
It was probably going to fail anyway if those show up, but this
produces a clearer failure mode.
2017-03-15 12:51:19 -07:00
04195e0be6
modals: Add blueslip error reporting for invalid modal.
...
This should help if we screw up adding an additional modal in the future.
2017-03-15 12:35:23 -07:00
3bc2ed6dc9
Switch "invite users" to new component overlay.
...
Fixes #4036 .
2017-03-15 12:29:09 -07:00
6ddf3abe40
Fix pointer events in #settings overlay form sidebar.
...
The pointer events for the sidebar were incorrect in the way they
were set such that when the sidebar was off to the right and
hidden it would still attract pointer events.
2017-03-15 12:28:49 -07:00
b0e5aeb313
Consolidate JavaScript modal closing in modals.js.
...
This consolidates all actions to close modals into modals.js and
triggers the correct cleaning/collapsing function dependent on what the
data-overlay attribute is labeled as.
It also ensures these all have an e.stopPropagation().
Fixes #4029 .
2017-03-15 12:27:44 -07:00
8ef20a0ed2
Remove meta.focusing boolean.
...
This was supposed to prevent unwanted modal closes but due to the new
mechanics of modals, it’s better to not prevent the first click.
2017-03-15 12:17:27 -07:00
2e30cef8e9
Change "hashchange.exit_settings" to "hashchange.exit_modal".
...
Change the name of the hashignore and replace mechanism from
exit_settings to exit_modals since it is now used for more than just
the settings.
2017-03-15 12:17:27 -07:00
075b7cd630
Switch "streams" to new component overlay.
2017-03-15 12:17:27 -07:00
b1839268cd
Switch "settings" to new component overlay.
2017-03-15 12:17:27 -07:00
21525ee4db
Switch "informational overlays" to new component overlay.
2017-03-15 12:17:27 -07:00
8419eedcbd
Switch "lightbox" to new component overlay.
2017-03-15 12:17:27 -07:00
81b2114d8c
Switch "drafts" to new component overlay.
2017-03-15 12:17:27 -07:00
c324cdf6cb
Add component overlay classes.
...
These are the classes that should apply to all overlays and replace
their current functions.
2017-03-15 12:17:27 -07:00
f77c5fc086
settings: Extend `DATA_UPLOAD_MAX_MEMORY_SIZE` from default value.
...
- In django 1.10 was added `DATA_UPLOAD_MAX_MEMORY_SIZE` parameter,
which controls max size of uploading files. By default it is 2.5MB.
2017-03-15 12:15:27 -07:00
40fb6ea80e
lint: Prevent importing from zerver in migrations.
2017-03-15 12:02:24 -07:00
f44caaf36e
Focus on the close button when viewing the edit message history.
...
Fixes #4035 .
2017-03-15 11:43:50 -07:00
f47d7b7290
user docs: Update docs to replace *Custom alert words* with *Alert words*.
...
Fixes #4066
2017-03-15 11:25:37 -07:00
589551b6ee
settings: Change "Custom alert words" to "Alert words".
2017-03-15 11:25:37 -07:00
242d3ffaf4
Add timezone field in UserProfile.
...
Implements backend of #1506 .
2017-03-15 11:18:24 -07:00
0d296afa54
github: Return '' when name is None.
2017-03-15 11:11:09 -07:00
e44e58f6d5
logging: Skip log records originated in site packages.
...
This fixes the huge exception we get in our logs from django.template
logger. This exception is a known bug in Django, see
https://code.djangoproject.com/ticket/26886
Fixes #3974
2017-03-15 11:07:31 -07:00
902207da71
node: Update package.json to eliminate vulnerable dependecies.
2017-03-14 18:21:00 -07:00
c155577246
Allow users to resize the message compose box.
...
This allows for users to resize the message compose box without it
collapsing back down to jQuery autosize’s preferred height.
When you hide the compose box and then re-show it, it keeps the
previous height but reactivates the jQuery module.
Fixes : #2236 .
2017-03-14 17:40:21 -07:00
af4718c50c
retention.py: Remove use of domain from get_expired_messages.
...
get_expired_messages seems to only be used by tests anyway.
2017-03-14 17:17:42 -07:00
92dd767519
management commands: Change help text to say realm instead of domain.
2017-03-14 17:17:42 -07:00
0c032adbde
create_realm.py: Remove --domain option.
...
Realm domains can now be managed via Admin Settings in the web app.
2017-03-14 17:17:42 -07:00
4627ff1b4b
zproject: Change comments to refer to Realm.string_id instead of domain.
2017-03-14 17:17:42 -07:00
ba228b75b1
zilencer: Use Realm.string_id for get_deployment_from_domain.
...
This is dead code. Getting rid of realm__domain since we're about to remove
that field from Realm.
2017-03-14 17:17:42 -07:00
8fecd454aa
forms.py: Remove unused function get_registration_string(domain).
2017-03-14 17:17:42 -07:00
ddd0b854f9
Remove references to page_params.domain.
...
Continuation of 098797c
2017-03-14 17:17:42 -07:00
e7b3ea8fab
coverage: Require 100% coverage in analytics.
2017-03-14 17:11:25 -07:00
85fe53f5e3
coverage: Don't require test coverage for __unicode__ methods.
...
These are usually just used for manual debugging, and so aren't super
important to make sure we have tests for always.
2017-03-14 17:07:18 -07:00
7c6f0033ed
analytics: Add test for do_drop_all_analytics_tables.
2017-03-14 16:59:54 -07:00
87981a2bf1
analytics: Fix direct import of models in migrations.
2017-03-14 16:59:54 -07:00
ebebd04587
analytics: Fix ValueErrors affecting test coverage.
...
Pathways that only catch internal code errors should use AssertionError so
that they are not included when computing test coverage.
2017-03-14 16:59:54 -07:00
b18bfe6771
analytics: Standardize format of zerver count queries.
...
count_message_type_by_user_query is in a different format (no WHERE clause)
from the rest since I'm having a hard time reasoning about how that would
interact with the LEFT JOIN, especially given that there are %(join_args)s.
2017-03-14 16:59:54 -07:00
e33ef1c788
analytics/models: Remove extended_id and key_model.
...
They are unused / were part of a previous design.
2017-03-14 16:59:54 -07:00
b648c06009
hotkeys/refactor: Extract tab key handlers.
...
This extracts process_tab_key() and process_shift_tab_key().
It also removes some dead code related to alert words tabbing.
2017-03-14 16:42:40 -07:00
bdbaa5d386
hotkeys: Simplify navigation checks for page up/down.
...
We remove an unnecessary conditional that always returned true
due to checks that happen earlier in the function.
2017-03-14 16:42:40 -07:00
58c057a024
node tests: Add test_motion_keys().
2017-03-14 16:42:40 -07:00
2a3e74427b
Export hotkey.tab_up_down() for testing.
2017-03-14 16:42:40 -07:00
7a804de485
user docs: Update *Send a private message*.
...
Add keyboard shortcut info to user doc. Fixes #156
2017-03-14 15:54:20 -07:00
d764f0e0f1
user docs: Update *Send a stream message*.
...
Add keyboard shortcut info to user doc.
2017-03-14 15:54:20 -07:00
6deee116dc
user docs: Update *Enable or disable pressing enter to send*.
...
Add keyboard shortcut info to user doc.
2017-03-14 15:54:20 -07:00
f510ada67a
templates: Add insert new line shortcut to *Keyboard shortcuts* modal.
2017-03-14 15:54:20 -07:00
87dd0c225a
keyboard_shortcuts: Move @ near more similar keys.
2017-03-14 15:54:03 -07:00
8a408a6cbc
popovers: Fix actions popover menu positioning.
...
The main issue is that it wasn't doing the correct comparison; the old
logic that subtracted the viewport.scrollTop() was incorrect for how
our popovers seem to work.
Partially fixes #3741 .
2017-03-14 15:37:37 -07:00
e3fa42f833
edit: Hide emoji reactions when in message edit or view source mode.
...
This also entails displaying them when the editing mode ends.
Fixes #3870 .
2017-03-14 14:55:16 -07:00
Brock Whittaker
Tim Abbott
K.Kanakhin
Rishi Gupta
aakash-cr7
Cynthia Lin
Umair Khan
Steve Howell
Abhishek Bhattacharya
Philip Skomorokhov