Steve Howell
27072289ce
refactor: Extract zerver/lib/home.py.
...
The two functions extracted here are mostly
copied verbatim, but we use dataclasses
to marshal the values back.
2020-07-22 17:15:02 -07:00
Steve Howell
26e4d34e81
refactor: Move code up higher in home view.
...
The two pieces of code here don't need to be
intermingled with the bigger task of building
page_params.
2020-07-22 17:13:53 -07:00
Mohit Gupta
7bbba74d95
loggers: Set propagate False for zulip.slow_queries logger.
...
This will prevent it to propagating to root logger and causing flaky
behavior in tests which verify logs by root logger using assertLogs.
2020-07-22 17:12:28 -07:00
Mohit Gupta
e25365ee3e
tests: Mock patch print() in test_custom_markdown_include_extension.
...
This is to avoid spam in test-backend output.
2020-07-22 17:12:28 -07:00
Mohit Gupta
7d574795f1
tests: Remove unnecessary print statments.
...
This removes spam in test-backend output caused by print statement.
2020-07-22 17:12:28 -07:00
Mohit Gupta
a2a368df54
tests: Mock print() for management command tests.
...
This avoids spam in test-backend output.
2020-07-22 17:12:28 -07:00
Mohit Gupta
9a10929a6c
tests: Verify warning log if multiple teams found in mattermost import.
...
Uses assertLogs to prevent spam in test-backend output.
2020-07-22 17:12:28 -07:00
Ryan Rehman
6a245d6d93
minor: Refactor `set_up_typeahead_on_pills` function interface.
...
This is a prep commit which passes the `update_func` and `source`
data through an object. This will be helpful as there are plans
to pass furthur information to the function (i.e. whether we should
allow creating pills from streams and/or user-groups).
2020-07-22 17:00:34 -07:00
SiddharthVarshney
67cee7c8f9
css: Use SCSS nesting for `.faqs`.
2020-07-22 16:58:14 -07:00
SiddharthVarshney
ba36b99cd2
css: Use SCSS nesting for `.faqs .faq`.
2020-07-22 16:58:14 -07:00
SiddharthVarshney
4d2593a6bf
css: Use SCSS nesting for `.faqs header`.
2020-07-22 16:58:14 -07:00
SiddharthVarshney
f28c729707
css: Use SCSS nesting for `.compare`.
2020-07-22 16:58:14 -07:00
SiddharthVarshney
04bcab0f4c
css: Use SCSS nesting for `.compare .terms`.
2020-07-22 16:58:13 -07:00
SiddharthVarshney
04a49fc402
css: Use SCSS nesting for `.compare tbody tr`.
2020-07-22 16:58:13 -07:00
SiddharthVarshney
fb1a593281
css: Use SCSS nesting for `.compare tbody tr td`.
2020-07-22 16:58:13 -07:00
SiddharthVarshney
4c0a4d4cef
css: Use SCSS nesting for `.compare thread`.
2020-07-22 16:58:13 -07:00
SiddharthVarshney
457023dde6
css: Use SCSS nesting for `.compare thread th`.
2020-07-22 16:58:13 -07:00
SiddharthVarshney
456c0b78e0
css: Use SCSS nesting for `.compare table`.
2020-07-22 16:58:13 -07:00
SiddharthVarshney
f1c70be50a
css: Use SCSS nesting for `.compare table thead th`.
2020-07-22 16:58:13 -07:00
Vishnu KS
67bacd6e31
billing: Don't allow guest users to upgrade.
2020-07-22 16:57:49 -07:00
Vishnu KS
cb01a7f599
billing: Restrict access to billing page to realm owners and billing admins.
2020-07-22 16:57:49 -07:00
Steve Howell
a6519e7b8f
event_schema: Extract check_user_group_add.
2020-07-22 16:48:19 -07:00
Steve Howell
3f25e52667
event_schema: Extract check_user_status.
2020-07-22 16:48:19 -07:00
Steve Howell
631adc5677
event_schema: Extract check_alert_words.
2020-07-22 16:48:19 -07:00
Steve Howell
0a9a9d8258
event_schema: Extract check_custom_profile_fields.
2020-07-22 16:48:19 -07:00
Steve Howell
7176b90882
event_schema: Extract check_typing_start.
2020-07-22 16:48:19 -07:00
Steve Howell
5f3ea0a659
event_schema: Extract check_invites_changed.
2020-07-22 16:48:19 -07:00
Steve Howell
ec17091521
event_schema: Extract check_submessage.
2020-07-22 16:48:19 -07:00
Steve Howell
92136d738a
event_schema: Extract check_reaction.
2020-07-22 16:48:19 -07:00
Steve Howell
5209de0261
event_schema: Extract check_update_message_flags.
2020-07-22 16:48:19 -07:00
Steve Howell
f2bc22e869
event_schema: Extract check_update_message*.
2020-07-22 16:48:19 -07:00
Steve Howell
b81f3433d8
event_schema: Extract check_message.
2020-07-22 16:48:19 -07:00
Steve Howell
385050de20
event_schema: Extract check_realm_bot_(delete/remove).
...
It is strange that we have both of these events.
2020-07-22 16:48:19 -07:00
Steve Howell
96f5ab1c87
event_schema: Extract check_realm_bot_update.
2020-07-22 16:48:19 -07:00
Steve Howell
f5c4ee4477
event_schema: Extract check_realm_bot_add.
...
Note that we use the actual integer bot_type
value now to determine how we validate
services.
2020-07-22 16:48:19 -07:00
Steve Howell
0a6ce36ac9
event_schema: Extract check_update_global_notifications.
2020-07-22 16:48:19 -07:00
Steve Howell
96b821684b
event_schema: Extract check_update_display_settings.
2020-07-22 16:48:19 -07:00
Steve Howell
dd5949274d
event_schema: Extract check_subscription_peer_*.
2020-07-22 16:48:19 -07:00
Steve Howell
502f1b9fe2
event_schema: Extract check_subscription_remove.
2020-07-22 16:48:19 -07:00
Steve Howell
055f1a590d
event_schema: Extract check_subscription_add.
2020-07-22 16:48:19 -07:00
Steve Howell
b116f1e911
event_schema: Extract check_stream_update.
2020-07-22 16:48:19 -07:00
Steve Howell
14aa87a168
event_schema: Extract check_stream_create.
2020-07-22 16:48:19 -07:00
Steve Howell
a6796e9e86
event_schema: Extract check_realm_update.
2020-07-22 16:48:19 -07:00
Steve Howell
e49acfa637
event_schema: Extract event_schema.py.
...
Obviously, this file will soon grow--this
was the easiest way to start without introducing
noise into other commits.
It will soon be structurally similar
to frontend_tests/node_tests/lib/events.js--I
have some ideas there. But this should also
help for things like API docs.
2020-07-22 16:48:19 -07:00
Steve Howell
a908f5a693
test_events: Improve check_events_dict.
...
We add the ability to supply optional_keys,
and we don't mutate the list of required
keys that gets passed into us.
We also enforce that there is a "type"
field.
(We will use optional_keys soon.)
2020-07-22 16:48:19 -07:00
Tim Abbott
26bafa2e73
docs: Fix versions in stretch=>buster documentation.
2020-07-22 16:35:05 -07:00
Vinit Singh
308cf8ac00
markdown: Inline Youtube previews instead of appending it to the end.
...
This change makes our handling of youtube-url previews consistent
with how we handle our inline images. This allows the previews to
render next to the paragraph that links to the youtube video.
Follow-up to PR #15773 .
2020-07-22 16:11:17 -07:00
Tim Abbott
c83df88aeb
help: Improve documentation for Gitter import.
2020-07-22 16:08:48 -07:00
Mateusz Mandera
6a50911032
auth: Allow signing in to an existing account with noreply github email.
...
In particular importing gitter data leads to having accounts with these
noreply github emails. We generally only want users to have emails that
we can actually send messages to, so we'll keep the old behavior of
disallowing sign up with such an email address. However, if an account
of this type already exists, we should allow the user to have access to
it.
2020-07-22 15:50:43 -07:00
Anders Kaseorg
ab6ed22bff
docs: Document that we use Prettier.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-22 15:49:48 -07:00