Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
30,103 Commits 28 Branches 143 Tags 627 MiB
Commit Graph

5 Commits

Author SHA1 Message Date
Steve Howell bacf896228 poll widget: Clean up code and add edit controls. 
NOTE: If you revert this commit, you want to revert
the immediately prior commit as well.  The history
is that Ishan made some improvements to the widget,
but there were some minor bugs.  I decided not
to squash the commits together so that the git
history is clear who did what.  (In particular, I
want questions about the JS code to come to me if
somebody does `git blame`.)

Anyway...

This is a fairly significant rewrite of the polling
widget, where I clean up the overall structure of
the code (including things from before the prior
fix) and try to polish the prior commit a bit as
well.

There are a few new features:

    * We tell "other" users to wait for the poll
      to start (if there's no question yet).
    * We tip the author to say "/poll foo" (as
      needed).
    * We add edit controls for the question.
    * We don't allow new choices until there's
      a question.
 2019-01-22 10:27:39 -08:00
Tim Abbott 7485cb2a50 widgets: Rename voting_widget to poll_widget. 
This ensures greater consistency with our other widgets' naming
convention.
 2018-12-16 19:46:48 -08:00
Tim Abbott 728c601ff4 poll widget: Only show "Add option" if a question has been set. 
This makes the UI less confusing.
 2018-12-16 11:59:21 -08:00
Shubham Dhama ced6f967bc voting_widget: Increase node test coverage to 100%. 2018-07-06 11:30:12 -04:00
Steve Howell 1fdfe11e8b node tests: Add tests for voting_widget.js. 
This first commit starts by testing handling of
inbound data.
 2018-07-02 13:46:30 -04:00