zulip

Commit Graph

Author	SHA1	Message	Date
Lalit	88c23933bb	util: Change parameter type of `sorted_ids` to `number[]`. This function was mistyped; it was used in practice both accepting string[] and number[], with the implementation taking advantage of the fact that number.parseInt(<int>, 10) = <int>. The only string[] callers were some overly defensive typing_data tests that don't match the actual typing_data interface, so we remove the string[] support and adjust the function's type, as well as those tests.	2023-03-03 12:04:42 -08:00
Anders Kaseorg	cea1119423	node_tests: Move to web/tests. This lets us simplify the long-ish ‘../../static/js’ paths, and will remove the need for the ‘zrequire’ wrapper. Signed-off-by: Anders Kaseorg <anders@zulip.com>	2023-02-23 16:04:17 -08:00

Author

SHA1

Message

Date

Lalit

88c23933bb

util: Change parameter type of `sorted_ids` to `number[]`.

This function was mistyped; it was used in practice both accepting
string[] and number[], with the implementation taking advantage of the
fact that number.parseInt(<int>, 10) = <int>.

The only string[] callers were some overly defensive typing_data tests
that don't match the actual typing_data interface, so we remove the
string[] support and adjust the function's type, as well as those
tests.

2023-03-03 12:04:42 -08:00

Anders Kaseorg

cea1119423

node_tests: Move to web/tests.

This lets us simplify the long-ish ‘../../static/js’ paths, and will
remove the need for the ‘zrequire’ wrapper.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

2023-02-23 16:04:17 -08:00

2 Commits