7187146422
install: Move PUPPET_CLASSES env var to --puppet-classes argument.
...
`--no-init-db` is used to silence the need for `--hostname` and
`--email` arguments; it is a proxy for "this is not a frontend host."
We would ideally like to use `has_class` to know if the user's
provided puppet classes are include an `app_frontend`, and thus
`--hostname` and `--email` are required -- but doing that requires
several other steps, and we would like this feedback to be immediate.
We make the presence of `--puppet-classes` equivalent to
`--no-init-db`, since nearly every configuration with
`--puppet-classes` does not install both a database and a frontend,
which is what is required to initialize a database.
2024-04-04 16:49:43 -07:00
89484fbbe6
install: Remove the hidden VIRTUALENV_NEEDED parameter.
...
We can do this behaviour better by using `has_roles`.
2024-04-04 16:49:42 -07:00
d6f4424102
compose_actions: Convert module to typescript.
2024-04-04 16:34:42 -07:00
b32c837c6b
settings_playgrounds: Convert module to TypeScript.
2024-04-04 10:45:53 -07:00
8fb1117cef
eslint: Fix no-jquery/no-append-html errors that need test changes.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-04-04 10:11:57 -07:00
92bc2df4bb
lint: Quiet the Ruff formatter.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-04-03 15:34:02 -07:00
fbb42dd297
tools: Fix broken link in check-frontend-i18n.
...
The section referenced was moved to another page.
2024-04-03 13:13:16 -07:00
25ff0d4418
compose_recipient: Convert module to TypeScript.
2024-04-03 13:08:10 -07:00
15e2a67893
dev-vagrant-docker: Fix PostgreSQL version.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-04-02 17:02:20 -07:00
a283a19c9f
stream_color_events: Convert module to TypeScript.
2024-04-02 14:55:30 -07:00
89b3129d48
documentation_crawler: Consider status.zulip.com external.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-04-02 14:08:24 -07:00
6e871e7731
ruff: Fix UP036 Version block is outdated for minimum Python version.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-04-01 18:32:52 -07:00
fd970e0520
user_group_components: Convert module to TypeScript.
2024-04-01 17:32:48 -07:00
70914b0475
Remove support for Ubuntu 20.04 and Debian 11.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2024-04-01 13:27:39 -07:00
ce075fec6c
ci: Move specialized tests away from Ubuntu 20.04 and Debian 11.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2024-04-01 13:27:39 -07:00
e535c96e40
Upgrade development environment to Ubuntu 22.04.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2024-04-01 13:27:39 -07:00
bedbaa3a41
message_view_header: Convert module to typescript.
2024-04-01 13:22:39 -07:00
9c055df695
settings_user_topics: Convert module to typescript.
2024-03-30 16:25:34 -07:00
a43e9140f2
search: Convert module to typescript.
2024-03-30 15:27:02 -07:00
c7b12c996c
typeahead: Convert module to typescript.
...
This contains two more complex changes:
- The default versions of sorter and matcher assume that ItemType is a
string. But the Typeahead class works on a generic ItemType and I'm
not aware of a way to assert that this function is only called for
typeaheads with string items. For `matcher`, we can assert that the
items are strings. `sorter` is now a required option instead of an
optional one that could fall back to the default.
- `element` can be either an `input` element or a `contenteditable`
`div`. We distinguish between them using `.is("[contenteditable]"))`
but TypeScript doesn't understand that. So we replaced `this.$element`
with `this.input_element` where `input_element` is an object with the
`$element` and also a `type` specifying which type of element it is
(input or contenteditable).
2024-03-30 10:41:38 -07:00
5bcb4e55d8
desktop_notifications: Convert module to typescript.
2024-03-29 16:16:47 -07:00
87dee7a9b2
invite_user_modal: Replaced email text_area with input_pill.
...
This makes the widget considerably more attractive, and probably a bit
more usable.
Fixes #29391 .
2024-03-29 11:13:03 -07:00
416cba8746
install-shellcheck: Upgrade ShellCheck from 0.9.0 to 0.10.0.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-29 09:37:38 -07:00
da80afd6f4
lightbox: Convert module to TypeScript.
2024-03-28 13:56:56 -07:00
f1db30418b
submessage: Convert module to TypeScript.
2024-03-28 12:59:12 -07:00
19a7c75400
settings_components: Convert to typescript.
2024-03-26 10:32:15 -07:00
9080d583df
oneclickapps: Upgrade DigitalOcean 1-Click App to Ubuntu 22.04.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2024-03-25 13:19:09 -07:00
5768d27116
docs: Update VNU filter to ignore warnings about sphinx-design.
2024-03-22 16:54:57 -07:00
533a6153b2
compose_validate: Convert module to TypeScript.
2024-03-22 15:59:37 -07:00
fd3c7728fc
message_list_tooltips: Convert module to TypeScript.
2024-03-22 15:37:57 -07:00
0cc40605b0
semgrep: Broaden select_related() and prefetch_related() rules.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-22 18:01:57 -04:00
7d0c12aa3a
semgrep: Enforce no bare select_related() calls.
...
Previously, #26419 addressed the majority of these calls, but did not
prevent more from creeping in. Remove the one remaining
callsite (after the cleanup from the previous commits), and ban any
future use of the pattern.
2024-03-22 09:30:17 -07:00
1aaedf89ee
poll_modal: Convert module to TypeScript.
2024-03-21 16:33:24 -07:00
f758ca596b
custom_profile_fields: Add "required" parameter to the profile fields.
...
Fixes #28512 .
2024-03-21 10:48:54 -07:00
6f81fe1b5b
info_overlay: Convert module to TypeScript.
2024-03-21 09:00:33 -07:00
eb622bae0a
ruff: Fix S605 Starting a process with a shell.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-21 08:59:17 -07:00
a1a341f0ae
ruff: Fix UP032 Use f-string instead of `format` call.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-21 08:59:17 -07:00
db4e093ad7
release: Fix changelog output.
...
9bd340957f
2024-03-19 16:05:53 -07:00
fed085e319
tools: Fix test-documentation merge check errors.
...
Verified using the original test plan detailed in #18124 , checking that the output
is similar, and error handling is correct if the virtualenv is not available.
Fixes #18124 .
2024-03-19 15:01:33 -07:00
417d4b3a8a
integration_url_modal: Convert module to TypeScript.
2024-03-19 09:38:22 -07:00
ad3603c0aa
onboarding: Show one-time modal to introduce recent conversations view.
...
To improve onboarding experience, this commit adds a
one-time modal which introduces the recent conversations view.
Users see this one-time modal on visiting the recent
conversations view.
Fixes #29073 .
2024-03-19 09:32:59 -07:00
9a7634d527
onboarding: Show one-time modal to introduce inbox view.
...
To improve onboarding experience, this commit adds
a one-time modal which introduces the inbox view.
Users see this one-time modal on visiting the inbox view.
Fixes part of #29073 .
2024-03-19 09:32:59 -07:00
c13e3dee24
katex: Replace subprocess call with minimal external service.
...
Replace a separate call to subprocess, starting `node` from scratch,
with an optional standalone node Express service which performs the
rendering. In benchmarking, this reduces the overhead of a KaTeX call
from 120ms to 2.8ms. This is notable because enough calls to KaTeX in
a single message would previously time out the whole message
rendering.
The service is optional because he majority of deployments do not use
enough LaTeX to merit the additional memory usage (60Mb).
Fixes : #17425 .
2024-03-15 15:34:12 -07:00
5fd38f15a6
webpack: Support limiting to only one config name.
2024-03-15 15:34:12 -07:00
20e44997e2
types: Migrated add_stream_options_popover to TypeScript.
...
The migration requires some new assert statements as well as a change
in how the `return undefined` case is spelled to match the types declared by
Tippy upstream.
2024-03-15 13:02:20 -07:00
03ec788a91
typeahead: Move module to web/src.
2024-03-11 09:56:18 -07:00
babe525b5c
linter: Add _html as a variable name for safe html.
2024-03-11 09:56:18 -07:00
11e498f937
resize_handler: Convert module to Typescript.
2024-03-08 10:49:52 -08:00
42dd55df42
condense: Convert module to Typescript.
2024-03-07 16:15:30 -08:00
1fb03a27d8
compose_fade: Convert module to TypeScript.
2024-03-06 14:47:47 -08:00
5e18bd762f
left_sidebar_navigation_area: Convert module to TypeScript.
2024-03-06 13:57:33 -08:00
72681c2d5a
hotspots: Convert module to TypeScript.
2024-03-04 18:17:34 -08:00
6314139d4a
zcommand: Convert module to TypeScript.
2024-03-04 18:10:38 -08:00
e46c3bf116
dev-vagrant-docker: Upgrade docker-systemctl-replacement to 1.5.8066.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-04 15:34:10 -05:00
bda6470951
user_status_ui: Convert module to TypeScript.
2024-03-01 18:02:20 -08:00
066ea3ebf9
install: Support Ubuntu 24.04.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-01 17:38:08 -08:00
c60cc07605
drafts: Convert module to typescript.
2024-03-01 15:49:53 -08:00
3c708edb2c
team: Add more repositories and rename tabs.
...
Based on an audit of all repositories in the zulip organization.
2024-03-01 14:57:46 -08:00
d748ec8d52
ruff: Fix PLW0108 Lambda may be unnecessary.
...
This is a preview rule, not yet enabled by default.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-01 09:30:04 -08:00
553f268b04
ruff: Fix RUF027 Possible f-string without an `f` prefix.
...
This is a preview rule, not yet enabled by default.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-01 09:30:04 -08:00
865febb307
ruff: Fix RUF021 Parenthesize when chaining `and` and `or` together.
...
This is a preview rule, not yet enabled by default.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-03-01 09:30:04 -08:00
570f3dd447
python: Reformat with Ruff formatter.
...
https://docs.astral.sh/ruff/formatter/
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-29 17:07:16 -08:00
be59ef9c02
runtornado: Swap deferred reload events to the default.
...
This makes no immediate reloads the default for runtornado, matching
the production configuration, and changes the development incantation
to be the one to specify the departure from the norm, with
--immediate-reloads.
2024-02-26 22:29:19 -08:00
cba4b8141e
provision: Use binary PGroonga release on Debian 12.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-26 16:58:51 -08:00
28e4fe1820
onboarding_steps: Convert module to TypeScript.
2024-02-26 08:16:44 -08:00
44b07094df
stream_list: Convert module to typescript.
2024-02-23 16:18:48 -08:00
1f72ab5133
remote-support: Show active billing user emails.
2024-02-23 13:21:54 -08:00
a9dc669f3c
dropdown_widget: Migrate to typescript.
2024-02-22 16:38:25 -08:00
bf4933942c
run-dev: Abbreviate error message when receiving an https request.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-22 16:26:36 -08:00
ea2818786e
buddy_list: Convert module to typescript.
2024-02-22 16:05:27 -08:00
231aa098cb
buddy list: Create section in buddy list for users from narrow.
...
Fixes #21285 .
2024-02-22 16:05:27 -08:00
aeeea453dd
install-shfmt: Upgrade shfmt from 2.7.0 to 2.8.0.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-22 12:46:40 -08:00
860150525c
sidebar_ui: Convert module to typescript.
2024-02-21 18:50:51 -08:00
aab25fae6a
pm_list: Convert module to typescript.
2024-02-21 10:49:24 -08:00
c91ca3eca8
message_live_update: Convert module to TypeScript.
2024-02-20 08:30:04 -08:00
23795ca153
message_edit_history: Convert module to typescript.
2024-02-19 21:39:40 -08:00
a4938d3760
page_params: Parse page_params and state_data with Zod.
...
This establishes a runtime check that their types continue to reflect
reality going forward.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-17 00:02:38 -08:00
273453d285
lint: Remove .lock extension from frontend group.
...
Commit 3a27b12a7d#24731 ) migrated
yarn.lock to pnpm-lock.yaml.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-16 18:50:17 -05:00
76e86bc8fa
team: Update for zulip-android-legacy repository rename.
2024-02-15 16:52:23 -08:00
e96ede0ef6
page_params: Split out state data for current user.
...
For spectators, the chunk of page_params that originates from
do_events_register isn’t assigned until ui_init.js. That means the
TypeScript type of page_params is mostly a lie during module load
time: reading a parameter too early silently results in undefined
rather than the declared type, with unpredictable results later on.
We want to make such an early read into an immediate runtime error,
for both users and spectators consistently, and pave the way for
runtime validation of the page_params type. As a first step, split
out the subset of fields that pertain to the current user.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-15 10:22:52 -08:00
3fa308369d
playground_links_popover: Convert module to TypeScript.
2024-02-13 11:44:01 -08:00
5f9b6d82a4
typing_events: Convert module to TypeScript.
2024-02-12 09:49:54 -08:00
49d79730b8
resize: Convert module to typescript.
2024-02-09 21:17:16 -08:00
264a9a1057
compose_ui: Convert module to typescript.
2024-02-09 15:11:17 -08:00
3d63a87384
kandra: Puppet github.com keys to both root and zulip users.
...
We update to add the ecdsa-sha2-nistp256 key as well.
2024-02-07 10:42:12 -08:00
b1f899512a
pack-local-script: Match mode of file outside of packing.
2024-02-07 10:42:12 -08:00
e213d9505b
typing: Convert module to TypeScript.
2024-02-07 09:12:49 -08:00
94558478df
scheduled_messages_feed_ui: Convert module to TypeScript.
2024-02-06 22:25:55 -08:00
b23d90ed62
puppet: Rename puppet/zulip_ops to puppet/kandra.
...
This makes for easier tab-completion, and also is a bit more explicit
about the expected consumer.
2024-02-06 17:56:27 -08:00
0bd1e2b434
puppet: Rename and limit production key distribution.
2024-02-02 17:24:12 -08:00
70f491eae2
push-to-pull-request: Accept intermixed options and arguments again.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-01 17:08:44 -08:00
474703a963
push-to-pull-request: Use getopts for macOS compatibility.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-01 09:29:32 -08:00
ff00c01538
bootstrap-aws-installer: Pull all keys from secretsmanager.
2024-01-31 16:41:04 -08:00
6902d5db47
install-aws-cli: Also install and keep up to date using Puppet.
...
We previously only did this install on the developer machine and on
initial boot. Also run it from puppet to make sure we keep the binary
up-to-date.
2024-01-31 16:41:04 -08:00
bd87f53c86
install-aws-server: Build a tool to smuggle scripts inline in the bootdata.
2024-01-31 16:41:04 -08:00
333cc902fb
install-aws-server: chdir to the repo root first.
2024-01-31 16:41:04 -08:00
38bf1c5d22
install-aws-cli: Move into puppet files.
2024-01-31 16:41:04 -08:00
21237f42ba
install-aws-server: Enable instance metadata tags.
...
These are shown in the Teleport UI.
2024-01-31 16:41:04 -08:00
1acfe59fe5
install-aws-server: Pull latest 22.04 AMI by default.
2024-01-31 16:41:04 -08:00
12ec133224
templates: Move billing templates to /templates/corporate/billing.
2024-01-30 10:06:48 -08:00
Alex Vandiver
evykassirer
afeefuddin
Anders Kaseorg
Tanmay Kumar
Temidayo32
Anders Kaseorg
adnan-td
Varun Singh
Sahil Batra
Robert Dyer
Vector73
Andrew
afeefuddin
Prakhar Pratyush
Roshan Jagadish
Tim Abbott
Lauryn Menard
Aman Agrawal
Joydeep Bhattacharjee