9fa58a3c16
compose_ui: Automatically resize textarea after adding new syntax.
...
This fixes existing problems as well as an upcoming problem that
copy-and-pasting in markdown should usually expand the compose text
area.
2017-11-21 19:52:47 -08:00
d400b10282
docs: Reword GSoC section of contributing.md.
2017-11-21 19:32:27 -08:00
1c9a28d0d8
ldap: Use simpler ordering for handling successful auth.
...
common_get_active_user returns None if it finds any problems.
2017-11-21 19:08:45 -08:00
e0b56c72de
ldap: Simplify logic for user creation.
...
self._realm can't be None here with the new logic in authenticate().
2017-11-21 19:08:45 -08:00
e91051b1cd
ldap: Remove some unnecessary indentation.
...
We created this redundant pair of conditionals in a preceding commit,
in order to match the indentation of an `except` block so as to slice
the diffs extra finely as we're refactoring auth code.
2017-11-21 19:06:19 -08:00
c4c8879cf7
ldap: Fix the error message for deactivated users.
2017-11-21 18:35:05 -08:00
97f1c2a72a
ldap: Use new helper for checking realm status.
...
We intentionally don't fix the indentation that now feels ridiculous
below in order to make it easier to see what's actually changing in
this commit.
2017-11-21 18:35:04 -08:00
104a8de148
ldap: Shrink unnecessary scope of missing user block.
...
This is a pure refactor, and will help simplify the change in the next
commit.
2017-11-21 18:30:51 -08:00
e100935527
auth: Move LDAP check for whether backend is enabled earlier.
...
The previous logic felt fairly convoluted.
2017-11-21 18:30:51 -08:00
195a78ad11
auth: Convert EmailAuthBackend to use new helper.
...
This lets us delete some duplicate code, since common_get_active_user
handles an account in the wrong subdomain for us.
Also lets us delete the now-unused common_get_active_user_by_email.
2017-11-21 18:30:51 -08:00
8c21619be8
auth: Move checks for password_auth_enabled earlier.
...
This way, we don't attempt to evaluate whether the user's account is
active (etc.) until after we've checked the backend is enabled. This
won't change the result of actual auth, but feels more readable.
2017-11-21 18:30:29 -08:00
3bfb19b5f3
Convert EmailAuthBackend and LDAPAuthBackend to accept a realm.
2017-11-21 18:23:50 -08:00
53224a16a9
EmailAuthBackend: Convert a return to assert for a now-impossible case.
2017-11-21 18:23:50 -08:00
1b95b098dd
auth: Clarify comments explaining the GoogleMobileOauth2Backend.
2017-11-21 18:23:50 -08:00
23d791ca1b
auth: Convert GoogleMobileOauth2Backend to use new helper.
...
That logic was now just duplicate code.
2017-11-21 18:23:49 -08:00
caddef9279
auth: Invert conditionals in GoogleMobileOAuth2Backend.
...
This will help make the flow more readable.
2017-11-21 18:23:49 -08:00
fee2e36800
auth: Set valid_attestation for Google auth backend always.
...
This is a behavior change, though we don't check the value in the
caller regardless. It just seems more logical for us to correctly
report to the caller whether the Google auth itself was valid
unconditionally.
2017-11-21 18:23:49 -08:00
3c15f442fe
auth: Check for GoogleMobileOauth2Backend being enabled earlier.
2017-11-21 18:23:49 -08:00
a7d51127fb
auth: Convert GoogleMobileOAuth2Backend to accept a realm object.
2017-11-21 18:23:49 -08:00
37acfb4e90
auth: Convert DevAuthBackend to use new helper.
2017-11-21 18:23:49 -08:00
fa8eab303a
auth: Check for DevAuthBackend being enabled earlier.
2017-11-21 18:23:49 -08:00
07bc31f818
auth: Convert DevAuthBackend to accept a realm object.
2017-11-21 18:23:49 -08:00
4968631d1b
auth: Convert DevAuthBackend to use a unique argument pattern.
...
This helps ensure that we won't accidentally activate this backend on
other code paths.
2017-11-21 18:23:49 -08:00
f2d3258a56
auth: Rewrite RemoteUserBackend to use new helper.
2017-11-21 18:23:49 -08:00
73df431b88
auth: Check for RemoteUserBackend being enabled earlier.
...
This is possible now that we have a realm object before fetching the
UserProfile object.
2017-11-21 18:23:49 -08:00
d63e9f240c
auth: Remove unnecessary remote_user=None code path.
...
This code path was only required because we had remote_user set as a
positional argument here, and thus we'd be running this auth backend's
code when actually using another auth backend (due to how Django auth
backends are selected based on argument signature).
2017-11-21 18:23:49 -08:00
387c9109ec
auth: Convert RemoteUserBackend to accept a realm object.
2017-11-21 18:23:49 -08:00
fb6abe1b1e
auth: Rewrite DummyAuthBackend to not block email reuse.
...
This require some care to ensure we still provide the same nice error
messages for the case of a user who has an account, just not with this
organization.
Also, we fix the fact that the docstring was (and I think always has
been) at best confusing and perhaps even inaccurate.
2017-11-21 18:23:26 -08:00
f17974ab32
DummyAuthBackend: Require being passed a realm object.
...
We should now always know the realm in our auth code paths.
2017-11-21 18:22:37 -08:00
236c4b5d96
contributing: Improve discussion of internships.
2017-11-21 18:19:46 -08:00
4832d34821
docs: Add a bit of discussion of GSoC.
2017-11-21 17:54:15 -08:00
34689370cd
settings: Create UI and backend for setting signups stream.
2017-11-21 17:39:51 -08:00
3d2c9c6098
models: Replace core team with Realm.INITIAL_PRIVATE_STREAM_NAME.
2017-11-21 17:39:51 -08:00
a0275a6257
actions: Send new user messages to signup_notifications_stream.
2017-11-21 17:39:50 -08:00
42652713c8
onboarding: Refactor away setup_initial_private_stream.
...
It is a confusing name, now that the stream creation part has been taken
away.
2017-11-21 17:39:50 -08:00
3d17897563
onboarding: Move signup notifications stream creation to do_create_realm.
2017-11-21 17:39:50 -08:00
08aca174fe
models: Add signup_notifications_stream attribute to Realm.
2017-11-21 17:39:50 -08:00
089ff8a0ae
backends: Convert authenticate methods to modern type annotations.
2017-11-21 11:47:26 -08:00
708872f361
populate_db: Use call_consume_in_tests when generating test data.
...
We'd rather this work be just executed immediately, rather than
queued, since queued events can confuse the queue workers if the
database is dropped and recreated repeatedly.
2017-11-21 09:43:54 -08:00
84b9147fe3
gitignore: Add static/generated/icons.
2017-11-21 09:27:04 -08:00
5221ea5db5
settings: Make CSS selector more specific in table rows in org settings.
...
Fixes #7374 . Since we use `table-layout: fixed`, the width of the first
row are applied to all the remaining rows, thus wrapping all the columns
to 20% width. This is fixed by making the selector specific to only
user_rows and not the editable data row.
2017-11-21 09:12:55 -08:00
41a2032d71
docs: Add 'requirements.txt' to bot structure outline.
2017-11-21 09:08:48 -08:00
4a6c3eeb98
Use realistic filepaths in zuliprc docs and hints.
...
The first part of this change is to have the "Your bots"
tooltip not lie about creating `.zuliprc`, because it
doesn't put a dot in front of the file.
And then the more significant change here is to make
the "Running a bot" documentation use realistic filepaths,
both in terms of where the download typically puts the file,
and where you want to move it to.
2017-11-21 07:32:24 -08:00
aa50fae4ba
portico: Add anchor link support to API and user docs.
...
Fixes #7432 .
2017-11-20 17:23:19 -08:00
9d973129ab
user docs: Update compose box screenshots.
2017-11-20 17:14:01 -08:00
b97bb3a69d
frontend: Move checkbox to the left of label text
...
Generally, the checkbox should come 'before' the label text.
2017-11-20 17:14:01 -08:00
bff736868e
Generate custom-icon-webfont on each provision or update-prod-static.
...
Fixes #7354 .
2017-11-20 16:36:49 -08:00
327bb05733
docs: Make index page easy to find.
...
This commit adds an Index link to bottom of nav bar.
Fixes #7416 .
2017-11-20 16:33:04 -08:00
73e4d647c7
casper: Add a few more explicit waits to message editing tests.
...
This is a second attempt at fixing a casper test flake we've been
having recently.
2017-11-20 16:18:34 -08:00
c7f47f5477
casper: Use casper.then() more consistently in editing tests.
...
Hopefully, this will fix the test flake problems we've been having
with this test since upgrading Casper.
2017-11-20 16:04:26 -08:00
Tim Abbott
Rishi Gupta
Vishnu Ks
Rohitt Vashishtha
derAnfaenger
Steve Howell
Cynthia Lin
akashnimare
rht
David Rosa Tamsen