Commit Graph

5467 Commits

Author SHA1 Message Date
Steve Howell d329317502 Support helpOnEmptyStrings option in typeahead.
It allows us to provide suggestions when the user types '' in
a searchbox (e.g. by hitting delete when text is selected).

(imported from commit dc27ef86db2b6ec40039e4e9668b8ccc288c6134)
2013-07-22 16:05:35 -04:00
Steve Howell 72f65070f3 Go to Home view if user selects an empty search.
(imported from commit 056ba499e16cce686b4ac60dcd282b26f43ab802)
2013-07-22 16:05:35 -04:00
Zev Benjamin 2a1678a1d3 Fix some wording in our Zephyr mirroring instructions
(imported from commit e513b42afbc5f7e43f62d914feb2472fe0f6d0e5)
2013-07-22 14:26:25 -04:00
Leo Franchi 8b90d4bb8a Actually use our tz-aware datetime object when changing awareness
(imported from commit e0f85534fa12a712dd8c61b66abd687d36ba9088)
2013-07-22 10:52:37 -04:00
Jessica McKellar 5a56e7cd29 Make tabbing to Save and Cancel in the message edit form work in Safari/desktop apps.
(imported from commit 74b7e2eedb541c1ed409390c0d61b05c106bebcc)
2013-07-19 17:16:18 -04:00
Waseem Daher ec9c596933 Add unread green dots to the left of the message, which fade out.
This is a heavily adapted version of Allen's commit that did the
same.

Some gotchas:
* Because the unread count indicator is not in the message content,
  we can't center it in the middle of the message content (we'd
  need to put it inside the div to do so).

* Awesome Gecko bug surrounding tables makes this also somewhat
  annoying, so watch out for this if you're making changes here.

> In Gecko, if you have a positioned <table> element inside a
> positioned block element, such as a <div>, a position: absolute;
> styled element inside the table would be positioned relative to the
> outer <div> rather than the table, which is the nearest positioned
> ancestor. This is a bug, and has not been fixed.

(imported from commit 45c00c37f3721c211331b228e84d46283e1cc9ba)
2013-07-19 16:41:26 -04:00
Jessica McKellar 12a37ed2b8 Always keep the compose box open after sending.
(Some cases are disabled on outside of staging still due to mix
protection concerns).

(imported from commit 26fcb95c055640ddd87c5df424990ebd865a336a)
2013-07-19 15:48:12 -04:00
Steve Howell f177147f7a Show topic suggestions as "Narrow to stream > topic".
Terse suggestions are better for scanning, and we reinforce the
">" convention.

(imported from commit f586b74b29088e4cd76797aa5305d97fab34832f)
2013-07-19 14:17:08 -04:00
Steve Howell 84fda6ad04 (search) Don't show topic suggestions when a topic is already entered.
We already had provisions for the common case, but this code fixes
the situation where the user explicitly types topic:foo stream:yo.

(imported from commit 4dfa4cc8337acd4f0daed25a5b82a556804b3c18)
2013-07-19 13:49:33 -04:00
Jessica McKellar 8e23848384 Refocus in the content box after you change your Enter-sends state.
That way you can continue typing or press Enter to send.

(imported from commit 45501211f95657c9a4f6aba4d9cd0c4232d75c63)
2013-07-19 12:20:54 -04:00
Steve Howell df9daf70a2 Fix number of topic suggestions
(imported from commit 08096cc0e27054dd11f394d5b642b72ec8724b1b)
2013-07-19 12:12:05 -04:00
Steve Howell 7b48c46037 Suggest topics during search autocompletion.
(imported from commit c4335cb89689110ec67b47f1a7195efad7d6419a)
2013-07-19 11:49:06 -04:00
Steve Howell cd76add2de search.js: Clean up local variables a bit
(imported from commit 5094017271994a0aa50ec8cccc633360b46e90dc)
2013-07-19 11:49:05 -04:00
Steve Howell 616ed68440 Correctly encode stream suggestions.
Before this fix, if you used the "Narrow to stream foo bar" suggestion,
it would search for "bar" within stream foo.  Now it goes to the "foo bar"
stream.

(imported from commit 0be5f259842c119936d678a292a1a79af58defa2)
2013-07-19 11:49:05 -04:00
Steve Howell b3ef7760c6 Fix smartSpaceBar option in typeahead.
If you have smartSpaceBar turned on and hit space, the code
now calls lookup(), so that the app code can reload new
suggestions.

(imported from commit 6776babba0a2c9b8a954a4640aa7b81a970ed88e)
2013-07-19 11:49:05 -04:00
Steve Howell fa1151c8ed Export narrow.unparse()
(imported from commit dfee6523b5fd71a789b89c0c6c65a1d353e35046)
2013-07-19 11:49:05 -04:00
Kevin Mehall c7db0f8147 Fix test breakage introduced by 16af5e3
(imported from commit 6945b32a0ae1105c3ad91de5b9f98d39ae0228a5)
2013-07-19 10:49:34 -04:00
Tim Abbott 6a333395ca check-all: Run checks in parallel.
This save most of a second on the runtime for check-all on my laptop.

(imported from commit 16af5e3cbeb1511d9491c1cfb9778bdb19a9fb8c)
2013-07-18 17:54:46 -04:00
Waseem Daher 3ccb5e9d66 Make `Esc` properly dismiss message info popover.
(imported from commit ed95bc09803d2829710909d91096fa56bd8b048c)
2013-07-18 17:50:31 -04:00
Jessica McKellar 45fc7ced28 Show the total unread count in notifications, even if narrowed.
Previously we'd display the unread count for the current narrow.

(imported from commit 4939fc5cf0efcf9662b2b359f2247f915a334ac8)
2013-07-18 17:47:19 -04:00
Kevin Mehall 8b3cd91d39 Don't save the pointer on reload if we don't have one.
This fixes the bug where the pointer jumps to the top if it reloads
before finishing loading.

(imported from commit 6b2d80acab4d4232f6eb87695193592a83c4466a)
2013-07-18 17:36:04 -04:00
Jessica McKellar fbe55f733c Enable arrowing breaking out of an empty compose on prod.
(imported from commit 85a5826c3f454e268c3b31fc9487e58de1528d53)
2013-07-18 17:11:36 -04:00
Waseem Daher ea0e5c4754 Add :zulip: emoji.
(imported from commit 57e4232f8db6cf752244c4307d4c0cdbb570ec58)
2013-07-18 16:35:34 -04:00
Jessica McKellar b898db424e Don't fade all messages when you narrow to all PMs with the compose box open.
(imported from commit 4041d28988544733243aa3f2494aca9247acd324)
2013-07-18 16:26:01 -04:00
Tim Abbott 1d01a7db55 zephyr_mirror: Point to documentation on maintaining Kerberos/AFS credentials.
(imported from commit 2c49a1a554c2880f611e4969c8680f36641f1c2e)
2013-07-18 16:05:25 -04:00
Allen Rabinovich dc7b59bc9f Removing shadow artifacts from composition area
(imported from commit f957f26f60d2aedcb106e555b9558c8363cf9d61)
2013-07-18 12:30:37 -07:00
Tim Abbott 3f7c6f92c5 zephyr_mirror: Use Humbug full name as zsig.
(imported from commit 8cd24c4ff6c265084764ab367b46e4cb64e8c796)
2013-07-18 13:58:16 -04:00
Tim Abbott 18f94de07f Use standard functions for parsing/validating email addresses.
This adds two new functions for parsing out the domain and username
from an email address, and switches our backend to use them and
django.core.validators.valid_email() rather than custom parsing and
raw email.split("@").

(imported from commit 3d6e997d66908811eccb5f82f2f7fe349b40f238)
2013-07-18 13:58:16 -04:00
Tim Abbott bece588897 Include server deployment location and git commit in blueslip emails.
This should make it a bit easier to figure out exactly what was
running on the backend when an error happens.

(imported from commit d1002a92c24870b8d98d7133dff865eecf1cfffe)
2013-07-18 13:58:16 -04:00
Allen Rabinovich a486579a4f A group of changes to make the selection lighter and more elegant.
* Redo table borders as inset shadows to make them sharper
* Make the selection highlight a blue border with blue glow

(imported from commit 758884cc7e17952ba68e4aab6215f3e026dc8fe8)
2013-07-18 10:54:22 -07:00
Jeff Arnold e19238c905 Don't close the compose box on a click if the click selected text
Addresses Trac #1257

(imported from commit 10351752c4951b3a0f300391477d47f608332211)
2013-07-18 13:06:11 -04:00
Steve Howell 0e9e102324 Make the space key smarter for search typeaheads.
Hitting the space key accepts the current selection and allow you
to continue typing.

(imported from commit f902d051807b9296009896e40853bcefca434752)
2013-07-18 11:15:28 -04:00
Steve Howell fcb3999996 Support smartSpaceBar option in typeahead.
If you set the option, then hitting space will select the current
suggestion and allow you to keep typing.  If you don't set it,
then it's the old behavior where space allows you to continue
typing without acknowledging your selection.

(imported from commit 8125a322e5a748ac7716361d66fca18c56d5766e)
2013-07-18 11:15:28 -04:00
Tim Abbott cd71840942 Use a better output filename for Django logs.
(imported from commit 97d37d9167ac8463ea54fb7a75a3f923fc78edee)
2013-07-17 17:50:19 -04:00
Tim Abbott 23beabb80c [manual] Rename manage.py subscribe_new_users to process_signups.
The old name was very confusing, and this fits the convention of "the
processor for the signups" queue a la "process_user_activity".

This requires doing a

supervisorctl stop humbug-workers:humbug-events-subscribe-new-users
puppet apply

to deploy the supervisord configuration changes and properly restart
the signups queue.

(imported from commit 0ee2dad837142afa64025446e22956709771a192)
2013-07-17 17:50:19 -04:00
Tim Abbott 27586559dc Remove Puppet configuration for zulip-staging.
The file was already deleted.

(imported from commit 04c68076ad59709c2848f81ca81db9612f9c65b8)
2013-07-17 17:50:19 -04:00
Tim Abbott f61b4ddb25 Remove second duplicate python-boto instance.
(imported from commit 11ef02de82d0f8cdd4c1cf3813e5d09619d4665b)
2013-07-17 17:50:19 -04:00
Steve Howell c12521be35 Use ? as icon for Keyboard shortcuts, to match ? as the hotkey.
(Before it was info (i), which is the hotkey for another menu, so it
was confusing.)

(imported from commit 44eb25fc5c90e3510456d6cb9dbca7fe13e56b37)
2013-07-17 16:46:27 -04:00
Scott Feeney a33e6a5ec0 Fix @-mention autocompletes when no @ typed
Introduced by my fix to #1418 a few commits back, sorry about that!

(imported from commit 9df9cdaf4226012076ccdfe0c062606ca8026b38)
2013-07-17 15:46:41 -04:00
Steve Howell 3af905db66 search.js: extract get_suggestion_based_on_query
(imported from commit 6c242fa9dd9ad9f73976fe9b1265521610326c5d)
2013-07-17 15:39:35 -04:00
Steve Howell c9ec96cab3 search.js: Eliminate get_query and get_person
(imported from commit c785f33378a0a5a436d9a7cb236a4af29c94921a)
2013-07-17 15:39:35 -04:00
Steve Howell 98d2c5361f search.js: Simplify get_person_suggestions
(imported from commit 44f22923a73633c5693a99ae9ce788f10cd5f505)
2013-07-17 15:39:35 -04:00
Steve Howell c515ad4cbb search.js: Simplify get_stream_suggestions
(imported from commit 0fd00a2f22cc0241945767b4bf1151b811f00a63)
2013-07-17 15:39:35 -04:00
Steve Howell 6a8a403cc9 Make prefix_sort just use obj itself if get_item is not passed in
(This facilitates using prefix_sort for a list that doesn't require
a function call to get to the object of interest.)

(imported from commit 5a0e550c313b9c57f0434c7246fcea451219d1b8)
2013-07-17 15:39:35 -04:00
Steve Howell ed622c457b search.js: eliminate action concept
(imported from commit 224997bd656a1c1b39260cf7fdec97988f9854b6)
2013-07-17 15:39:35 -04:00
Steve Howell 87e025602c search.js: kill get_search_string
(imported from commit 5979832ba697386a660ca9cdc6487fa79257511b)
2013-07-17 15:39:35 -04:00
Steve Howell c201354e6b search.js: slice earlier when building typeahead objects
Slicing earlier means less work to do on items that were gonna
be sliced anyhow.

(imported from commit 743c51c478679a14f101e6cf7c14eafb9d719a58)
2013-07-17 15:39:34 -04:00
Steve Howell e6e56ef97e search.js: sort earlier when building typeahead objects
This sets up a later optimization.

(imported from commit 49d285ce4e30fff222c8160d12fd345b9afeb417)
2013-07-17 15:39:34 -04:00
Allen Rabinovich f1da624353 New selection highlight style
(imported from commit b23e8ddc08af131f74964ba7562eb071eaeb0a64)
2013-07-17 12:29:22 -07:00
Kevin Mehall 8863340e98 Fix scroll glitch when new messages are loaded at top.
`process_condensing` before updating the scroll position, because it can
change the height of messages.

(imported from commit ca500351447fcabc3b03bb01a55a8e25bf8e9578)
2013-07-17 15:25:22 -04:00