Cynthia Lin
27e1393610
docs: Update keyboard shortcuts documentation.
2017-06-21 15:54:09 -04:00
Cynthia Lin
e832ebdc98
hotkeys: Add collapse/show message hotkey.
...
Fixes #4540
2017-06-21 15:54:09 -04:00
James Rowan
19ffb84ac2
Make notification email for new login give browser and os.
...
notify_new_login.subject: include browser and os in subject line.
test_new_users: test for subject line to include browser/os.
2017-06-21 14:36:41 -04:00
Cynthia Lin
96dc204841
hotkeys: Document `u` hotkey.
2017-06-21 10:38:05 -04:00
Cynthia Lin
a9afe43735
hotkeys: Add `u` hotkey for opening message sender profile.
...
Fixes #4873
2017-06-21 10:38:05 -04:00
Abhijeet Kaur
a45c224fda
bots: Update EmbeddedBotWorker class in queue_processors.py.
...
Update EmbeddedBotWorker.get_bot_api_client in
'zerver/workers/queue_processors.py' to return an EmbeddedBotHandler
object instead of ExternalBotHandler object.
This change is as a followup for splitting the BotHandler class into
two separate classes for external and embedded bots.
2017-06-21 10:22:53 -04:00
Abhijeet Kaur
55c0dee1c3
bots: Add a separate class "EmbeddedHandlerBots" in bot_lib.py.
...
Add another class for bot type as embedded bot, for bots that run directly
on Zulip server. This class uses internal 'internal_send_messages' from
actions.py instead of using the 'send_message' function from Zulip Client
class.
We haven't gone ahead with creating an abstract superclass right away.
We just have two versions for now, it would be easier to iterate a little
more on the interfaces, and then only add the superclass when we're ready
to lock down the interface.
2017-06-21 10:22:53 -04:00
Abhijeet Kaur
bc6b66cdfc
bots: Remove unnecessary comment from test_giphy file.
...
This comment was added to explain the functionality of the
method called below it. Some changes in the method have led this
comment to be unnecessary.
2017-06-21 10:22:53 -04:00
Abhijeet Kaur
68777e93a0
bots: Rename BotHandlerApi class to ExternalBotHandler.
...
This change is done for better understanding of the class functionality
from its class name. Now there will be 3 different classes for bots,
namely 'ExternalBotHandler', 'FlaskBotHandler' and 'EmbeddedBotHandler'.
2017-06-21 10:22:53 -04:00
Robert Hönig
d45d9c9ab5
bots: Add linter rule to prevent open() calls.
...
Addresses #5395 .
2017-06-21 10:16:59 -04:00
Robert Hönig
fd41a481e4
linter: Fix `include_only` rule path comparison.
...
In order for the `include_only` linter rule to not have
any side effects, we need to explicitly add a trailing '/'
after every directory we want to include.
2017-06-21 10:16:59 -04:00
Umair Khan
a4afca7b73
ldap: Don't authenticate if realm is None.
...
Fixes #5431
2017-06-21 10:14:34 -04:00
Umair Khan
005037830c
test_auth_backends: Fix indentation.
2017-06-21 10:14:34 -04:00
Sampriti Panda
5dc053d6fb
bots: Add validation to add_bot_backend to prevent empty short names
...
Fixes #5487
2017-06-21 10:11:08 -04:00
Steve Howell
e49afe3ebc
lint: Add code to suggest removing exclusions.
...
If excluded lines no longer exist in a file, print a message
asking the user to remove the exclusion.
2017-06-21 08:12:58 -04:00
Cory Lynch
95d86c8aeb
zulip.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
bfd92235c5
typing_notifications.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
a5328be9a1
subscriptions.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
74fd7e0865
stats.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
25d0810f76
settings.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
c7697f8286
right-sidebar.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
c33dc4a5a5
reactions.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
6e9bf1b563
portico.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
67da0ef9dd
portico-signin.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
d04fbc0a53
popovers.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
fa73872828
media.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
1b2d44b016
lightbox.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
7bfb902032
left-sidebar.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
5f6ebaba45
landing-page.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
94ccbb71b0
informational-overlays.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
1b4ca9dff8
drafts.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
7e869cf5b2
compose.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
d1d1906460
components.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Cory Lynch
7dd0ae33ad
activity.css: Replace RGB colors with HSL colors.
2017-06-21 07:02:57 -04:00
Joshua Pan
bd9459f27d
node test: Enforce 100% node coverage in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
Joshua Pan
1e4c133430
node tests: Test sort_recipientbox_typeahead() in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
Joshua Pan
b48f8447e2
node tests: Fully cover compare_by_pms() in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
Joshua Pan
1c34a3ae54
node tests: Fully cover sort_streams() in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
Joshua Pan
ffde90fcd1
node tests: Add tests for sort_emojis() in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
Joshua Pan
0563337240
node tests: Fully cover split_by_subscribers() in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
Joshua Pan
a53a4b7f0d
node tests: Add tests for render stream typeahead item.
2017-06-21 00:03:05 -04:00
Joshua Pan
7a93a425f8
node tests: Add tests for render person typeahead item.
2017-06-21 00:03:05 -04:00
Joshua Pan
ee48ac1854
node tests: Fully cover compare_by_popularity() in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
Joshua Pan
649558476e
node tests: Get rid of typeahead_helper dependency.
...
This also puts the global tests into their
own specific tests, which then allows us to
get rid of the typeahead_helper dependency.
2017-06-21 00:03:05 -04:00
Abhijeet Kaur
14fdc2aea6
bots: Add 'Bot type' column to bots list in organization settings.
2017-06-20 23:04:46 -04:00
Steve Howell
572ea370ea
Speed up custom checkers in `./tools/lint`.
...
The main thing here is to make looping over lines be the inner
loop, instead of looping over rules. This keeps regexes in
cache, and it also avoids some O(N) checks.
This is a significant speedup for me, reducing time from 16s
to 11s.
2017-06-20 22:26:12 -04:00
Rishi Gupta
ca3b9f3059
user docs: Clean up intro text.
2017-06-20 21:25:56 -04:00
Cory Lynch
c19be5e39e
Change conversation links to contain user's own email.
...
Fixes #2360 .
2017-06-20 21:22:45 -04:00
Cory Lynch
6d90d7ccbb
people.js: Ignore own email address in group PMs.
2017-06-20 21:22:45 -04:00
Cory Lynch
00ebb4f4d4
messages.py: Ignore own email in group PMs.
2017-06-20 21:22:45 -04:00