b6491fd52a
logging: Eliminate log_level from create_logger.
...
Because calls to `create_logger` generally run after settings are
configured, these would override what we have in `settings.LOGGING` --
which in particular defeated any attempt to set log levels in
`test_settings.py`. Move all of these settings to the same place in
`settings.py`, so they can be overridden in a uniform way.
2017-12-12 17:17:08 -08:00
0e0a8a2b14
queue processor tests: Call consume by default.
...
This significantly improves the API for queue_json_publish to not be
overly focused on what the behavior of this function should be in our
unit tests.
2017-11-26 11:45:34 -08:00
2e7d0cb4cb
digests: Fix new stream links.
...
Fixes : #7479 .
2017-11-22 10:07:36 -08:00
3f4bf2d22f
zerver/lib: Use python 3 syntax for typing.
...
Extracted from a larger commit by tabbott because these changes will
not create significant merge conflicts.
2017-11-21 20:56:40 -08:00
1792dcbd09
tests: Call real consume method of queue processors.
...
This switches to more real tests for a first batch of
queue_json_publish() calls that don't cause trouble when
used with call_consume_tests=True.
2017-10-26 14:58:03 -07:00
035ed93111
zerver/lib: remove `import six`.
2017-09-27 19:10:28 -07:00
f43e54d352
zerver/lib: Remove absolute_import.
2017-09-27 10:00:39 -07:00
d9c9bfe7f6
logger: Add new create_logger abstraction to simplify logging.
...
This deduplicates a ton of Python logger-creation code to use a single
standard implementation, so we can avoid copy-paste problems.
2017-08-27 18:31:53 -07:00
e8a608f733
management: Move enqueue_digest_email handler to digest.
2017-08-27 10:13:11 -07:00
9a4b17cf9b
management: Move queue_digest_recipient to digest.
2017-08-27 10:13:11 -07:00
2aabf4fc67
management: Move should_process_digest to digest.
2017-08-27 10:13:11 -07:00
25a40806df
management: Move inactive_since to digest.
2017-08-27 10:13:11 -07:00
f5713297c4
digest: Stop generating digest emails for soft-deactivated users.
2017-08-15 22:04:52 -07:00
ba411b0539
digest: Use get_user_profile_by_id.
2017-08-15 12:53:48 -07:00
aa845e7f60
models: Replace ScheduledJob with ScheduledEmail.
...
ScheduledJob was written for much more generality than it ended up being
used for. Currently it is used by send_future_email, and nothing
else. Tailoring the model to emails in particular will make it easier to do
things like selectively clear emails when people unsubscribe from particular
email types, or seamlessly handle using the same email on multiple realms.
2017-07-17 16:05:38 -07:00
f1aaf4cc33
emails: Remove the display_email function.
...
No longer needed, since this now only appears in build_email.
2017-07-16 16:56:39 -07:00
b0d325b8c5
emails: Change send_future_email to accept a to_user_id.
...
Also changes digest emails to use a to_user_id instead of a to_email.
2017-07-16 16:56:39 -07:00
9bd1b0ba58
emails: Update subject for digest emails.
2017-07-13 18:47:02 -07:00
a3b1631832
emails: Make the digest email come from 'Zulip Digest.'
2017-07-13 14:50:36 -07:00
3687dcdb3f
pep8: Add compliance with rule E261 digest.py.
2017-05-07 23:21:50 -07:00
face3077df
email: Rename template_payload to context.
2017-05-05 14:38:25 -07:00
6a8ed81439
send_email: Remove tags argument from send_future_email.
...
The tags argument was only being used by the Mandrill pathway, which is no
longer around.
2017-05-05 14:38:25 -07:00
68c172192b
email.py: Change recipients argument of send_future_email to to_email.
2017-05-05 14:38:25 -07:00
0d4c1b0467
notifications: Move send_future_email to zerver/lib/send_email.py.
2017-05-05 14:38:25 -07:00
d70e09b41d
notifications: Change sender arg of send_future_email to from_email.
...
This commit is a step towards the goal of replacing most of the
send_future_email pathway with a call to send_email.
Note that this commit changes the default value of sender from "Zulip
<NOREPLY_EMAIL_ADDRESS>" to "NOREPLY_EMAIL_ADDRESS". NOREPLY_EMAIL_ADDRESS
will soon be changed to have the Zulip in front.
2017-05-05 14:38:25 -07:00
e46cbaffa2
email: Remove Mandrill pathways and dependency.
...
Everything it was doing (send_future_email) can now be done using
ScheduledJob.
2017-05-05 14:38:23 -07:00
a413b0dbad
notifications: Change send_future_email to take a template_prefix.
...
Also reorders the arguments a bit to better match
zerver.lib.send_email.send_email.
2017-05-05 14:20:32 -07:00
cf38fd156b
digest.py: Merge send_digest_email into its callers.
...
Most of the functionality of send_digest_email is being standardized in
zerver.lib.notifications.send_future_email.
2017-05-05 14:20:32 -07:00
ebfae36494
email: Move and rename digest_email templates.
2017-05-03 23:26:14 -07:00
6ba11785ea
js dependencies: Change hashchange_encode to hash_util_encode in zerver.
...
This function formerly replicated the behavior of hashchange.encode, and now
replicates the behavior of hash_util.encode.
2017-03-18 20:40:34 -07:00
a3a03bd6a5
mypy: Added Dict, List and Set imports.
...
Fixed mypy errors associated with the upgrade.
2017-03-04 14:33:44 -08:00
c388858e53
Fix timezone errors in ScheduledJob and digest creation filters.
...
datetime.utcnow() is a timezone-naive datetime. The Django ORM interprets it
in the settings.TIME_ZONE timezone (e.g. 'America/New_York' in the
development server). We perhaps haven't noticed errors yet since with
'America/New_York' all it means is that emails are sent 5 hours early, or a
slightly different set of messages are included in the digest.
2017-03-01 22:54:28 -08:00
4e171ce787
lint: Clean up E126 PEP-8 rule.
2017-01-23 22:06:13 -08:00
d6e38e2a5c
lint: Clean up E123 PEP-8 rule.
2017-01-23 21:34:26 -08:00
e9158dd520
lint: Clean up E121 PEP-8 rule.
2017-01-23 21:02:39 -08:00
00d48bff7d
Digest: Fix URIs for emoji and friends in email links.
...
It turns out we were using malformed URLs in the image tags
(containing just a hostname, but no http(s)!) in what we were passing
to the Django templates for our digest/, which resulted in the Django
templates treating these URLs as http. Gmail recently cracked down on
loading images in HTTP, causing the emoji links to appear broken in
emails Zulip sends.
Fixes #3258 .
2017-01-21 22:25:51 -08:00
8a07545afb
Rename digest_email_txt.html to digest_email.html.
...
The .html file ending is clearer and more in line with our other
email files.
2017-01-06 10:42:28 -08:00
8d038eef2f
digest emails: Move the subject line to a templates/ file.
...
To match how we do the subject line for the emails in followup/ and
invitation/.
2017-01-06 10:42:28 -08:00
0917493588
mypy: Convert zerver/lib to use typing.Text.
2016-12-25 10:33:45 -08:00
94b28e0afb
pep8: Fix E128 violations.
...
With some line-wrapping tweaks by tabbott.
2016-12-13 10:50:14 -08:00
adebc75740
pep8: Fix E502 violations
2016-12-03 10:56:36 -08:00
007b693cc7
pep8: Fix E131.
2016-12-01 23:16:47 -08:00
c8ddea16c3
pep8: Fix E122.
2016-12-01 23:16:35 -08:00
c5316b4002
lint: Fix E127 pep8 violations.
...
Fix pep8: E127 continuation line over-indented for visual indent
style issue.
2016-12-01 10:23:55 -08:00
7a2282986a
pep8: Fix E225 pep8 violations.
2016-11-28 15:21:15 -08:00
ff1e97603d
context_processors: use a common context for emails.
...
Fixes #1611 .
2016-11-08 11:37:16 -08:00
ccce3ec0be
zerver/lib/digest.py: Fix a type annotation.
2016-10-11 11:27:35 -07:00
4fbb8c3eee
templates: Add new context variables to all templates.
...
This adds a few new helpful context variables that we can use to
compute URLs in all of our templates:
* external_uri_scheme: http(s)://
* server_uri: The base URL for the server's canonical name
* realm_uri: The base URL for the user's realm
This is preparatory work for making realm_uri != server_uri when we
add support for subdomains.
2016-08-13 16:27:35 -07:00
375551aaa6
Clean up most hardcoding of mit.edu domain checks.
...
This moves all this code to be gated on a few virtual realm settings.
2016-07-26 20:30:12 -07:00
68823767e2
zerver/lib/digest.py: Fix annotations.
2016-06-18 16:41:40 -07:00
Greg Price
Robert Hönig
Harshit Bansal
rht
Aditya Bansal
Preston Hansen
Tim Abbott
Rishi Gupta
James Rowan
Raghav Jajodia
reallyly
bulat22101
Alex Huang
Rafid Aslam
paxapy
Eklavya Sharma
Tim Abbott