K.Kanakhin
e122dcab5c
dev-proxy-logging: Add client ip transference to proxy server.
...
- Add rewriting 'X-REAL-IP' header for each request through dev
proxy server.
- Change webpack configuration ip to 0.0.0.0 to fix socket.io build
for launching remote dev server.
2016-12-21 17:18:02 +06:00
K.Kanakhin
4750d30341
dev-proxy-logging: Disable dev proxy logging by default.
...
- Add parameter to proxy launchig script, which enables logging
for dev proxy server (disabled by default).
2016-12-21 17:18:02 +06:00
K.Kanakhin
75c4e3191d
tests: Add help documentation checking script to CI
2016-12-19 08:31:39 -08:00
K.Kanakhin
589ae27190
documentation-crawler: Exclude privacy page from documentation checking
2016-12-19 08:31:39 -08:00
Sampriti Panda
c0326d1938
Add lint rule to disallow python calls with versions (e.g: python2, python3)
...
Fixes #2435
2016-12-19 08:00:48 -08:00
Arpith Siromoney
f144009c6d
Change color of white emojis ( 1️⃣ , 2️⃣ , etc) to blue.
...
The following emojis are colored white (with a transparent background)
and are hard to read in the context of Zulip. This commit changes their
colors to blue. The emojis are:
hash, zero, one, two, three, four, five, six, seven, eight and nine.
This fixes #1969 .
2016-12-16 09:46:37 -08:00
K.Kanakhin
fa68a678cc
help-documentation-tool: Add tools for checking user help documentation.
...
- Add spider for documentation crawler, which processes user help
documentation on test development server.
- Add tool script for help documentation checking launching.
Fixes #2639
2016-12-16 09:04:04 -08:00
K.Kanakhin
2cbc7bb2c1
documentation-crawler: Create common spider for documentation checking.
...
Fixes #2639
2016-12-16 09:04:04 -08:00
Tomasz Kolek
34511065dc
Fix tests problem with backward incompatible function name.
...
Add __init__ methods to some of testing clases with overriding method name.
2016-12-16 07:04:55 -08:00
Umair Khan
6c1d805495
travis: Fix production suite flakiness.
...
Previously, we were doing this request to the production server before
waiting for all the supervisord processes to start; it's possible this
could cause failures where we hit the server before the Django uwsgi
processes are up.
Hopefully fixes #2723 .
2016-12-15 22:04:57 -08:00
Tim Abbott
81dbf8c80a
lint: Enforce no external resources in CSS.
2016-12-15 22:02:10 -08:00
Tim Abbott
bf80873d4f
tests: s/assertRaisesRegexp/assertRaisesRegex/ due to deprecation.
2016-12-15 17:11:42 -08:00
Umair Khan
d85e85c9eb
linter: Add rule to check title attribute for i18n.
...
Fixes #2698
2016-12-15 13:44:13 -08:00
Umair Khan
efccefc386
Upgrade to the latest Django release, 1.10.4.
...
Most of the changes to support this were merged some time ago; what
remains are these changes:
* Update requirements.txt
* Django 1.10: Upgrade success-http-headers.txt file.
- We no longer get the absolute urls, see
https://docs.djangoproject.com/en/1.10/releases/1.9/#http-redirects-no-longer-forced-to-absolute-uris
- The headers are capitalized, previously, they were in upper case.
* Bump PROVISON_VERSION to 3.0 since this is a disruptive change.
Fixes #3 .
2016-12-14 22:43:20 -08:00
reallyly
94b28e0afb
pep8: Fix E128 violations.
...
With some line-wrapping tweaks by tabbott.
2016-12-13 10:50:14 -08:00
Tim Abbott
441c92e42f
travis: Remove postgres-9.6 from production suite as well.
2016-12-12 10:12:08 -08:00
Steve Howell
a119719b79
Make provision messaging more explicit.
...
Say "do this" when we want users to run `./tools/provision.py`.
2016-12-10 08:57:41 -08:00
Adarsh S
31be2534b3
Fix Error: templates have no tests! while running TemplateTestCase.
...
We need to test all the templates only when we are running the full
test suite. While running just the Test Class we need not check all
the templates.
2016-12-09 12:09:55 -08:00
Brock Whittaker
1886f0a015
redesign: Convert subscriptions page to overlay.
...
This is a major change to the /#subscriptions page, converting it to
by a side-by-side list of streams and their settings in an overlay.
There are no new features added/removed, but it's a huge changeset,
because it replaces the old navigation logic and moves the stream
creation modal to appear in the right side of this overlay.
2016-12-09 11:08:08 -08:00
Zac Pullar-Strecker
4eb6adf547
mypy: Annotate zerver/tests/test_narrow.py
2016-12-09 05:48:22 -08:00
Tim Abbott
d2d404afcc
travis: Remove npm cache in prod installation.
...
With this change in place, we would have been able to catch the bug
fixed in the last commit in CI.
2016-12-08 10:34:09 -08:00
Tim Abbott
8b77889f8a
test-all: Run the pep8 linter by default.
2016-12-07 23:22:59 -08:00
anirudhjain75
beaa62cafa
mypy: Convert several directories to use typing.Text.
...
Specifically, these directories are converted: [analytics/, scripts/,
tools/, zerver/management/, zilencer/, zproject/]
2016-12-07 20:51:05 -08:00
Tim Abbott
90f76c079d
lint: Require space after headings in markdown.
2016-12-07 17:15:53 -08:00
Tim Abbott
279d160f99
lint-all: Fix markdown_whitespace_rules indentation.
2016-12-07 17:15:47 -08:00
anirudhjain75
4bb6735e77
Annotate zephyr_mirror_backend.py.
...
With some tweaks by tabbott to update tuple->Tuple and update comments.
2016-12-07 15:57:55 -08:00
Rafid Aslam
ce94fb2eb1
deps: Change zxcvbn download method from download-zxcvbn to npm.
...
- Replace download-zxcvbn with downloading it from npm.
- Change zxcvbn.js path to node_modules (because npm put it to
`node_modules` directory.
- Bump `PROVISION_VERSION` in `version.py` to 2.4.
Fixes #2423 .
2016-12-06 17:54:56 -08:00
Rafid Aslam
0951b838ca
deps: Update zxcvbn to 4.4.1
...
Update zxcvbn to 4.4.1, and change `crack_time` to
`crack_times_seconds` because `crack_time` has been changed to
`crack_times_seconds` in 4.4.1.
2016-12-06 17:51:33 -08:00
Tudor Nazarie
5b22959f1c
Annotate bots/jabber_mirror_backend.py
2016-12-06 09:52:08 -08:00
Tim Abbott
15bfedec99
travis: Improve debuggability of server wget failures.
...
The main improvement here is causing `wget` errors to be ignored so
that we see the server logs in the event of a `wget` failure.
2016-12-03 20:48:57 -08:00
Tim Abbott
d5dd7a27d5
Remove tools/deprecated/inject-messages.
2016-12-03 16:58:17 -08:00
Tim Abbott
1a161c6e33
eslint: Fix comma-dangle rules in JS support files.
...
This was done via eslint --fix.
2016-12-03 15:00:24 -08:00
Joy Chen
77938f6247
mypy: Annotate *bots/githook-post-receive*
2016-12-03 15:58:22 -06:00
Jason Le
144d82305d
mypy: Annotate puppet/zulip_ops.
2016-12-03 11:00:25 -08:00
bulat22101
a6f91064a2
pep8: Fix E129 violations
2016-12-03 10:56:36 -08:00
bulat22101
adebc75740
pep8: Fix E502 violations
2016-12-03 10:56:36 -08:00
Tim Abbott
8259adaba5
lint: Add custom lint check for console.log statements.
...
This was previously checked for by jslint, and eslint doesn't seem to
have a nice exclude rule for it.
2016-12-02 20:05:18 -08:00
kevv87
1fb9220354
lint: Remove old jslint linter.
...
Now that we're using eslint, jslint is no longer required.
2016-12-02 18:49:42 -08:00
Sidhant Bhavnani
8c0c12c1d9
pep8: Fix E303 violations.
2016-12-02 15:34:11 -08:00
Alex Huang
007b693cc7
pep8: Fix E131.
2016-12-01 23:16:47 -08:00
Alex Huang
c8ddea16c3
pep8: Fix E122.
2016-12-01 23:16:35 -08:00
AZtheAsian
62494eeb97
pep8: fix E201 violations
2016-12-01 23:06:02 -08:00
AZtheAsian
7e14fe65ab
pep8: fix E202 violations
2016-12-01 23:06:02 -08:00
AZtheAsian
1ba150fa85
pep8: Fix E203 violations
2016-12-01 20:37:57 -08:00
AZtheAsian
c23f9e0df7
pep8: Fix E111 violations
2016-12-01 14:18:11 -08:00
AZtheAsian
f7582f0050
pep8: Fix E124 violations
2016-12-01 14:18:11 -08:00
Tim Abbott
1a8a329b44
production-helper: Expand the apt-mark hold list.
2016-12-01 12:29:31 -08:00
Tim Abbott
87879c3916
travis: Workaround broken Travis CI java configuration.
...
Travis CI seems to have broken /usr/bin/java in a recent
infrastructure change.
2016-12-01 11:46:21 -08:00
Tim Abbott
0ac78ca454
setup-production: Fix path to update-prod-static.log.
...
This regressed in 55f2c49bbf
.
2016-12-01 11:15:20 -08:00
Rafid Aslam
c5316b4002
lint: Fix E127 pep8 violations.
...
Fix pep8: E127 continuation line over-indented for visual indent
style issue.
2016-12-01 10:23:55 -08:00
Tim Abbott
fd81cc1d93
test-backend: Clarify missing template tests error message.
2016-12-01 10:12:38 -08:00
Vamshi Balanaga
5f60258a85
pep8: Fix E211 violations.
2016-11-30 20:13:10 -08:00
Bickio
6b0df43463
pep8: Fix E125.
2016-11-30 20:03:29 -08:00
Bickio
e009383460
pep8: Fix E231.
2016-11-30 19:59:25 -08:00
Tim Abbott
995a692f7f
provision: Check whether the system has at least 2GB of RAM.
...
Fixes #2336 .
2016-11-30 16:07:57 -08:00
Tim Abbott
e73ee5a4c4
test-backend: Fix count for templates without tests.
2016-11-30 15:38:19 -08:00
Tommy Ip
e4091c6413
pep8: Fix E222 violations.
2016-11-30 21:49:02 +00:00
Tommy Ip
46b7d54b3e
pep8: Fix E701 violations.
2016-11-30 20:45:09 +00:00
Heidi Dong
ba7d4e7452
mypy: Annotate bots/gcal-bot.
2016-11-29 20:49:11 -08:00
Anders Kaseorg
6549dfd1d0
build-release-tarball: Add --py3 option for python3 shebang lines.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-29 17:45:18 -08:00
Tim Abbott
4f6a075331
test-backend: Fix missing output for untested templates.
...
Our enforcement logic for untested templates unfortunately did not
give a clear error message unless you passed the --verbose option.
2016-11-29 16:38:18 -08:00
Tommy Ip
844e32ccc5
tools: Remove deprecated generate-activity-metrics.py.
...
The script uses hardcoded hostnames that do not exist anymore,
its functionality is available through directly querying the Zulip
database.
2016-11-29 09:27:59 -08:00
Rafid Aslam
41bd88d5ed
pep8: Fix E301 pep8 violations.
...
Fix "E301: expected (1 or 2) blank line" pep8 violations.
2016-11-29 08:51:44 -08:00
Rafid Aslam
7a2282986a
pep8: Fix E225 pep8 violations.
2016-11-28 15:21:15 -08:00
sylvan1
443cf92640
mypy: Change Generator[None, None, None] to Iterator[None].
...
Fixes #1648 .
2016-11-27 10:42:16 -08:00
Tim Abbott
1fcf2ff525
tornado: Move zerver.tornadoviews to zerver.tornado.views.
...
This furthers the overall goal of moving all the Tornado-specific code
to zerver/tornado/.
2016-11-26 22:29:28 -08:00
Tim Abbott
8739f4d9f1
tornado: Move tornado_ioloop_logging to new zerver/tornado tree.
2016-11-26 21:24:05 -08:00
Tim Abbott
92d1b6d6da
run-dev: Fix regression ignoring --interface argument.
...
When we migrated run-dev.py from Twisted to Tornado a few weeks ago,
the --interface argument wasn't properly ported and thus was ignored.
This restores the original functionality of defaulting to only
listening on localhost.
Ideally, we'd replace the vagrant/zulipdev user check with something
that just checks whether a special file that is created by the
Vagrant/remote-dev-vm creation process exists; that would be more
robust.
2016-11-26 17:23:31 -08:00
Steve Howell
6ed1dc9341
Create api docs from url coverage data from tests.
...
I also retire tools/analyze-url-coverage in this commit,
since the API docs cover most of the functionality.
2016-11-26 14:49:23 -08:00
Anders Kaseorg
207cf6302b
Always start python via shebang lines.
...
This is preparation for supporting using Python 3 in production.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-26 14:46:37 -08:00
Anders Kaseorg
1ea8abe493
Replace python -u with PYTHONUNBUFFERED=1
...
(Why is -u needed at all? I’m not sure, but test-run-dev spins forever
“Polling run-dev...” without it.)
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-26 13:20:22 -08:00
Arpith Siromoney
f0df1db9fb
tools: Remove tools/node and call node directly instead.
...
Previously, we didn't install/pin our own node.js version, and thus
had this wrapper script to manage it. Now that install our own node
via nvm, there's no reason we still need this.
Fixes #2409 .
2016-11-26 12:42:58 -08:00
Tim Abbott
25c6b9f586
pre-commit: Call lint-all with --force.
2016-11-26 12:30:16 -08:00
Steve Howell
8110c3f799
tools: Check provisioning version in lint-all.
2016-11-26 11:36:53 -08:00
Steve Howell
5f5e6b6d83
tests: Enforce 100% URL coverage.
...
We now instrument URL coverage whenever you run the back end tests,
and if you run the full suite and fail to test all endpoints, we
exit with a non-zero exit code and report failures to you.
If you are running just a subset of the test suite, you'll still
be able to see var/url_coverage.txt, which has some useful info.
With some tweaks to the output from tabbott.
Fixes #1441 .
2016-11-18 18:10:29 -08:00
Tim Abbott
2abe11e209
lint-all: Fix progress bar from `npm run lint` in linter.
...
Also fixes printing the `eslint` help output in the event that there
are no files to check.
See https://github.com/zulip/zulip/pull/2246#issuecomment-261673662
for details on the original problem.
2016-11-18 16:19:05 -08:00
Arpith Siromoney
497c7702cc
Run eslint in tools/lint-all with npm run --silent lint
...
This commit adds a basic eslintrc that emulates jslint defaults.
Rules that conflict with our existing code have been switched to
warnings instead of errors. Globals have been added to the eslintrc. The
bundled js file (generated by webpack) and blueslip.js are ignored with
.eslintignore.
To display warnings, run npm run lint-loud. This runs eslint without the
--quiet option on static/js and frontend_tests.
npm run --silent lint is run by tools/lint-all (in addition to jslint).
The --silent option is used to suppress the default output from npm run.
Fixes #535 .
2016-11-18 16:15:45 -08:00
Vladislav Manchev
d7e1e4a2c0
Add initial implementation of custom realm filters.
...
This PR was abandoned by Vladislav and then substantially modified by
Igor Tokarev and Tim Abbott to complete it and fix a number of bugs.
Fixes #544 .
2016-11-17 17:11:25 -08:00
paxapy
012ec2beda
test-backend: Use a fixed whitelist of shallow-tested templates.
...
This enforces the requirement that all templates not on this list are
tested. Part of #1677 .
2016-11-17 11:34:50 -08:00
Pweaver (Paul Weaver)
059cd1e7aa
tests: enable the pep8 linter in travis CI.
2016-11-17 00:11:00 -08:00
Pweaver (Paul Weaver)
8f05ea877d
lint: Fix pep8 linter error regressions.
...
Since `lint-all --pep8` wasn't running in CI, a few errors have leaked
in.
2016-11-17 00:09:21 -08:00
Christie Koehler
391ff638d5
build_emoji: Add nice error message for symlink errors.
2016-11-15 21:10:39 -08:00
Christie Koehler
2488698430
provision: Add symlink creation check.
...
This helps automatically detect a common issue where users try to use
the Vagrant development environment on windows without administrator
permissions, which results in errors trying to create symlinks.
2016-11-15 21:10:39 -08:00
Tomasz Kolek
2335e1b8b9
Add escaping charactes (=,>,<) by checking correct spelling of GitHub word
2016-11-15 10:48:12 -08:00
Brock Whittaker
75db036733
Add toggle component.
...
This adds the toggle component which removes the necessity to have HTML.
2016-11-15 10:20:37 -08:00
Steve Howell
59750a1cb9
Move more unread logic out of stream_list.js.
...
There are two split-outs code of the code here:
- Animation stuff is in unread_ui.js.
- PM unread counts get handled by pm_list.js.
2016-11-14 17:50:55 -08:00
Umair Khan
3d3800314f
Django 1.10: Setup django before running queue processors.
2016-11-14 16:09:12 -08:00
Steve Howell
7b0c6459b4
Extract static/js/pm_list.js.
...
This handles most of the details of building the Private Messages
section in the upper left corner of the app.
2016-11-11 12:12:13 -08:00
Umair Khan
07d73996d4
Django 1.10: Add tool to check urls.
...
Checking urls through linter was proving to be difficult as
the urls can span multiple lines.
2016-11-10 16:20:04 +05:00
Shashank
702d3cf103
Check provision version in run-dev.py.
...
Don't start run-dev.py if the provisioning version is
incorrect.
2016-11-09 16:06:16 -08:00
paxapy
6d93b3b60c
lint: Fix E703 pep8 violations.
2016-11-09 15:18:35 -08:00
paxapy
456e761294
lint: Add pep8 checker to the project.
...
We set this up initially with all of the rules that Zulip violates
disabled.
Also, the pep8 linter is substantially slower than the other Zulip
linters, so we've put it behind an option to `tools/lint-all`.
2016-11-09 15:17:49 -08:00
Tim Abbott
44767c59a2
Coverage: Exclude migrations and management commands.
...
These are not particularly interesting to measure test coverage for,
since migrations are not run as the part of the test suite by
construction, and management commands aren't being tested by this test
suite.
2016-11-06 18:34:23 -08:00
Tomasz Kolek
704ac5aa6c
Fix lint-all checker by adding "_" as a escape character before Github.
2016-11-05 22:12:25 -07:00
Tim Abbott
ee361cbe30
js: Eliminate process_loaded_for_unread global.
2016-11-05 11:33:04 -07:00
sonali0901
df4b777b35
tests: Fix handling of subdirs and backup files in test-backend.
...
Fixes #1950 .
2016-11-04 21:49:23 -07:00
umkay
b5b8623f46
analytics: Update linter to ignore interpolation in test_counts.
...
Ignore whitespace error for % interpolation in sql queries.
2016-11-03 16:50:39 -07:00
Tim Abbott
a93530e413
Remove unused route for development tornado proxy server.
...
This was a duplicate of the other sockjs line.
2016-11-03 10:46:18 -07:00
Tim Abbott
50361ca980
test-run-dev: Fix buggy site argument.
...
This bug was exposed by 9578908601
.
2016-11-03 09:34:56 -07:00
K.Kanakhin
b248a2c33e
docs-test: Check only http 404 error for external links.
...
- Raise exception only for http 404 error rensponse, for other
http error codes used logging to notify devs about wrong links.
2016-11-01 21:45:41 -07:00