c0a0e6fd70
Set add_bot_backend() config_data param default to {}.
...
Previously, the default was None. This caused 500s when
adding a bot without adding a config_data argument.
2018-02-09 12:30:24 -08:00
02bc506518
bot_data.js: Fix dict indentation.
2018-02-09 12:30:24 -08:00
0abb0315f3
test_events.py: Properly check the bot added event dict.
...
Previously, the 'services' entry in the bot added event dict,
did not get verified, because the test didn't include a service bot.
2018-02-09 12:30:24 -08:00
760cbcc98e
test_events.py: Use create_test_bot().
2018-02-09 12:30:24 -08:00
323284e0b6
backend: Call real endpoint in create_test_bot().
...
This allows tests to be more realistical and to
directly test payload added to add_bot_backend().
2018-02-09 12:30:24 -08:00
33322fed51
bot_settings.js: Narrow config item selector.
...
Needed to avoid selector conflicts with the future
config items in the edit sidebar.
2018-02-09 12:30:24 -08:00
561e0ffe3b
frontend: Delete page_params.realm_bots after first usage.
...
The data in page_params.realm_bots is parsed and captured
in bot_data. bot_data provides a safe system for accessing
this data.
2018-02-09 12:30:24 -08:00
7539512af8
settings-bots.js: Restructure bot edit event handler.
...
Shift and unify some variables to make the code more
logical and concise.
2018-02-09 12:30:03 -08:00
f371c79c22
settings-bots.js: Fully generate bot owner list in handlebars.
2018-02-09 12:30:03 -08:00
f57d592d88
edit-outgoing-webhook-service.handlebars: Fix typo.
2018-02-09 12:30:03 -08:00
273f62f8cd
settings-bots.js: Remove redundant sidebar close event handler.
...
All the event handler did was resetting some entries in the edit
bot form. This is unnecessary, because the whole form gets
destroyed anyway when closed.
2018-02-09 12:30:03 -08:00
338bba7a0f
edit_bot.handlebars: Extract outgoing webhook form.
...
This removes ugly .show() .hide() constructions that
were previously used to dynamically display the form.
2018-02-09 12:30:03 -08:00
1ec9932aec
settings_bots.js: Clean up bot edit event handler.
...
This is done by rewriting JS manipulations of the DOM tree
in the bot-settings.handlebars template. Dead code involving
the affected JS variables is removed.
2018-02-09 12:30:03 -08:00
032cc8497f
settings sidebar: Extract bot edit form.
...
This is the first step in cleaning up the bot edit code.
Since the bot edit form appears dynamically, we remove
it from the static HTML scaffold, of which settings_sidebar
is a part of.
2018-02-09 12:30:03 -08:00
721a241901
slack importer: Update doc about slack user's skype and phone data.
2018-02-09 12:17:10 -08:00
fbc11b141b
slack importer: Add 'realm_name_in_notifications' field in zerver_userprofile.
...
This was recently added in b875fe07eb
2018-02-09 12:17:10 -08:00
6addf79edb
slack importer: Test import in existing database with fixtures.
...
Check in sample slack dataset fixtures, test data conversion and import of
this converted data into an existing database.
2018-02-09 12:17:10 -08:00
be05bccb5b
slack importer: optimize allocation of id range before import.
2018-02-09 12:17:10 -08:00
a0b7976f77
slack importer: Fix output_dir path and remove sys.exit(0).
...
Also, as the exception is being handled in 'slack_data_to_zulip_data'
remove it from the manage.py command 'convert_slack_data'.
2018-02-09 12:17:10 -08:00
699021e7d8
slack importer: Update Documentation with slack's legacy token method.
2018-02-09 12:17:10 -08:00
c0e30079f6
slack importer: Get user data from a get request to slack users api.
...
The fresh imported data shows that the users emails are not included
in the data. However, the data received from the older method of slack
(which is using legacy tokens) contains the email data of the users.
2018-02-09 12:17:10 -08:00
6e30da9f92
doc: Add blog link to CONTRIBUTING.
2018-02-09 12:04:28 -08:00
1f8b6938a7
stream settings: Fix error in updates of stream description.
...
When removing the description from a stream (i.e. setting it to ""),
the UI was not correctly updating the description. This is because we
were checking incorrectly for a falsey value, rather than the specific
value undefined (which means the description wasn't changed).
2018-02-09 12:02:22 -08:00
08533ba787
stream settings: Show message in case of no stream description.
...
Show "No description." message if stream doesn't have any
description in stream settings.
2018-02-09 12:00:45 -08:00
afda05adc4
rate limiting: Increase default rate limits.
...
It's too easy to go over the rate limits when using the webapp.
The correct fix for this probably involves some changes to which
routes get covered by what sort of rate limit, but for now, just
increase the limits.
2018-02-09 11:55:08 -08:00
ea0fe90367
webhooks/beeminder/doc.md: Use better macros.
2018-02-09 11:53:32 -08:00
77addc5456
bugdown: Fix handling of ultra-long renderings.
...
If some bug in Bugdown results in a rendered message content that is
bigger than twice the message size, we now just throw an exception
from Bugdown. This is considerably better than the old behavior,
which might result in an enormous message being placed in the database
(potentially, bigger than the 1MB limit to store in memcached), which
would in turn result in tragic consequences.
This fixes #8322 , in that it prevents the super bad outcome seen there
(where basically Zulip became unusable for everyone on the stream
where the message is posted). Now, the failure mode is just the
message failing to send. Still not ideal (and requires further work
on the URL embed feature), but not a minor problem, not a major one.
2018-02-09 10:57:55 -08:00
9cd7f59c9b
recent senders: Use message ids instead of timestamps for sorting.
...
This matches the convention that we use everywhere else in Zulip.
Fixes : #5956 .
2018-02-08 18:39:10 -08:00
ebe16e064e
README: Include CircleCI build status badge.
...
For now, we still need the Travis badge, since Travis is where we test the
production installation process. But ideally, we'll end up removing that too.
2018-02-08 18:24:43 -08:00
7df29e7a7c
puppet: Only use those "modern" options when on xenial.
...
On trusty, we of course have an older version -- 1.4.14 -- and it is
not so modern, so this just gives an error.
2018-02-08 18:11:52 -08:00
3853577486
api tests: Add example/tests for unsubscribing other users.
...
This commit adds tests (and thus, an extra code example) for
unsubscribing another user from a particular stream by passing in
the `principals` argument to client.remove_subscriptions. The
ability to pass in `principals` was added in the latest release
of the zulip API PyPI package.
2018-02-08 17:58:41 -08:00
ac5c355a60
api/delete-queue: Make fixtures/examples testable.
...
api/delete-queue now uses the Markdown extension in
bugdown/api_code_examples to generate code examples and fixtures
from tests.
2018-02-08 17:58:41 -08:00
344cf2c8ee
api_tests: Add tests for client.register_queue.
2018-02-08 17:58:41 -08:00
66ca0c725f
api/get-all-users: Make fixtures/examples testable.
...
api/get-all-users now uses the Markdown extension in
bugdown/api_code_examples to generate code examples and fixtures
from tests.
2018-02-08 17:58:41 -08:00
929724e5e7
api docs: Add page for common error payloads.
...
We now have a separate page for common error payloads, for example,
the payload for when the client's API key is invalid. All error
payloads that are presented on this page will be tested similarly
to our other non-error sample fixtures.
2018-02-08 17:58:41 -08:00
037c891fcf
webhooks/delighted: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
69f248aaf9
webhooks/codeship: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
06e86ce50d
webhooks/bitbucket2: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
5e1a193e76
webhooks/circleci: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
af683800fd
webhooks/basecamp: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help
docs.
2018-02-08 17:45:56 -08:00
ad6dae1bf5
webhooks/appfollow: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
2733540492
webhooks/airbrake: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
86590dfdbe
test-install: Add command destroy-all to clean up test containers.
...
This is just the one-liner I've been keeping in my shell history,
cleaned up a bit (newlines!) and with 28 lines of CLI boilerplate
added in front.
2018-02-08 17:29:41 -08:00
6e633f8e2f
install: Use readlink -f rather than realpath.
...
It does exactly the same thing, though the name is less transparent; and
it simplifies the script by avoiding an extra, early `apt-get install`.
2018-02-08 17:22:02 -08:00
8d86a6e331
install: Slightly clean up another couple of bits of style.
2018-02-08 17:14:28 -08:00
218b653930
install: Clean up organization of option parsing.
...
The parsing of options from environment variables belongs right next
to the normal kind; and `show_help` was unnecessary indirection.
2018-02-08 17:12:36 -08:00
08135e3666
install: Don't try to chown a self-signed cert to zulip.
...
The zulip user has no need to see this file; it's used by nginx.
And when we set up the cert early in install, there's no zulip user
yet anyway, so this fails.
2018-02-08 17:08:16 -08:00
f68c485a86
install: Clean up some shell style: use here-docs, and compact getopt.
2018-02-08 17:05:13 -08:00
8f4b7f6e1e
install: On --express, check up front for --hostname and --email.
2018-02-08 16:34:49 -08:00
31ec9a4627
install: Implement --self-signed-cert earlier.
...
Otherwise when puppet tries to install and start nginx, that can
give an error.
2018-02-08 16:34:49 -08:00
Robert Hönig
Rhea Parekh
Sumana Harihareswara
YJDave
Tim Abbott
Shubham Dhama
Vishnu Ks
Greg Price
Eeshan Garg