Yago González
00a7f89ba9
node tests: Add coverage to composebox_typeahead.js.
2017-06-26 19:33:25 -04:00
Yago González
9be3ff2b3f
composebox_typeahead: Remove unnecessary autocomplete_checks.
...
The validations that autocomplete_checks did were already managed by
tokenize_compose_str and the main "if" statements in
compose_content_begins_typeahead.
2017-06-26 19:33:25 -04:00
Yago González
c348b907e7
composebox_typeahead: Optimize token identification.
2017-06-26 19:33:25 -04:00
Yago González
e76c9f1200
node tests: Add tests to test_begins_typeahead.
2017-06-26 19:33:25 -04:00
Yago González
4fa6aa2268
node tests: Re-sort begins_typeahead tests.
2017-06-26 19:33:25 -04:00
Yago González
024362278e
templates: Remove unnecessary newlines in typeahead_list_item.
2017-06-26 19:33:25 -04:00
Yago González
7e3154f7bc
lint: Ignore tildes in mustache tag template checker.
...
Handlebars allows putting tildes (~) by the braces in mustache tags to
strip whitespaces on that side of the tag.
{{#if foo~}}
<p>Bar</p>
{{~/if}}
This way, the linter ignores any potential tilde at the ends of Handlebars
tags so we can use this feature without lint fails.
2017-06-26 19:33:25 -04:00
Yago González
67433691a9
templates: Fix typo in error message.
2017-06-26 19:33:25 -04:00
Umair Khan
acf0aad4a2
signals.py: Bring coverage to 100%.
2017-06-26 16:14:14 -07:00
Umair Khan
6357737978
get_device_browser: Fix Opera detection.
...
Starting from version 15, Opera uses 'OPR/' in its user agent string.
We need to move Opera detection before Chrome detection because
Opera's user agent string satisfies Chrome conditions as well.
Ref: https://dev.opera.com/blog/opera-user-agent-strings-opera-15-and-beyond/
2017-06-26 16:14:14 -07:00
Umair Khan
14402b0b97
get_device_browser: Move Edge detection to the top.
...
The user agent strings of Edge satisfy Chrome condition as well.
Ref: https://msdn.microsoft.com/en-us/library/hh869301(v=vs.85).aspx
2017-06-26 16:14:14 -07:00
Umair Khan
dc78a7888f
login_or_register_remote_user: Send login emails for mobile.
...
Fixes #5389
2017-06-26 16:14:14 -07:00
Umair Khan
34a91be9a2
api_fetch_api_key: Send new login emails for mobile.
2017-06-26 16:14:14 -07:00
Umair Khan
7e43cd5624
get_device_browser: Fix browser string for mobile.
...
Now get_device_browser() returns 'Zulip' for 'ZulipAndroid' and
'ZulipMobile'.
2017-06-26 16:14:14 -07:00
Umair Khan
b9c69004e4
google_oauth2_test: Pass headers in all requests.
...
Currently we only pass headers in the first client_get call but
sometimes the effective request which reaches the view is through
a later call to the client_get in this function. Due to which
headers are not passed.
2017-06-26 16:14:14 -07:00
Cynthia Lin
1ce8258f2e
docs: Add reminder to update ReadTheDocs config in release checklist.
2017-06-26 16:09:36 -07:00
Greg Price
058d76f5ff
avatar_hash: Update a comment to reflect the current code.
...
Also move a couple of comments inside the functions they describe,
because they're about the implementation of the functions rather
than their interface.
2017-06-26 15:15:32 -07:00
Daria Phoebe Brashear
8343cd4300
zephyr_mirror.py: update zulip server url for zephyr documentation
...
zulipchat.com hosts the documentation (as well as the server); make the
url reflect it
2017-06-26 14:07:28 -07:00
Greg Price
e63f6734ac
travis: Run different suites first, then try Python 2.
...
Also add a comment explaining why the order in this file matters.
It's not obvious that it should, so it's otherwise tempting
to reorder them to optimize only for readability.
2017-06-26 13:17:39 -07:00
Aditya Bansal
411883365a
compose.js: Create initialize() function.
2017-06-26 15:55:10 -04:00
Aditya Bansal
1cb5c9faa8
node tests: Enforce 100% test coverage upon emoji.js.
2017-06-26 14:24:20 -04:00
Aditya Bansal
7f2b6f739c
emoji.js: Add test coverage for initialize.
2017-06-26 14:24:20 -04:00
Aditya Bansal
88d9739c45
emoji.js: Add test coverage for build_emoji_upload_widget func.
2017-06-26 14:24:20 -04:00
Aditya Bansal
d1fe75ce3b
node tests: Enforce 100% node coverage in activity.js.
2017-06-26 14:24:20 -04:00
Eeshan Garg
708f3a4bb1
lib/integrations: Stop rendering HTML files.
...
Now that all of our integrations/webhooks docs have been migrated
to Markdown, we no longer need to render HTML.
2017-06-26 12:30:04 -04:00
Eeshan Garg
4ad951f256
integrations/perforce: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
ed388ed320
integrations/redmine: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
53c1a53120
integrations/jenkins: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
9115be0e9e
integrations/trello-plugin: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
085ce20feb
markdown: Recommend installing bindings to the server with bot.
...
Instead of recommending our users to download and install our
bindings "to the <integration_name> server", we now recommend
installing our bindings "to the server where the
<integration_name> bot lives". Technically, the latter is more
accurate.
2017-06-26 12:30:04 -04:00
Eeshan Garg
c17600e3be
integrations/rss: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
fc11615f55
google-calendar: Fix typo and improve Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
90fff71677
integrations/nagios: Use create-stream macro.
2017-06-26 12:30:04 -04:00
Eeshan Garg
e46053e393
integrations/codebase: Use change-zulip-config-file macro.
2017-06-26 12:30:04 -04:00
Eeshan Garg
3db11d83da
integrations/trac: Use Markdown macros.
2017-06-26 12:30:04 -04:00
Eeshan Garg
421c71919c
integrations/mercurial: Use create-stream macro.
2017-06-26 12:30:04 -04:00
Eeshan Garg
9dde906115
integrations/git: Use macros and improve Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
6a84b50758
capistrano: Wrap long lines and improve Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
000ae04899
integrations/twitter: Use create-stream macro.
2017-06-26 12:30:04 -04:00
Eeshan Garg
b60c95d971
integrations/svn: Use Markdown macros.
2017-06-26 12:30:04 -04:00
Eeshan Garg
b9ac92c1a0
integrations/openshift: Use Markdown macros.
2017-06-26 12:30:04 -04:00
Eeshan Garg
1d9ab996c7
markdown: Clarify stream name recommendations in create-stream.
...
Now, we further clarify in the create-stream.md macro that even
if users follow our default stream name recommendation for a
given integration, said stream must still be explicitly created.
2017-06-26 12:30:04 -04:00
Eeshan Garg
242162f9db
markdown: Add macros for changing integration config files.
2017-06-26 12:30:04 -04:00
Eeshan Garg
31fa2f7c6d
integrations/hubot: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
3eeb90c599
integrations/puppet: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
fc0d7ed882
integrations/phabricator: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
169d7393a6
jira-plugin: Use create-stream macro and improve Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
70448a9c65
integrations/email: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
5fa71a4369
integrations/asana: Migrate docs to Markdown.
2017-06-26 12:30:04 -04:00
Eeshan Garg
843dbbf3a1
webhooks/slack: Restructure docs to use create-stream.md macro.
2017-06-26 12:30:04 -04:00