Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
55,832 Commits 28 Branches 143 Tags 627 MiB
Commit Graph

3142 Commits

Author SHA1 Message Date
Karl Stolley 0c8730a723 portico: Correct spacing at footer bottom. 
This reduces reliance on margin for layout, preventing undesired
space appearing below the footer and better using flexbox to align
elements in the legal area.
 2024-01-04 10:26:36 -08:00
evykassirer 434b67caf5 message_feed_top_notices: Convert module to typescript. 2024-01-03 14:39:26 -08:00
Tim Abbott 337b0023db e2e-tests: Remove stale comment. 
This was incorrectly not removed in
6e725fb3c3.
 2024-01-03 13:59:21 -08:00
Sahil Batra 9197a2c3e2 user_pill: Add support to not allow adding inaccessible users manually. 
We previously allowed adding pills for inaccessible user by typing
the email manually. This commit updates it to handle inaccessible
users like we handle invalid emails.
 2024-01-03 11:04:35 -08:00
Sahil Batra ede88191a8 input_pill: Define a type for pill_config object. 2024-01-03 11:04:35 -08:00
evykassirer cd9a479a7e narrow_banner: Convert module to typescript. 2024-01-03 10:28:10 -08:00
evykassirer 08bee0f180 message flags: Convert module to typescript. 2024-01-02 16:48:45 -08:00
evykassirer a87b1d5ad8 filter: Use terms instead of operands. 
Operand is a confusing name because this
data structure has an attribute *called*
operand. This commit renames references to
this structure to "term", short for "search
term".
 2024-01-02 16:24:53 -08:00
Alya Abbott 2732da2bb2 settings: Update description text in Settings > Topics panel. 2024-01-02 15:54:48 -08:00
evykassirer c0719e0285 pm_list_data: Convert module to typescript. 2024-01-02 10:27:02 -08:00
Anders Kaseorg 06d439e0b2 typing_events: Fix early read of page_params. 
For spectators,
page_params.server_typing_started_expiry_period_milliseconds has not
been initialized yet at module load time.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-01-01 17:39:10 -08:00
Anders Kaseorg 45c8dcc9c3 typing: Fix early read of page_params. 
For spectators,
page_params.server_typing_started_wait_period_milliseconds and
page_params.server_typing_stopped_wait_period_milliseconds have not
been initialized yet at module load time.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-01-01 17:39:10 -08:00
Anders Kaseorg 80432c8c06 stream_create: Fix early read of page_params. 
For spectators, page_params.realm_create_public_stream_policy,
page_params.server_web_public_streams_enabled,
page_params.realm_enable_spectator_access have not been initialized
yet at module load time.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-01-01 17:39:10 -08:00
Anders Kaseorg 8f069ac1d8 settings_profile_fields: Fix early read of page_params. 
For spectators, page_params.custom_profile_field_types has not been
initialized yet at module load time.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-01-01 17:39:10 -08:00
Anders Kaseorg 8066405d9b tests: Fix incorrect reference to page_params.sent_by_me. 
Commit 24a1f7b792 (#23056) introduced
this mistake; it has never existed.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-01-01 17:37:50 -08:00
Anders Kaseorg 2a69545bec page_params: Move initial_pointer and friends to message_fetch. 
These aren’t sent by the server; they’re client-side global variables.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-01-01 17:37:50 -08:00
Anders Kaseorg e8e7142ed1 page_params: Move events_queue_expired to server_events. 
This isn’t sent by the server; it’s a client-side global variable.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-01-01 17:37:50 -08:00
Sahil Batra 8f795e22e8 settings: Fix discard button in groups UI in dark theme. 2023-12-30 11:15:30 -08:00
Anders Kaseorg 8514c8d739 page_params: Fix types of narrow, server_sentry_dsn, user_id. 
page_params.narrow may be undefined, page_params.server_sentry_dsn may
be null but not undefined, and page_params.user_id may be 0 (for
spectators) but not undefined.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-29 14:16:19 -08:00
Anders Kaseorg a5d51a0895 people: Don’t reference nonexistent page_params.is_bot. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-29 13:05:30 -08:00
sayyedarib b430ba2bd5 navbar_help_menu: Migrate module to typescript. 
Signed-off-by: sayyedarib <sayyedaribhussain4321@gmail.com>
 2023-12-29 12:15:08 -08:00
Anders Kaseorg 2cf8f1c063 page_params: Move page_load_time to zulip_test. 
This isn’t sent by the server; it’s a client-side global variable.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-29 11:58:58 -08:00
evykassirer baf6c68ab8 starred_messages: Migrate module to typescript. 2023-12-28 18:24:40 -08:00
evykassirer baba72df91 compose_banner: Restrict banner to only JQuery, never htmlString. 
Co-authored-by: Anders Kaseorg <anders@zulip.com>
 2023-12-28 16:53:46 -08:00
evykassirer 1f21510dd4 compose_notifications: Convert module to typescript. 2023-12-28 16:53:46 -08:00
Varun Singh 62a636068e subscriber_api: Convert module to TypeScript. 2023-12-28 15:05:16 -08:00
evykassirer 6157d83d3a unread_ui: Convert module to typescript. 2023-12-28 11:26:37 -08:00
evykassirer 8d685d5b5a page params: Add furthest_read_time attribute. 2023-12-28 11:26:37 -08:00
evykassirer 5f5e77afd5 local_message: Convert module to typescript. 2023-12-27 23:23:36 -08:00
evykassirer b20694aa07 narrow_history: Convert module to typescript. 2023-12-27 23:12:09 -08:00
evykassirer e0a10c2d94 all_messages_data: Convert module to typescript. 2023-12-27 22:55:47 -08:00
evykassirer ccd5b4a813 narrow_state: Convert module to typescript. 2023-12-27 22:16:21 -08:00
evykassirer b7a28f1630 page params: Add narrow attribute. 2023-12-27 22:16:21 -08:00
evykassirer 0f1fa8e159 message_list_data: Potentially return undefined in first_unread_message_id. 2023-12-27 21:48:54 -08:00
evykassirer 0cf1d49fee message_list_data: Convert module to typescript. 2023-12-27 21:48:54 -08:00
evykassirer dc8d0ed861 message_lists: Convert module to typescript. 2023-12-27 20:44:58 -08:00
evykassirer e0fef6fdff narrow_title: Migrate module to typescript. 2023-12-27 20:39:53 -08:00
evykassirer 01abd96127 buddy_data: Convert module to typescript. 2023-12-27 15:53:39 -08:00
evykassirer 68f2535ebc recent senders: Convert module to typescript. 2023-12-27 14:05:35 -08:00
evykassirer 1f2ea95b9f recent senders: Use for loop instead of filter/if combination. 2023-12-27 14:05:35 -08:00
Anders Kaseorg 6e220f4dc1 eslint: Enable @typescript-eslint/method-signature-style. 
For historical reasons, TypeScript ignores variance errors for method
shorthand type declarations even in strict mode.  Prefer the correctly
checked style.

https://typescript-eslint.io/rules/method-signature-style

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-26 17:30:33 -08:00
Anders Kaseorg b44daf080c list_widget: Remove unknown generic defaults. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-26 17:30:33 -08:00
Anders Kaseorg d7803db5c7 list_widget: Remove get. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-26 17:30:33 -08:00
Anders Kaseorg c1636ffc6f list_widget: Add missing generic parameters to handle_sort. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-26 17:30:33 -08:00
Anders Kaseorg 3cc94ea930 types: Remove stacktrace-gps declarations. 
I sent these upstream with documentation in 3.1.0.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-26 16:26:22 -08:00
evykassirer 4ce13f72f0 filter: Convert module to typescript. 2023-12-26 15:45:40 -08:00
evykassirer cc8b35ff23 filter: Preparation to appease the typescript linter. 2023-12-26 15:45:40 -08:00
evykassirer 2c35aa38b7 filter: Move static functions above public instance method definitions. 2023-12-26 15:45:40 -08:00
evykassirer 86fd0864a7 page_params: Add narrow_stream to type. 2023-12-26 15:45:40 -08:00
Anders Kaseorg c16837a664 eslint: Fix @typescript-eslint/prefer-string-starts-ends-with. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-23 15:36:05 -08:00