Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
48,858 Commits 28 Branches 143 Tags 605 MiB
Commit Graph

16 Commits

Author SHA1 Message Date
madrix01 550a32bb20 recent_topics: Add Private message to recent_topics. 
This commit adds private messages to the Recent topics view, to make
it an all-encompassing overview of recent activity visible to the user.

We add a filter "Include PM" to toggle whether PMs should be shown in
recent topics.

Fixes #19449.
 2022-10-17 15:02:01 -07:00
evykassirer e039bdd1e1 narrow: Replace pm_string() with _id and _email variants. 
This makes the format returned by these functions more clear.
 2022-06-02 16:41:06 -07:00
Anders Kaseorg b0ce4f1bce docs: Fix many spelling mistakes. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2022-02-07 18:51:06 -08:00
strifel 9ae72fd48c compose_closed: Extract get recipient label helper. 
This makes it possible to reuse this logic.
 2022-01-28 14:54:22 -08:00
Priyam Seth 985e95041d compose: Add trigger for new private message. 
This commit adds a new trigger for compose.start that is
"new private message". It will clear the message recipients
whenever compose.start is called with this trigger.

This solves the bug, when a person is in a PM narrow and
clicks the new private message button, it opens the
composebox with the recipients filled out with whoever
you're narrowed to, rather than opening a new, blank PM.

CZO link for the issue
https://chat.zulip.org/#narrow/stream/9-issues/topic/.22New.20private.20message.22.20isn't/near/1222712
 2021-07-05 11:56:46 -07:00
Aman Agrawal 563f8aba1e compose_mobile_button: Use tippyjs for popover. 
There are several benefits of using tippyjs here:
* Removes dependency on bootstrap.
* We don't have to manually handle show/hide of popover.
* There cannot be any memory leak since we don't store
  the instance.
 2021-06-18 17:13:19 -07:00
Aman Agrawal 88454307cd recent_topics: Split into three modules. 
We split recent_topics module into recent_topics_(ui + data + util).

This allows us to reduce cyclical dependencies which were
created due to large list of imports in recent topics. Also, this
refactor on its own makes sense.
 2021-06-10 15:53:05 -07:00
Tim Abbott c690fa1174 compose_closed_ui: Avoid duplicate button in recent topics. 2021-05-11 23:57:57 -07:00
Tim Abbott 8e7761e15b compose: Move closed-compose functions to closed_compose_ui.js. 
This improves the organization of our codebase a bit.
 2021-05-11 23:57:57 -07:00
Aman Agrawal 0d8a7efa09 compose_closed_ui: Show default label for empty narrows. 
The default label for empty narrows depends on whether it's a
stream/topic narrow or a PMs narrow.

We leave some default text in compose.hbs for reply label
because it take some time for the js to display the
correct label.
 2021-05-11 23:57:57 -07:00
Aman Agrawal d8f554eb52 recent_topics: Set default text for reply btn when not focused in table. 
When user is focused in search or filters, show "Compose Message"
as label which is more appropriate.
 2021-05-11 23:51:00 -07:00
Aman Agrawal 7ab562d138 compose_closed_ui: Set text directly to compose_reply_button_label. 
This will allow us set other text to it without making us restore
this html fragment when we replace it.
 2021-05-11 23:51:00 -07:00
Aman Agrawal 0dd8ce6ff9 recent_topics: Hide reply button when search or filters selected. 
Since there is no context for a message in the search or filter buttons,
we don't show reply button either of them are focused.
 2021-05-07 16:07:52 -07:00
Aman Agrawal 51acbefc8a recent_topics: Display compose box & enable compose hotkeys. 
We move compose from being a part of message feed to
being a part of  middle column which is a common parent of recent
topics and message feed. This allows us to use a common compose
box for both the views. Fortunately, compose actions were
independent of this change so there weren't any evident
side effects.

Fixes #17543
 2021-05-07 16:07:51 -07:00
Tim Abbott 638ffb36a4 refactor: Move click handlers to compose_closed_ui.js. 2021-05-04 20:55:58 -07:00
Ken Clary 74dbcdf2a8 frontend: Change 'reply' button label to reflect selected message. 
The 'reply' button shows the stream>topic or recipient(s) of the
selected message, for better UX.  It also expands to fill the
remaining horizontal space in the button bar -- this should help make
it easier for new users to figure out how to reply.

Finally, it uses "Message" instead of "Reply", to better match the
compose box.

Fixes #17940.
 2021-05-03 14:58:02 -07:00