zulip

Commit Graph

Author	SHA1	Message	Date
Tim Abbott	a379fbe442	portico: Inline common.autofocus. This was only called from a single code path.	2023-10-26 16:27:35 -07:00
Junyao Chen	c008ba1172	common: Fix parameter type of `autofocus` function. Throughout the codebase there is currently one usage of `autofocus` excepts in test files. The only one usage is in `signup.js` and was supposed to pass a `JQuery` selector to `autofocus` rather than a string. Passing a selector is more convenient in this case: The selector accessed in `signup.js` is ready to `trigger` the `focus` function, while getting a attirubte string from the selector and then passing to `autofocus` and then accessing the selector by attribute cost extra layers of work. Therefore writing this commit to simplify the type for easy usage. Fixes the test case(s) accordingly.	2023-08-14 16:00:20 -07:00
Anders Kaseorg	cea1119423	node_tests: Move to web/tests. This lets us simplify the long-ish ‘../../static/js’ paths, and will remove the need for the ‘zrequire’ wrapper. Signed-off-by: Anders Kaseorg <anders@zulip.com>	2023-02-23 16:04:17 -08:00

Author

SHA1

Message

Date

Tim Abbott

a379fbe442

portico: Inline common.autofocus.

This was only called from a single code path.

2023-10-26 16:27:35 -07:00

Junyao Chen

c008ba1172

common: Fix parameter type of `autofocus` function.

Throughout the codebase there is currently one usage of `autofocus`
excepts in test files. The only one usage is in `signup.js` and was
supposed to pass a `JQuery` selector to `autofocus` rather than a
string. Passing a selector is more convenient in this case: The
selector accessed in `signup.js` is ready to `trigger` the `focus`
function, while getting a attirubte string from the selector and then
passing to `autofocus` and then accessing the selector by attribute
cost extra layers of work. Therefore writing this commit to simplify
the type for easy usage.

Fixes the test case(s) accordingly.

2023-08-14 16:00:20 -07:00

Anders Kaseorg

cea1119423

node_tests: Move to web/tests.

This lets us simplify the long-ish ‘../../static/js’ paths, and will
remove the need for the ‘zrequire’ wrapper.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

2023-02-23 16:04:17 -08:00

3 Commits