Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
56,006 Commits 28 Branches 143 Tags 606 MiB
Commit Graph

854 Commits

Author SHA1 Message Date
Rishi Gupta a16c48f0c4 actions.py: Change do_remove_realm_alias to take a RealmAlias. 
Ensures that this function doesn't throw an error / prevents putting in an
incorrect realm or domain argument.
 2017-02-08 21:15:28 -08:00
Tim Abbott 01daa3e91a test_helpers: Move get_subscription out of actions.py. 
It's no longer used by anything other than test code.
 2017-01-29 20:27:00 -08:00
Tim Abbott a3f3f5b7bc remove_default_stream: use access_stream_by_name. 2017-01-29 20:27:00 -08:00
Tim Abbott 19eaa92059 add_default_stream: use access_stream_by_name. 2017-01-29 20:27:00 -08:00
Tim Abbott de3f539f58 do_change_stream_description: Accept a stream as argument. 2017-01-29 20:27:00 -08:00
Tim Abbott 2dc90e8ebd rename_stream: Pass a stream object to do_rename_stream. 2017-01-29 20:27:00 -08:00
Harshit Bansal b4186fdfdd views/realm_aliases.py: Use domain instead of id as handle for RealmAlias. 
We need to make the change for the API, and the next commit introduces a
unique_together constraint on (realm, domain) anyway.
 2017-01-26 17:24:25 -08:00
Tim Abbott d6e38e2a5c lint: Clean up E123 PEP-8 rule. 2017-01-23 21:34:26 -08:00
Rishi Gupta 89af775e03 test_classes: Remove domain from ZulipTestCase.register. 2017-01-06 19:45:08 -08:00
Harshit Bansal ceb636dbd9 Manage allowed domains from admin settings. 
Fixes: #1867.
 2017-01-06 12:03:31 -08:00
Rishi Gupta 2b0a7fd0ba Rename models.get_realm_by_string_id to get_realm. 
Finishes the refactoring started in c1bbd8d. The goal of the refactoring is
to change the argument to get_realm from a Realm.domain to a
Realm.string_id. The steps were

* Add a new function, get_realm_by_string_id.

* Change all calls to get_realm to use get_realm_by_string_id instead.

* Remove get_realm.

* (This commit) Rename get_realm_by_string_id to get_realm.

Part of a larger migration to remove the Realm.domain field entirely.
 2017-01-04 17:12:23 -08:00
Rishi Gupta cf762eaf84 Change X.realm.id to X.realm_id across codebase. 
This makes it more clearly the pattern in the Zulip codebase, and thus
decreases the risk of accidentally doing database queries.
 2017-01-03 16:46:26 -08:00
Prabod Rathnayaka 6f087e468e Add setting hiding private message content in desktop notifications. 
Tweaked by tabbott to fix a refactoring bug, set the default to True,
fix the real-time sync, and add tests for this.

Fixes #2355.
 2016-12-30 14:10:34 -08:00
Bojidar Marinov d28f1ddfb4 zerver: Handle `update_global_notifications` in `apply_events` 
Fixes #2358
 2016-12-13 20:20:26 -08:00
nikolay abc2ff4a06 pep8: Fix many rule E128 violations. 
[Tweaked by tabbott to adjust some approaches used in wrapping]
 2016-12-03 13:33:31 -08:00
Sidhant Bhavnani 8c0c12c1d9 pep8: Fix E303 violations. 2016-12-02 15:34:11 -08:00
AZtheAsian 7e14fe65ab pep8: fix E202 violations 2016-12-01 23:06:02 -08:00
Bickio e009383460 pep8: Fix E231. 2016-11-30 19:59:25 -08:00
Tim Abbott 3d1bcb05e1 tornado: Move event_queue.py to zerver/tornado/. 
Fixes #729.
 2016-11-26 22:29:28 -08:00
Tim Abbott 1fcf2ff525 tornado: Move zerver.tornadoviews to zerver.tornado.views. 
This furthers the overall goal of moving all the Tornado-specific code
to zerver/tornado/.
 2016-11-26 22:29:28 -08:00
Vladislav Manchev d7e1e4a2c0 Add initial implementation of custom realm filters. 
This PR was abandoned by Vladislav and then substantially modified by
Igor Tokarev and Tim Abbott to complete it and fix a number of bugs.

Fixes #544.
 2016-11-17 17:11:25 -08:00
Steve Howell 3a8282ff44 Add test coverage for /notify_tornado. 
We now have test coverage for all of our endpoints.
 2016-11-17 10:11:46 -08:00
reyha 9f8630fed8 tests: Access realms by string_id. 
Replaces get_realm() function by get_realm_by_string_id() function
in zerver/tests.

Fixes #2226.
 2016-11-15 13:32:20 -08:00
sinwar 4582a98c09 tests: Split out ZulipTestCase and WebhookTestCase to a separate file. 
Fixes #1671.
 2016-11-10 19:29:43 -08:00
Steve Howell a03a7d4c95 peer_remove: Send user_id, not email, for unsubscribe events. 2016-11-08 15:36:29 -08:00
umkay f4c621ffe3 admin: Enable admins to toggle supported auth methods via UI. 
Add a table to the administration page that will allow realm admins to
activate and deactivate the supported authentication methods for that
realm.
 2016-11-06 16:29:35 -08:00
Steve Howell 2088e8420f User user_id, not email, in peer_add events. 2016-11-04 11:37:14 -07:00
Steve Howell 768a04d2fa Send user_ids for update events. 
Here we handle a few flavors of realm_bot/update
and realm_user/update.  (Different events send different
attributes.)
 2016-10-28 13:40:14 -07:00
Steve Howell 7883cecf28 Send user_id to the client in more places. 
This commit touches:

    realm_bot/add
    realm_user/add
    page_params.bot_list
    page_params.people_list
 2016-10-28 13:40:14 -07:00
Steve Howell 0861421912 Use make_stream() in test_events.py. 2016-10-22 18:09:34 -07:00
Steve Howell 77c75df284 Remove do_remove_subscription() calls in test_events. 2016-10-20 22:05:19 -07:00
Tim Abbott 8f145e03cf views: split events_register.py from main views file. 2016-10-11 21:27:06 -07:00
Steve Howell b2f84f0fa4 Move render_markdown() to lib/message.py. 
This removes a bugdown circular dependency.
 2016-10-04 11:34:53 -07:00
Supriya 4959e8d10a tests: Extract and use assert_max_length test helper. 
This makes it much more explicit in which cases we're checking
equality or a maximum in our use of `assert_length`.

Fixes #1400.
 2016-09-25 15:44:58 -07:00
Steve Howell fd6ee7117f tests: Renamed AuthedTestCase to ZulipTestCase. 2016-08-22 19:07:44 -07:00
Rag Sagar 2fef36f15a Add realm-level default language setting. 
Adds a new field default language in the zerver_realm model.
This realm level default language will be used as default language
for newly created users. Realm level default language can be
changed from the administration page.

Fixes #1372.
 2016-08-09 17:38:29 -07:00
Tim Abbott 4f782bc186 test_events: Fix annotation gaps. 2016-08-04 15:57:03 -07:00
Kartik Maji 599b15cb84 Allow fetching subscribers for streams the user has never subscribed to. 
This allows the frontend to fetch data on the subscribers list (etc.)
for streams where the user has never been subscribed, making it
possible to implement UI showing details like subscribe counts on the
subscriptions page.

This is likely a performance regression for very large teams with
large numbers of streams; we'll want to do some testing to determine
the impact (and thus whether we should make this feature only fully
enabled for larger realms).
 2016-07-18 16:24:19 -07:00
Rishi Gupta 09754c9861 Remove JsonableErrors from actions.do_update_message. 
There were a bunch of authorization and well-formedness checks in
zerver.lib.actions.do_update_message that I moved to
zerver.views.messages.update_message_backend.

Reason: by convention, functions in actions.py complete their actions;
error checking should be done outside the file when possible.

Fixes: #1150.
 2016-07-15 13:55:49 -07:00
Rishi Gupta d529a94e4d Add realm setting to time-limit editing of message content. 
This is controlled through the admin tab and a new field in the Realms table.
Notes:
* The admin tab setting takes a value in minutes, whereas the backend stores it
  in seconds.
* This setting is unused when allow_message_editing is false.
* There is some generosity in how the limit is enforced. For instance, if the
  user sees the hovering edit button, we ensure they have at least 5 seconds to
  click it, and if the user gets to the message edit form, we ensure they have
  at least 10 seconds to make the edit, by relaxing the limit.
* This commit also includes a countdown timer in the message edit form.

Resolves #903.
 2016-07-15 13:55:49 -07:00
Steve Howell 191ac80475 Remove callback logic from test_helpers.DummyHandler. 2016-07-13 19:08:28 -07:00
Rishi Gupta 43c2f35776 Add realm setting to disable message editing. 
This is controlled through the admin tab and a new field in the Realms
table.  This mirrors the behavior of the old hardcoded setting
feature_flags.disable_message_editing.  Partially resolves #903.
 2016-07-10 11:57:24 -07:00
Kartik Maji f8bb7503e6 Add ability to pin streams to top of the streams sidebar list. 
Based on work by Lauren Long, with some tweaks by tabbott.
 2016-06-30 22:26:09 -07:00
Kartik Maji a32167d921 test_events: Sort subscribers list. 
The subscribers list is appended to in `peer_add` events with not
regard for preserving the ordering, and ordering isn't really
important here, so it seems best to just sort it in these checks.
 2016-06-30 16:52:51 -07:00
Vishnu Ks f9f31b79d0 Make default_streams web controllable. 
Fixes: #665
 2016-06-09 15:24:32 -07:00
Deborah Hanus a261a6bbac Annotate zerver/views/__init__.py. 
Also fix typing errors in a few related files.

[with tweaks from tabbott]
 2016-06-05 11:34:19 -07:00
Tim Abbott 966375d74c Annotate test_events, test_realm_emoji, test_uploads. 2016-06-04 11:53:20 -07:00
Tim Abbott 8cef9675c8 Run mypy on zerver/lib/test_events.py. 2016-06-02 23:00:04 -07:00
Tomasz Kolek 8c18b8947f Add bot_type field to UserProfile. 
This is intended to support creating different types of bots with
potentially limited permissions.
 2016-05-19 22:37:37 -07:00
Aristeidis Fkiaras 3ee210d9e8 Add setting to only allow admins create new streams. 
Fixes: #691.

Thanks to Preston Hansen for work on this feature!
 2016-05-18 18:53:13 -07:00
Tim Abbott b4ccca300b Add tests for whether API keys appear in initial state data. 2016-05-10 09:50:47 -07:00
Tim Abbott f02571202a EventsRegisterTest: display full error diffs. 2016-05-09 10:12:35 -07:00
Vladislav Manchev f5e6176aea Add custom realm emoji UI to administration page. 2016-04-26 13:15:54 -07:00
Tim Abbott be96cf809d Move Zulip backend tests to zerver.tests. 2016-04-11 22:16:09 -07:00