Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
41,275 Commits 28 Branches 143 Tags 627 MiB
Commit Graph

9 Commits

Author SHA1 Message Date
aryanshridhar ce148ce770 frontend: Fix broken label tag and removed label expression. 
- Rectifies broken label tag having a misleading 'for' attribute.
- Removed 'name' attribute from unlabelled span tag.
- Removed label expression from DropdownListWidget to built an,
  abstraction for control group only.

Fixes #17311.
 2021-03-30 16:14:42 -07:00
Aryan Shridhar d1198c46c5 Revert "frontend: Fixed broken label tag and removed label expression." 
This reverts commit 17bae43052.
 2021-03-03 23:58:50 +05:30
aryanshridhar 17bae43052 frontend: Fixed broken label tag and removed label expression. 
Fixes the following issues:

- Rectifies broken label tag having a misleading 'for' attribute.
- Removed 'name' attribute from unlabelled span tag.
- Removed label expression from DropdownListWidget to built an,
  abstraction for control group only.

Fixes #17311.
 2021-02-24 13:50:29 -08:00
Rohitt Vashishtha d870118f8f overlay: Mitigate issue with dropdown list widget getting clipped. 
This isn't a complete fix, but we move the widget's popup to be
on/below the button to open the widget. We also move the bot owner
field to be on the top of the page so that we can see most of the
widget before it is clipped by the parent overlay.

We have discussed some approaches for a permanent fix on:

https://chat.zulip.org/#narrow/stream/321-s/topic/DropdownListWidget/near/894674
 2020-06-04 16:44:19 -04:00
Rohitt Vashishtha 1091615b17 edit-bot: Show dropdown list widget for selecting owner. 
This commit removes user_dropdown in favor of the common
dropdown_list_widget for our bot edit forms.
 2020-05-20 09:51:38 -07:00
Steve Howell 9f137c3a05 bots: Extract user_dropdown widget. 
We use this new widget in bot settings panels
(personal and org).  It lets you re-assign a
bot to a new human user.

Ideally we can improve this code to use
our existing list widgets to make it more
performant for realms with lots of users.
 2020-05-11 16:16:58 -07:00
Jagan 805ac2475b settings: Redesign edit bot form. 
This removes the weird edit-bot sidebar, replacing it with a modal,
matching our edit-user widget (and various similar ones).

Fixes #13644 by removing the buggy code.
 2020-04-28 23:08:45 -07:00
Anders Kaseorg 0c565f50be templates: Use upstream Handlebars partials syntax. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2019-07-12 21:11:14 -07:00
Anders Kaseorg 3c3471b720 templates: Rename *.handlebars ↦ *.hbs and - ↦ _. 
Tweaked by tabbott to avoid accidentally disabling the linter for
handlebars templates.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2019-07-12 21:11:03 -07:00