9266315a1f
middleware: Stop shadowing top-level logger definition on line 33.
2020-07-27 16:46:13 -07:00
282927003f
features: Remove inaccurate accessibility claim.
...
I'm not sure how this got added; it seems to have happened in a visual
redesign of the /features page. Certainly the claim should only have
been added after the work it described was done, and it has not.
2020-07-27 16:41:42 -07:00
3d1a1e0d20
test_logging_handlers: Avoid printing to console.
...
This lets us test the recursion bug behavior of this logging handler
without resulting in `logging.error` output being printed to the
console in the event that the test passes.
2020-07-27 16:33:36 -07:00
3e80cbdeb8
docs/update-message: Add missing editing permission condition.
...
The comments within update_message_backend function of views/message_edit.py
indicates 4 types of permissions which all edit a message. The 4th of these
indicates that a message is editable if the realm allows topic edits. This
was previously missing from the docs and is now added.
2020-07-27 16:33:36 -07:00
9b6de63afe
stream/docs: Add date_created to Stream.API_FIELDS.
...
The parameter Stream.date_created is now sent down to the clients
for both:
- client.get_streams()
- client.list_subscriptions()
API docs updated for stream and subscriptions.
Fixes #15410
2020-07-27 16:33:36 -07:00
1c8f4b936b
sentry: Capture realm name in user information.
2020-07-27 11:07:55 -07:00
af046df3be
sentry: Allow setting DSN via environment.
2020-07-27 11:07:55 -07:00
1b2d0271af
sentry: Prevent double-logging of JSON-formatted errors.
...
Capture and report the initial exception, not the formatted text-only
message traceback.
2020-07-27 11:07:55 -07:00
bfa809181a
sentry: Allow reporting errors to sentry.io.
...
Use the default configuration, which catches Error logging and
exceptions. This is placed in `computed_settings.py` to match the
suggested configuration from Sentry[1], which places it in `settings.py`
to ensure it is consistently loaded early enough.
It is placed behind a check for SENTRY_DSN soas to not incur the
additional overhead of importing the `sentry_sdk` modules if Sentry is
not configured.
[1] https://docs.sentry.io/platforms/python/django/
2020-07-27 11:07:55 -07:00
1f54918c8a
message_controls: Use a template instead of passing html as a string.
...
This commit adds a handlebar template for the View source/Edit message
button in message controls in the message view.
This change also fixes the broken html titles that were added in
commit fdbab54614
2020-07-27 11:05:44 -07:00
e9203d92bb
test_upload: Use assertLogs in upload tests to verify logs.
...
This will avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
c9136586d9
test_signup: Use assertLogs in signup tests to verify logging.
...
This will avoid logs to spam test-backend output.
2020-07-27 11:02:17 -07:00
1668c7395e
test_settings: Verify logs of domain mismatch in password change test.
...
Use assertLogs for verifying debug log produced due to LDAP domain
mismatch while changing password. This will avoid spam in test-backend
output.
2020-07-27 11:02:17 -07:00
dbbacdd3d9
test_sessions: Use assertLogs to avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
4192c6f959
test_report: Use assertLogs to avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
8b9deb9c71
test_realm: Use assertLogs to avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
82646e27c2
test_realm_export: Use assertLogs in endpoint tests to verify info log.
...
This is to avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
3eda7586f3
test_queue_worker: Use assertlogs to verify logs while testing workers.
...
This will avoid spam in output of test-backend.
2020-07-27 11:02:17 -07:00
732f1fa44d
test_queue: Use assertLogs to verify warning in test_queue_error_json.
...
This will avoid spam in test-backend output.
2020-07-27 11:02:17 -07:00
68b9f0b3cf
tests: User assertLogs to verify info logs while soft deactivation.
...
This will avoid spamming of test-backend output.
2020-07-27 11:02:17 -07:00
15c5dadb73
message view: Move live update logic of stream name to `message_store`.
2020-07-27 11:00:31 -07:00
131a1dd54f
message view: Move live update logic of avatar url to `message_store`.
2020-07-27 11:00:31 -07:00
06d0dc1ffa
message view: Move live update logic of full name to `message_store`.
...
This is done to decouple our message view related update events
from MessageListData as there are plans to create multiple
MessageListData objects. Instead we update the `stored_messages`
which tracks the complete data for all messages.
2020-07-27 11:00:31 -07:00
e85bc853d6
message list: Refactor and update API to include `rerender_view`.
...
This is a necessary prep commit as our message live update
functions will call this function, outside the MessageList class.
2020-07-27 11:00:31 -07:00
64894fe8e4
node tests: Avoid "orig_foo = bar" idiom.
...
We use either override or with_field, as
appropriate.
2020-07-27 11:07:41 -04:00
329f38975e
zjsunit: Add with_field helper.
...
This just lets us temporarily assign a value
to a field.
Differences with the "override" scheme:
* override only works on globals
* override (when passed in via run_test) will
just automatically clean up at the end of
the function
2020-07-27 11:07:41 -04:00
2e864d487e
puppeteer: Add subscriptions test and required functions.
...
Tests stream subscriptions and stream creation.
2020-07-26 17:10:56 -07:00
2835092010
puppeteer: Make fill_form function empty text fields before filling.
2020-07-26 17:10:56 -07:00
56c5e0318f
puppeteer: Remove set_pm_recipient.
...
Previous commit introduced same function in pm_recipient object.
So, this comit removes the duplicate `set_pm_recipient`.
2020-07-26 17:10:56 -07:00
4998e32b10
puppeteer: Add compose tests and required functions in common.js.
...
Thanks to Priyank Patel for helping debug flakes.
2020-07-26 17:10:56 -07:00
0b4483c8d2
settings_panel_menu: Convert make_menu to an ES6 class SettingsPanelMenu.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00
025f49dbc4
poll_widget: Convert poll_data_holder to an ES6 class PollData.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00
2e94914be4
list_cursor: Convert list_cursor to an ES6 class ListCursor.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00
9d90ae0e69
fetch_status: Convert FetchStatus to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00
a1796325de
buddy_list: Convert buddy_list_create to an ES6 class BuddyList.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00
a1295936a4
message_list_view: Convert MessageListView to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00
8e5574fbe6
message_list_data: Convert MessageListData to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00
7249103ab4
message_list: Convert MessageList to an ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 17:00:05 -07:00
49db62c240
refactor: Have markdown depend directly on emoji.
...
Now that emoji is in our shared library, we can
require it directly from markdown without
re-introducing any `window` dependencies.
2020-07-26 16:50:14 -07:00
7bb5fac8e0
test_message_send: Mark tests using intentiionally undocumented features.
...
Some parameters such as `to` and `topic` have been intentionally
undocumentecd hence fail request validation. So mark tests which
fail due to this accordingly.
2020-07-26 16:26:57 -07:00
bdf9d912e3
test_classes: Use OpenAPI request validator for validating requests.
...
Expand the `validate_api_response_openapi` function to also validate
requests to ensure better testing.
2020-07-26 16:26:57 -07:00
c91c106cfb
openapi_py: Change condition for invalid requests.
...
Change the condition for allowing failed validation to the condition
that `if the test fails, response status code begins with 4`. Also
add `intentionally_undocumented` argument in `validate_request` for
allowing passing of tests which return `200` responses but fail
validation due to some intentionally undocumented feature in
OpenAPI specification.
2020-07-26 16:26:56 -07:00
8b8cfb2e73
test_link_embed: Add assertLogs to prevent spam in test-backend.
2020-07-26 16:14:17 -07:00
0ca3c1d904
test_home: Use assertLogs to test info logs by do_soft_deactivate_users.
...
This will verify logs without spamming test-backend output.
2020-07-26 16:14:17 -07:00
85fcd0ad99
test_events: Use assertLogs to avoid spam in test-backend output.
2020-07-26 16:14:17 -07:00
4928b55996
test_cache: Use assertLogs to avoid spam in test-backend output.
2020-07-26 16:14:17 -07:00
133a5f2a7c
tests: Add assertLogs for test_auth_backends.
...
This commit tests logging of warning log using assertLogs instead of
printing it in test output hence avoiding spam in test output.
2020-07-26 16:14:17 -07:00
67a67fcc02
tests: Avoid "import logging" and setting root logger level in tests.
...
Use assertLogs to avoid spamming the test-backend output.
2020-07-26 16:14:17 -07:00
c4fe91af74
test_push_notifications: Add assertLogs to verify logging in tests.
...
This will prevent spam in test-backend output and test logging of logs
by the code being tested.
2020-07-26 16:14:17 -07:00
d2520cd7e0
js: Replace underscore with lodash and remove it from globals.
...
Tweaked by tabbott to bump PROVISION_VERSION.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-26 16:12:06 -07:00
Alex Vandiver
Tim Abbott
Sumanth V Rao
Vinit Singh
Mohit Gupta
Ryan Rehman
Steve Howell
Dinesh
Anders Kaseorg
orientor