Tim Abbott
a61386cbbc
github: Fix GitHub integration CSRF issue.
...
The new GitHub dispatcher integration was apparently totally broken,
because we hadn't tagged the new dispatcher endpoint as exempt from
CSRF checking. I'm not sure why the test suite didn't catch this.
2016-12-30 20:31:08 -08:00
Tim Abbott
5c0730d7ca
reactions: Fix check for valid emoji.
...
The previous logic did not correctly handle the case where there were
realm emoji (non-realm emoji would be inaccessible).
2016-12-30 17:51:31 -08:00
Tim Abbott
0ddaa13eeb
lint: Fix indentation error in user_settings.py.
2016-12-30 14:31:04 -08:00
Jackson
aeac3848c8
integrations: Add webhook code, API endpoint, and tests for HelloSign.
2016-12-30 14:19:31 -08:00
Prabod Rathnayaka
6f087e468e
Add setting hiding private message content in desktop notifications.
...
Tweaked by tabbott to fix a refactoring bug, set the default to True,
fix the real-time sync, and add tests for this.
Fixes #2355 .
2016-12-30 14:10:34 -08:00
Tomasz Kolek
56f530331d
Add default topics mechanism to stripe integration.
...
Fixes : #2586 .
2016-12-27 16:27:54 -08:00
Tomasz Kolek
02bf4646fc
Refactor transfer part of stripe integration.
2016-12-27 16:27:54 -08:00
Tomasz Kolek
6dca1ecc40
Refactor order part of stripe integration.
2016-12-27 16:27:54 -08:00
Tomasz Kolek
a75d94d3cf
Refactor invoice part of stripe integration.
2016-12-27 16:27:54 -08:00
Tomasz Kolek
e843af5d27
Refactor customer part of stripe integration.
2016-12-27 16:27:54 -08:00
Tomasz Kolek
d1c486b8e9
Refactor charge part of stripe integration.
2016-12-27 16:27:54 -08:00
paxapy
8e7fa6b2de
emoji: Add add_emoji_by_admins_only realm setting.
...
This setting controls whether normal users can add realm emoji.
Fixes #978 .
2016-12-27 15:46:14 -08:00
Igor Tokarev
ffa724f8fc
emoji: Add author field to RealmEmoji table and track.
2016-12-27 15:42:04 -08:00
Rishi Gupta
717afcb408
Remove calls to get_realm in preparation for its deprecation.
...
Also removes two calls to email_to_domain.
2016-12-26 17:53:32 -08:00
Rishi Gupta
e9a6bd1986
Change register/<domain>/ URL route to register/<realm_str>/.
2016-12-26 17:51:00 -08:00
Rishi Gupta
ea64b18f91
zerver.views: Be confident that request.session['domain'] is valid.
...
We only write domain to the session variable in one place,
accounts_home_with_domain, where we check that the domain is valid, that the
domain corresponds to an open realm, and that we are in the non-subdomains
case.
Previously, we were confusingly checking only a subset of the conditions
on reading back the domain in create_preregistration_user, and not checking
any of them when reading back the domain in get_realm_from_request.
2016-12-26 17:50:46 -08:00
Rishi Gupta
d6e7014f06
Refactor views.create_homepage_form into its callers.
...
The indirection is no longer that useful, and obscures Django's conventional
style for calling a form.
2016-12-26 17:50:23 -08:00
Rishi Gupta
146f2ca482
Refactor get_realm_from_request out of views.create_homepage_form.
2016-12-26 17:49:58 -08:00
Rishi Gupta
1ce9a8a458
Remove confusing comments in HomepageForm and RealmCreationForm.
2016-12-26 17:49:58 -08:00
Rishi Gupta
ddf480136c
Remove unused domain argument from RealmCreationForm.
2016-12-26 17:49:58 -08:00
Rishi Gupta
ec658d038d
Refactor HomepageForm to use a Realm instead of a string_id.
2016-12-26 17:49:58 -08:00
Rishi Gupta
a87e653c32
Refactor models.completely_open to take a Realm instead of a domain.
2016-12-26 17:49:58 -08:00
Juan Verhook
535ce90272
mypy: Convert zerver/views to use typing.Text.
2016-12-26 13:43:09 -08:00
Rafid Aslam
d0502537ab
API: Migrate POST `/ui_settings/change` to PATCH `/settings/ui`
2016-12-24 11:02:02 -08:00
Juanvulcano
2fd1316d70
Removed json/update_message
...
Update test_alert_words.py
Update test_messages.py
Update messages.py
2016-12-24 10:08:22 -08:00
Jackson
3a109a56df
Migrate notify_settings to settings/notifications
...
Remove notify_settings from legacy_url.py
2016-12-24 09:24:23 -08:00
anirudhjain75
8acdbef8aa
Eliminate legacy json/make_stream_public and json/make_stream_private URL
...
Migrate from POST to PATCH
2016-12-24 08:54:49 -08:00
Sampriti Panda
87e7dc6799
urls: Remove legacy URL for left_side_userlist and move over to REST PATCH endpoint
2016-12-24 08:38:33 -08:00
Jackson
333cf0f015
Migrate legacy /json/time_setting to new REST style endpoint.
2016-12-23 08:08:27 -08:00
Tommy Ip
1e0de94293
API: convert get_subscribers from legacy URL to REST endpoint.
2016-12-22 09:25:12 -08:00
Tim Abbott
7d99380488
update_display_settings: Move validation to beginning.
...
This makes the function more friendly for adding additional
functionality to.
2016-12-22 06:58:53 -08:00
Tim Abbott
0299f41c80
settings: Extract update_display_settings_backend.
2016-12-22 06:57:06 -08:00
anirudhjain75
c9db6b6658
Clean up legacy language_settings endpoint.
2016-12-22 06:54:04 -08:00
Sampriti Panda
425a55e568
settings: Implement delete avatar functionality
2016-12-21 13:35:22 -08:00
Sampriti Panda
e72cd0b1cc
urls: convert set_avatar from legacy URL to REST endpoint
2016-12-21 13:35:22 -08:00
Rafid Aslam
bfe84a10f0
API: Migrate POST `json/fetch_raw_message` to GET `json/messages/<id>`
2016-12-21 13:08:40 -08:00
Jackson
59eb7a54e2
integrations: Add documentation for GoSquared.
2016-12-20 16:59:36 -08:00
Jackson
4ff4f12aea
integrations: Add webhook code, API endpoint, and tests for GoSquared.
2016-12-20 16:59:36 -08:00
Umair Khan
7f3fdb2663
Django 1.10: Immediately save session to mitigate race conditions.
2016-12-16 16:24:12 +05:00
paxapy
18e43895ff
streams.py: replace stream_subscribe_button with new #stream syntax.
...
Previously, we included a special subscribe button in new stream
notifications, but that had 2 problems:
(1) The subscribe button would render badly if the stream was renamed.
(2) There wasn't an easy way to look at the stream when deciding
whether to subscribe.
This fixes the second problem, but not really the first.
2016-12-15 22:43:14 -08:00
Tomasz Kolek
bb6d189fa8
Add github dispatcher to have one elegant url for both github integrations.
...
Dispatcher avoids to create new URL for github_webhook.
2016-12-15 17:42:28 -08:00
vaibhav
75bf501553
Add optional waiting period for users to create streams.
...
This adds support for only allowing normal users with account age
equal or greater than a "waiting period" threshold to create streams;
this is useful for open organizations that want new members to
understand the community before creating streams.
If create_stream_by_admins_only setting is set to True, only admin users
were able to create streams. Now normal users with account age greater
or equal than waiting period threshold can also create streams.
Account age is defined as number of days passed since the user had
created his account.
Fixes : #2308 .
Tweaked by tabbott to clean up the actual can_create_streams logic and
the tests.
2016-12-15 16:54:30 -08:00
Tomasz Kolek
6fdc026f64
Move get_profile_backend to views/users.py.
...
Fixes : #2710 .
2016-12-15 16:04:23 -08:00
Sampriti Panda
91780180f6
integrations: Add webhook code, API endpoint, and tests for AppFollow
2016-12-15 11:13:27 -08:00
Umair Khan
8e30530cc5
subdomains: Make GitHub login work with subdomains.
...
Fixes #2501 .
2016-12-14 11:09:39 -08:00
Rafid Aslam
63c157a22b
API: Expose more information in `get_profile_backend()`
...
Adding more additional information about user profile to
`zerver.views.pointer.get_profile_backend`, like `user_id`,
`full_name`, `email`, `is_bot`, `is_admin`, and `short_name` of the
user.
2016-12-14 10:51:39 -08:00
Umair Khan
c7ec5a14ee
Create redirect_to_main_site function.
...
This function is used in OAuth logins so that we can redirect first to
the root domain (e.g. zulipdev.com if subdomains are *.zulipdev.com).
2016-12-13 21:06:52 -08:00
reallyly
94b28e0afb
pep8: Fix E128 violations.
...
With some line-wrapping tweaks by tabbott.
2016-12-13 10:50:14 -08:00
Arpith Siromoney
226e3cbf02
Reactions backend: make endpoints more REST-ful.
...
Adding a reaction is now a PUT request to
/messages/<message_id>/emoji_reactions/<emoji_name>
Similarly, removing a reaction is now a DELETE request to
/messages/<message_id>/emoji_reactions/<emoji_name>
This commit changes the url and updates the views and tests.
This commit also adds a test for invalid emoji when removing reaction.
2016-12-07 22:28:02 -08:00
Tomonori Murakami
a9e409a50f
admin: Do not allow removing or deactivating the last org admin.
...
Modified by tabbott to cover and test some additional cases.
Fixes #2396 .
2016-12-07 21:59:33 -08:00