zulip

Commit Graph

Author	SHA1	Message	Date
Anders Kaseorg	a50eb2e809	mypy: Enable new error explicit-override. Signed-off-by: Anders Kaseorg <anders@zulip.com>	2023-10-12 12:28:41 -07:00
Tim Abbott	8e7ce7cc79	python: Sort migrations/management command imports with isort. This is a preparatory commit for using isort for sorting all of our imports, merging changes to files where we can easily review the changes as something we're happy with. These are also files with relatively little active development, which means we don't expect much merge conflict risk from these changes.	2020-01-14 13:07:47 -08:00
Anders Kaseorg	2a2e744b27	management: Remove unused imports in management commands. Signed-off-by: Anders Kaseorg <andersk@mit.edu>	2019-02-02 17:12:36 -08:00
Aditya Bansal	d343f25cc6	create_realm_internal_bots: Refactor to extract main op as a function. We extract the entire operations of the management command to a function create_if_missing_realm_internal_bots in the zerver/lib/onboarding.py. The logic for determining if there are any realm internal bots which have not been created is extracted to a function missing_any_realm_internal_bots in actions.py.	2018-05-23 11:53:22 +05:30
Aditya Bansal	e8506b5020	zerver/management: Change use of typing.Text to str.	2018-05-10 14:19:49 -07:00
Greg Price	c80802ff1e	bots: Clean up create_realm_internal_bots. This code duplicated the code in setup_realm_internal_bots, with some added logic to avoid trying to create the same bot twice. That logic was buggy so that it would never work at all -- it subtracted a set of UserProfile objects from a set of email strings -- so it looked like the command might blow up when run after the users already existed. In fact, the buggy logic wasn't necessary, because the work the command does after it is idempotent -- in particular `create_users`, within its subroutine `bulk_create_users`, already filters out users that already exist. So just cut the buggy stuff out, deduplicate the rest with `setup_realm_internal_bots`, and document that invariant on the latter. While we're here, in the common case bail early without doing any per-realm work in Python, since we're running this on every upgrade.	2018-02-06 18:59:57 -08:00
Aditya Bansal	c770bdaa3a	reminder_bot: Add infra for adding reminder bot to every realm.	2018-01-19 11:33:11 -05:00

7 Commits