Anders Kaseorg
0b3cf78333
blueslip: Untangle from page_params.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-22 19:18:10 -07:00
Anders Kaseorg
f7eecb0e03
sentry: Untangle from page_params.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-22 18:53:56 -07:00
Anders Kaseorg
3db05666ac
state_data: Accept null for ProfileDatum["rendered_value"].
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-22 11:21:54 -07:00
Anders Kaseorg
ca5fba258e
giphy: Split is_giphy_enabled to a separate module.
...
This removes giphy from the critical path of the TypeScript migration.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-22 08:21:08 -07:00
Aman Agrawal
4d84ed305e
stream_color: Fix stream icon color not changing on theme change.
...
Changing theme didn't change the color of the stream icons.
2024-06-22 08:20:23 -07:00
N-Shar-ma
00240b6dbe
compose: Reduce space between recipient area and textbox.
2024-06-21 17:29:56 -07:00
N-Shar-ma
878d02cf5c
compose: Redesign control buttons row and textbox to look like 1 unit.
...
The row of buttons is placed using CSS grid template areas so that
visually it is now inside the bottom edge of the textbox. The color of
the buttons row and individual buttons is changed to match the color of
the textbox. All textbox border / box shadow properties are now applied
to its parent instead which is extended under the buttons' row, so that
its border snuggly fits around the buttons row too.
Notable side effects:
- In dark mode the textbox in focused state now has a light border which
does not match the recipient input's current border which doesn't change
when focused. Likely, the recipient input should be updated to match the
textbox's border color.
- The dividers in the formatting buttons row are not vertically centered
now. This should be figured out soon.
Fixes : #28702 .
2024-06-21 17:29:56 -07:00
Karl Stolley
ac002b358c
markdown: Improve alignment, spacing around horizontal rules.
2024-06-21 16:45:16 -07:00
Karl Stolley
7febb78b3b
markdown: Use interelement spacing on horizontal rules.
2024-06-21 16:45:16 -07:00
tnmkr
6b255fcc14
custom_profile_fields: Rename is_editable variable for clarity.
...
The variable is renamed to is_target_element_editable. This makes it
explicit that this variable is referring to HTML structure and not a
property of the field.
This is a prep commit for #22883 which allows admins to restrict users
from modifying field values.
2024-06-21 16:32:18 -07:00
tnmkr
9af71c690f
custom_profile_fields: Fix "required" field in OpenAPI documentation.
...
This is not an optional field and should be present in all API responses
of custom profile field object.
2024-06-21 16:32:15 -07:00
tnmkr
b6231f5568
zulip.yaml: Fix typo in IncludeCustomProfileFields description.
2024-06-21 16:32:15 -07:00
Anders Kaseorg
4ddc8f406d
onboarding_steps: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
72902d70f3
presence: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
438509a8f1
presence: Fix presence_last_update_id type.
...
It’s undefined for spectators.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
1a73101371
bot_data: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
bf8fc8429b
unread: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
9c2ab2842f
unread: Ignore deprecated sender_id synonym.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
ca99016f04
user_status: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
4b4ef75729
muted_users: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
8ce77cabae
user_topics: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
6bff8161ea
user_topics: Remove stream__name from user_topic_schema.
...
This field is internal to the backend and never escapes to the
frontend.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
97907b0a9c
pm_conversations: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
e28240a9ac
stream_data: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
9b511f5caa
sub_store: Fix ApiStreamSubscription["email_address"] type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
370a6c350e
local_message: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
788552b916
alert_words: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
1ee5c46a20
user_groups: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
41ec6c9b7c
user_groups: Fix UserGroupRaw["direct_subgroup_ids"] type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
d5cc7d7b79
emoji: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Karl Stolley
3a4719915c
compose: Let pill-container dictate spacing of pills.
...
The 2px and 6px values expressed as variables here are taken from
@terpimost's mocks in Figma.
2024-06-21 14:46:44 -07:00
Karl Stolley
0844e2cba9
pills: Size pill components and inputs in ems.
2024-06-21 14:46:44 -07:00
Anders Kaseorg
39d4ddaa96
stream_edit_subscribers: Rename misleading variable.
...
.safeParse does not return a “schema”.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 14:44:52 -07:00
Anders Kaseorg
15d4866856
stream_edit_subscribers: Fix incorrect error result test.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 14:44:52 -07:00
Alya Abbott
5413002b5f
squash: Alya's edits.
2024-06-21 13:41:39 -07:00
Lauryn Menard
73107c5de7
help-billing: Add information about international bank transfers.
2024-06-21 13:41:39 -07:00
Varun Singh
05a480f1d1
zcommand: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Varun Singh
87a9877a93
attachments_ui: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Varun Singh
f2c3207538
stream_topic_history_util: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Varun Singh
3d64fb6cda
message_edit_history: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Varun Singh
f553142c7c
settings_linkifiers: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Varun Singh
4186cac151
stream_edit_subscribers: Use `raw_data` & `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Kenneth Rodrigues
245332eef4
new conversation: Show correct tooltip when dms are disabled.
...
Earlier the `data-conversation-type` attribute of the new conversation
button was being set to `direct` only if dms were enabled. As a result a
stale tooltip was being shown when dms were disabled.
This commit updates the attribute to `direct` reagardless of dms being
enabled or not.
Fixes #29916 .
2024-06-21 11:21:37 -07:00
Karl Stolley
2820bd277f
pygments: Fully isolate light and dark themes.
...
Co-authored-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 11:15:34 -07:00
Karl Stolley
8936febbd3
pygments: Remove legacy Zulip customizations.
...
These styles were from before opting to work with themes maintained
by the Pygments project. Their removal will make it much easier to
upgrade Pygments themes in the future, and more importantly,
reduce the effort required to square syntax highlighting in the web
and mobile apps.
2024-06-21 11:15:34 -07:00
Varun Singh
80cf16a303
stream_edit_subscribers: Convert module to TypeScript.
2024-06-21 09:54:08 -07:00
Varun Singh
894cafe3c0
subscriber_api: Fix types of function parameters.
2024-06-21 09:54:08 -07:00
Varun Singh
5891a9ef24
subscriber_api: Don't return unused channel request objects.
2024-06-21 09:54:08 -07:00
Vector73
5230aada2b
python_examples: Validate error responses.
...
Adds assert statements to validate error response for "400" error code. The
current validation using `validate_against_openapi_schema` doesn't work for
"400" responses.
Adds separate functions to validate "200" and "400" responses and removes `validate_response_result`.
2024-06-21 09:49:07 -07:00
Anders Kaseorg
ce71e5ad8c
starred_messages: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 09:28:35 -07:00