52 Commits

Author	SHA1	Message	Date
Steve Howell	6b71f5bd5f	Inline most calls to set_rendered_content(). ... This is part of breaking the circular dependency on bugdown in models.py. A subsequent commit will fully kill off set_rendered_content().	2016-10-04 11:31:20 -07:00
Steve Howell	583a6bbadd	Extract zerver/lib/message.py. ... This pulls message-related code from models.py into a new module called message.py, and it starts to break some bugdown dependencies. All the methods here are basically related to serializing Message objects as dictionaries for caches and events. extract_message_dict stringify_message_dict message_to_dict message_to_dict_json MessageDict.to_dict_uncached MessageDict.to_dict_uncached_helper MessageDict.build_dict_from_raw_db_row MessageDict.build_message_dict This fix also removes a circular dependency related to get_avatar_url. Also, there was kind of a latent bug in Message.need_to_render_content where it was depending on other calls to Message to import bugdown and set it globally in the namespace. We really need to just eliminate the function, since it's so small and used by code that may be doing very sketchy things, but for now I just fix it. (The bug would possibly be exposed by moving build_message_dict out to the library.)	2016-10-04 11:31:20 -07:00