Brock Whittaker
4400665a6d
subs: Move stream settings into an independent overlay.
...
This replaces the scrolling stream settings feature with a stream
settings overlay.
2016-11-04 17:13:26 -07:00
Tim Abbott
78ec0341c4
subs: Fix color picker issue with subscribing.
2016-11-04 17:13:26 -07:00
Tim Abbott
73f020645f
subs: Remove unnecessary update_stream_color call.
...
The color was already being updated in the response from the server.
2016-11-04 16:37:29 -07:00
Tim Abbott
a70c5eb923
colorpicker: Migrate to use stream IDs to access things.
2016-11-04 16:37:29 -07:00
Tim Abbott
ab6fd87161
subs: Fix rename stream handling of email addresses.
2016-11-04 16:37:29 -07:00
Tim Abbott
e6734bfada
subs: Cleanup stream rename logic.
2016-11-04 16:37:29 -07:00
Tim Abbott
ee976a9bdc
subs: Use subscription_settings when changing descriptions.
2016-11-04 16:37:29 -07:00
Tim Abbott
45c7945818
subs: Use sub_settings in subscriber add/remove flow.
2016-11-04 16:37:29 -07:00
Tim Abbott
8e522cd933
subs: Convert stream_home_view_clicked to use sub_settings.
2016-11-04 16:37:29 -07:00
Tim Abbott
2467f765ad
subs: Stop using sub_row when rendering settings.
2016-11-04 16:37:29 -07:00
Tim Abbott
16408da823
subs: Cleanup change_stream_privacy.
...
We now:
(1) Only look up streams by ID
(2) Correctly look up both the stream-row and subscriptions_row after
the success handler returns.
2016-11-04 16:37:29 -07:00
Tim Abbott
32a571445a
subs: Use settings_for_sub when redrawing privacy stuff.
2016-11-04 16:37:29 -07:00
Tim Abbott
b67c0a4ad5
subs: Move settings_for_sub and button_for_sub earlier.
2016-11-04 16:37:28 -07:00
Tim Abbott
b1a5d57405
subs: Update get_subscriber_list to use subscription_setings.
2016-11-04 16:37:28 -07:00
Tim Abbott
109287dceb
subs: Update descriptions in settings separately from stream rows.
2016-11-04 16:37:11 -07:00
Tim Abbott
7a59ae591a
subs: Fix get_stream_name to use IDs from the DOM.
...
We haven't added a data-stream-name to the subscription_settings
object yet, and ideally we'd be moving away from using
data-stream-name anywhere.
2016-11-04 16:16:07 -07:00
Brock Whittaker
cc03d2014d
subs: Add missing li open/close tags.
...
Two elements were sharing the same li element, when they should be
in different elements.
2016-11-04 13:58:36 -07:00
Brock Whittaker
9b90a47fd6
Change .sub_settings_title to div.
...
All the properties they had weren’t being activated because they were
inline elements. Change to div to activate properties.
2016-11-04 13:55:11 -07:00
Brock Whittaker
7d51b6a454
subs: Create get_stream_name to get stream name from UI.
...
This accepts an arbitrary click target in the DOM inside a stream row
or stream settings element and returns the stream name.
2016-11-04 13:53:12 -07:00
Steve Howell
2088e8420f
User user_id, not email, in peer_add events.
2016-11-04 11:37:14 -07:00
Steve Howell
c5c3dfe33f
Add subscriber counts to changelog.md.
2016-11-04 11:37:14 -07:00
Steve Howell
17e39a88ef
Remove people.test_set_people_name_dict().
...
We use a cleaner approach to setting up test data in echo.js to
allow us to remove the one call to test_set_people_name_dict().
2016-11-04 11:37:14 -07:00
Steve Howell
8c47f7f7db
Remove people.test_set_people_dict().
2016-11-04 11:37:14 -07:00
Steve Howell
472f049cae
Alphabetize subscription event cases in server_events.js.
...
I also split up peer_add and peer_remove into their own cases,
since they do opposite things and didn't share that much code
in common.
2016-11-04 11:37:14 -07:00
Steve Howell
c3f2740481
Remove email_dict from gather_subscriptions_helper().
2016-11-04 11:37:14 -07:00
Steve Howell
38f2789152
Remove page_params.email_dict.
2016-11-04 11:37:14 -07:00
Steve Howell
3941334d00
Use user_ids for subscribers in stream_data.js.
...
We still shim a lot of methods to keep using emails, but the
internal data structure now has user_ids.
2016-11-04 11:37:12 -07:00
Steve Howell
7509f73f02
Clean up stream renaming in the JS code.
...
We now use stream_id as our key to rename streams, which
should prevent a few race conditions long term. (We are
still possibly contending with other events that use
stream_name as a key, so this is not perfect.)
2016-11-04 11:30:18 -07:00
Steve Howell
e1372ddf5d
Add people.get_user_id().
2016-11-04 11:30:18 -07:00
Steve Howell
4ace9bbd77
Remove dead code related to subs.create_sub().
...
Since we started handling the stream/create event properly,
create_sub() became dead code.
2016-11-04 11:30:18 -07:00
Steve Howell
2f4c7d2ef9
Clean up page_params initialization in node_tests/echo.js.
2016-11-04 11:30:18 -07:00
Steve Howell
4cd39010d1
Add people.get_person_from_user_id().
...
This requires the introduction of people_by_user_id_dict
and changes to people.add() and people.remove().
2016-11-04 11:30:18 -07:00
Steve Howell
a2874a3fe9
node tests: Simplify compiling of templates.
...
Now we just have two methods of importance:
compile_template
render_template
The compile_template() function will automatically
(and recursively) compile any partials it depends
on and mark those as compiled.
2016-11-04 11:23:11 -07:00
Steve Howell
0085164ad9
node tests: Avoid re-compiling templates.
...
This is a minor optimization to avoid re-compiling templates
that have already encountered.
2016-11-04 11:23:11 -07:00
Steve Howell
dd4a8eeebd
node tests: Extract render.find_included_partials().
2016-11-04 11:23:11 -07:00
Steve Howell
155f7881b2
node tests: Extact template_finder() class.
2016-11-04 11:23:11 -07:00
Steve Howell
61d88cfc13
node tests: Use template_dir() to walk templates.
2016-11-04 11:23:11 -07:00
Tim Abbott
945c2c4f86
docs: Add a brief release checklist.
2016-11-04 10:52:48 -07:00
Umair Khan
fe1ba6f3eb
Django 1.10: Deprecate request.REQUEST.
2016-11-04 10:20:24 -07:00
Umair Khan
dd314b3796
Django 1.10: context_processors have been moved to django.template.
2016-11-04 10:20:24 -07:00
Umair Khan
682aa1f298
Django 1.10: Use add_argument for options in BaseCommand.
2016-11-04 10:20:23 -07:00
Umair Khan
d3a4fa3e94
Django 1.10: Add Python Social Auth to Installed Apps.
2016-11-04 10:20:23 -07:00
Umair Khan
4c07e57b43
Django 1.10: Use lru_cache instead of memoize.
2016-11-04 10:20:23 -07:00
Umair Khan
b140236fcf
Django 1.10: Do not use patterns function.
2016-11-04 10:06:00 -07:00
Umair Khan
d81446805c
Django 1.10: Use `caches` object to access cache.
2016-11-04 10:06:00 -07:00
Umair Khan
b1d740afaa
Django 1.10: Remove generic module
2016-11-04 10:06:00 -07:00
Steve Howell
9b97b5da13
Improve test coverage for people.get_recipient_count().
2016-11-04 10:05:11 -07:00
Brock Whittaker
4c4733bcec
Change logo/type on left sidebar column.
...
This changes to a new logo/type on the left sidebar column.
2016-11-03 18:12:00 -07:00
Tim Abbott
cb1bc70ab0
css: Set only message overflow-x to auto.
...
This fixes a nasty problem where if you zoomed in Chrome, you'd get
little scrollbars on every message body.
2016-11-03 18:09:36 -07:00
umkay
c43a15ed18
api: Add default protocol for localhost.
...
Add default "http://" to site argument locally if it is not specified
in an api call.
This fixes a problem where if you didn't manually specify `http://`
when connecting to a development server, the API bindings would hang
trying to connect using HTTPS.
2016-11-03 18:09:26 -07:00