zulip

Commit Graph

Author	SHA1	Message	Date
Steve Howell	c61c0f3edc	Use user_profile, not email, in check_message(). We are trying to convert emails to user_profiles earlier in the codepath. This may cause subtle changes in which errors appear, but it's probably generally good to report on bad addressees sooner than later.	2017-08-22 10:42:15 -07:00
Steve Howell	c56a631b65	Move user_profiles_from_unvalidated_emails -> addressee.py. This will avoid circular dependencies.	2017-08-22 10:42:15 -07:00
Steve Howell	30d37d1270	Add Addressee class. This class simplifies the calling sequence to methods like check_message and _internal_prep_message, and it's also more type safe. Checking for message types is encapsulated with calls to is_stream() and is_private(). There are also shortcut constructors when you know that the type of the address (stream vs. private), which is often.	2017-08-22 10:42:15 -07:00

Author

SHA1

Message

Date

Steve Howell

c61c0f3edc

Use user_profile, not email, in check_message().

We are trying to convert emails to user_profiles earlier in
the codepath.  This may cause subtle changes in which errors
appear, but it's probably generally good to report on bad
addressees sooner than later.

2017-08-22 10:42:15 -07:00

Steve Howell

c56a631b65

Move user_profiles_from_unvalidated_emails -> addressee.py.

This will avoid circular dependencies.

2017-08-22 10:42:15 -07:00

Steve Howell

30d37d1270

Add Addressee class.

This class simplifies the calling sequence to methods like
check_message and _internal_prep_message, and it's also more
type safe.

Checking for message types is encapsulated with calls to is_stream()
and is_private().  There are also shortcut constructors when you
know that the type of the address (stream vs. private), which is often.

2017-08-22 10:42:15 -07:00

1 2

53 Commits