552f4e3d22
eslint: Fix unicorn/no-array-for-each.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-01-25 14:53:19 -08:00
d72f7d1d69
eslint: Fix unicorn/prefer-number-properties.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v24.0.0/docs/rules/prefer-number-properties.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-22 16:14:28 -08:00
e68595a3fc
eslint: Fix unicorn/no-reduce.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-reduce.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
de791b82b6
eslint: Fix unicorn/no-for-loop.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-for-loop.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
70a0260ac1
eslint: Fix unicorn/prefer-text-content.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-text-content.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
bd05f1c9f8
eslint: Fix unicorn/prefer-query-selector.
...
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prefer-query-selector.md
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 16:00:33 -07:00
4e6c0989db
stats: Fix a string not tagged for translation.
...
Part of #16094 .
2020-09-25 16:20:53 -07:00
dedb28055a
stats: Fix a few strings not tagged for translation.
2020-08-10 16:26:37 -07:00
6ec808b8df
js: Add "use strict" directive to CommonJS files.
...
ES and TypeScript modules are strict by default and don’t need this
directive. ESLint will remind us to add it to new CommonJS files and
remove it from ES and TypeScript modules.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-31 22:09:46 -07:00
584d6bfa41
stats: Use Plotly.js as a module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-28 10:54:35 -07:00
96dcc0ce6e
js: Use ES6 object literal shorthand syntax.
...
Generated by ESLint.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-21 12:42:22 -07:00
4e42137bd9
js: Replace deprecated jQuery event handler shorthand.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-21 12:01:26 -07:00
97feea42a1
js: Replace deprecated jQuery.fn.hover.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-21 12:01:26 -07:00
b65d2e063d
js: Reformat with Prettier.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-17 14:31:25 -07:00
883e2fd325
js: Remove inner spacing from object literals.
...
We’re configuring Prettier with bracketSpacing: false. Generated by
ESLint.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-17 14:31:25 -07:00
f3726db89a
js: Normalize strings to double quotes.
...
Prettier would do this anyway, but it’s separated out for a more
reviewable diff. Generated by ESLint.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-17 14:31:24 -07:00
e014ea966a
eslint: Enable comma-dangle for functions.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-03 16:55:51 -07:00
a79322bc94
eslint: Enable prefer-arrow-callback.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-03 16:55:50 -07:00
0c6488b284
analytics: Added frontend for messages read over time graph.
...
The chart added is similar to the messages sent over time chart.
Fixes #15167
2020-06-20 16:52:33 -07:00
62fcf98b6f
js: Use hasOwnProperty correctly or not at all.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-26 23:33:40 -07:00
eee784312d
stats: Fix Other calculation.
...
In commit 2248d4d9a4#13883 ) I
incorrectly migrated a loop. Fixes #14052 .
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-03-02 17:45:44 -08:00
6f32ef749f
js: Convert $.extend to spread syntax.
...
This is not always a behavior-preserving translation: $.extend mutates
its first argument. However, the code does not always appear to have
been written to expect that.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-25 14:09:39 -08:00
2248d4d9a4
stats: Convert data from object to Map.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-12 10:39:01 -08:00
59d55d1e06
js: Use modern spread arguments syntax.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-11 17:43:35 -08:00
e2c563d14d
minor: Replace Math.min() with Infinity for easier to read code.
2019-12-06 11:27:58 -08:00
28f3dfa284
js: Automatically convert var to let and const in most files.
...
This commit was originally automatically generated using `tools/lint
--only=eslint --fix`. It was then modified by tabbott to contain only
changes to a set of files that are unlikely to result in significant
merge conflicts with any open pull request, excluding about 20 files.
His plan is to merge the remaining changes with more precise care,
potentially involving merging parts of conflicting pull requests
before running the `eslint --fix` operation.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-03 12:42:39 -08:00
7ae84d5ce1
js: Break lines that become too long after converting var to const.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-10-28 15:02:43 -07:00
46e562f990
bootstrap: Change tooltip html default to false.
...
Bootstrap v2.2.0^2~40^2~6 changes this default to false, so this is a
prerequisite to upgrading Bootstrap, and it’s also safer.
This closes an HTML injection path via user full names in the emoji
reaction tooltip. It doesn’t appear to be exploitable for cross-site
scripting because we disallow `>` in full names, and the code happens
to be written such that the next `>` is in a different parser
invocation.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-09-19 20:53:10 -07:00
150d9c9d3e
stats: Fix the bug in showing all time actives by default.
...
Followup commit of 0b1e36db27
2019-02-01 11:14:03 -08:00
5fec84221e
stats: Make all time active users graph default.
...
We now bill by total users, whereas we used to
bill by 15 day actives.
2019-01-26 12:19:59 -08:00
478674a6d6
analytics: Refactor to support more than one tooltip on same page.
...
While we don't actually need another tooltip on /stats right now, this
provides a clear approach for how to do that. We've since added
tooltips in various other parts of the webapp, and that code is pretty
copy-pasteable, so I think it's reasonable to say this closes #4612 .
Cleaned up by tabbott to remove a bunch of unnecessary changes.
2018-11-28 16:04:35 -08:00
80a2d5bc59
eslint: Enable `conditionalAssign` config of no-trailing-spaces rule.
2018-06-11 07:51:24 -04:00
cc03f9fb8f
eslint: Enable space-infix-ops rule.
...
More about rule at https://eslint.org/docs/rules/space-infix-ops
2018-06-05 00:47:35 +05:30
562f5387e3
analytics: Add "last 2 months" and "last 6 months" button.
...
This commit removes "last 30 months" button and includes some layout changes so as to accomodate rangeslider with extra introduced buttons.
2018-06-01 12:07:18 -07:00
0f55b56398
analytics: Add a rangeslider to the "number of users" plot.
...
This also requires some layout/spacing changes, since the rangeslider
takes up some space.
Fixes : #9557 .
2018-06-01 08:51:53 -07:00
d28a4d1f86
stats: Remove hour from on-hover date for Number of users.
2018-05-26 12:08:05 -07:00
2b97a9488f
stats: Fix on-hover behavior of number of users.
...
Fixes regression introduced in fa9d79e
2018-05-26 12:08:05 -07:00
fa9d79e203
stats: Add 1 day actives and total users to number of users chart.
2018-05-20 10:56:16 -07:00
5ddc6c21e9
stats: Clean up line spacing in populate_number_of_users in stats.js.
...
We use this compressed form in our other layout definitions. Makes it easier
to visually digest.
2018-05-20 10:56:16 -07:00
0ba5c9c07d
lint: Fix extra long lines in stats.js.
...
I'm not sure why this wasn't reported in CI.
2018-05-18 15:44:30 -07:00
2fe3fba6ce
stats: Rename data.realm to data.everyone.
...
We use "Everyone" for the button labels already.
Soon we'll support "Everyone" meaning either the installation or the realm,
depending on the URL route used to access the stats.
2018-05-18 15:12:36 -07:00
e099959a41
stats: Move API route computation from frontend to backend.
...
Will make it easier to extend to additional routes.
No changes in behavior.
2018-05-18 15:12:36 -07:00
645e2720b6
stats: Move get_chart_data calls to bottom of stats.js.
2018-05-18 15:12:36 -07:00
063d11b139
js: Standardize indentation of switch/case statements.
...
This gets my current draft eslint indentation configuration passing
cleaning on static/js.
2018-05-06 19:35:18 -07:00
b26c38bc47
analytics: Make stats of all realms accessible to server admins.
...
In this commit:
Two new URLs are added, to make all realms accessible for server
admins. One is for the stats page itself and another for getting
chart data i.e. chart data API requests.
For the above two new URLs corresponding two view functions are
added.
2018-04-18 11:06:50 -07:00
e78158bcc3
activity: Refactor code for getting chart data.
...
This simply refactored the repetitive code for getting stats chart
data.
(commit message tweaked by shubhamdhama)
2018-04-17 17:58:01 -07:00
65c4a43a82
lint: Fix errors with stats.js with new eslint.
...
This (for ... in) syntax we shouldn't be using anyway, but this at
least fixes the worst aspect of it.
2018-04-06 12:42:19 -07:00
10149b75cc
stats: Add per-graph loading indicator
...
This commit ensures that size of each graph is the same before and
after the data is loaded. It also adds a loading indicator to each
graph until the data is loaded.
Fixes https://github.com/zulip/zulip/issues/6490
2017-12-13 14:44:28 -06:00
2bc14d256f
lint: Ban two spaces after comma in JS code.
...
We exclude the frontend tests, mostly because the lint rule isn't that
precise, and the test code has some sample user input that's a bit
funny.
2017-10-18 10:22:18 -07:00
ad5bc4b06c
js: Use shorthand $() instead of $(document).ready().
2017-10-05 10:10:37 -07:00
Anders Kaseorg
Abhijeet Prasad Bodas
Tim Abbott
arpit551
Anders Kaseorg
Rohitt Vashishtha
Vishnu Ks
Nikhil Kumar Mishra
Shubham Dhama
Anupam Dagar
Rishi Gupta
Tim Abbott
Greg Price
Utkarsh Patil
derAnfaenger