zulip

Commit Graph

Author	SHA1	Message	Date
Anders Kaseorg	392175d6e8	Use #!/usr/bin/env for bash shebangs. /bin/sh and /usr/bin/env are the only two binaries that NixOS provides at a fixed path (outside a buildFHSUserEnv sandbox). This discussion was split from #11004. Signed-off-by: Anders Kaseorg <andersk@mit.edu>	2018-12-17 17:21:08 -08:00
Anders Kaseorg	c4ed4bc021	test-install: Fix shellcheck warnings. In tools/test-install/destroy-all line 31: \| while read c ^-- SC2162: read without -r will mangle backslashes. In tools/test-install/install line 57: installer_dir="$(readlink -f $INSTALLER)" ^-- SC2086: Double quote to prevent globbing and word splitting. In tools/test-install/lxc-wait line 30: for i in {1..60}; do ^-- SC2034: i appears unused. Verify use (or export if used externally). Signed-off-by: Anders Kaseorg <andersk@mit.edu>	2018-08-03 09:15:27 -07:00
Greg Price	4c5326ce85	test-install: Factor out booted-yet-p polling loop, use in prepare-base. Otherwise prepare-base is likely to fail when first run (but then succeed when rerun, because the container is left running), because the container isn't up yet when we try to operate in it. Also clean up the placement of `set -e` vs `set -x`.	2018-02-08 16:34:49 -08:00

Author

SHA1

Message

Date

Anders Kaseorg

392175d6e8

Use #!/usr/bin/env for bash shebangs.

/bin/sh and /usr/bin/env are the only two binaries that NixOS provides
at a fixed path (outside a buildFHSUserEnv sandbox).

This discussion was split from #11004.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

2018-12-17 17:21:08 -08:00

Anders Kaseorg

c4ed4bc021

test-install: Fix shellcheck warnings.

In tools/test-install/destroy-all line 31:
  | while read c
          ^-- SC2162: read without -r will mangle backslashes.

In tools/test-install/install line 57:
    installer_dir="$(readlink -f $INSTALLER)"
                                 ^-- SC2086: Double quote to prevent globbing and word splitting.

In tools/test-install/lxc-wait line 30:
for i in {1..60}; do
^-- SC2034: i appears unused. Verify use (or export if used externally).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

2018-08-03 09:15:27 -07:00

Greg Price

4c5326ce85

test-install: Factor out booted-yet-p polling loop, use in prepare-base.

Otherwise prepare-base is likely to fail when first run (but then
succeed when rerun, because the container is left running), because
the container isn't up yet when we try to operate in it.

Also clean up the placement of `set -e` vs `set -x`.

2018-02-08 16:34:49 -08:00

3 Commits