This commit adds `durable=True` to the short independent db transaction
in `UserGroupRaceConditionTestCase.tearDown` method.
This is as a part of our plan to explicitly mark all the
transaction.atomic calls with either 'savepoint=False' or
'durable=True' as required.
It helps to avoid creating unintended savepoints in the future.
This is as a part of our plan to explicitly mark all the
transaction.atomic calls with either 'savepoint=False' or
'durable=True' as required.
This commit removes the 'email_token' field from the
'Stream' model, introduces a new model 'ChannelEmailAddress',
and backfills it.
This is a prep work towards our plan to generate unique
channel emails for different users, which can be used
to check post permissions at message send time.
Apparently `.data("category")` would be come back as a single-element
array for some French translations, rather than a string.
We fix this by using `.attr("data-category")` across this file, which
is our preferred coding pattern anyway.
- Removed the extra screenshot.
- Updated the fixture used to generate the screenshot to use a more
suitable topic name and commit message description.
For cases where a customer is created in Stripe first for the manual
invoice, we want to connect that customer information to our Customer
object in the database. That way the customer can access the billing
page once the invoice is paid.
This commit removes the `button-secondary`, `button-group` and
`bootstrap-btn-group` classes which don't have any corresponding styles
attached to them or are no longer in use in the codebase.
Since pressing `escape` key closes flatpickr and settings overlay
at the same time, we need to wait for the settings to be not
visible.
If we don't wait for the settings overlay to close, the next test
could think the settings overlay is already open and continue with
its tests which can easily become flaky.
This commit removes the final vestiges of `bootstrap-btn.css` from
portico, allowing us to move `bootstrap-btn.css` from `common.ts` bundle
to just `app.ts` bundle.
This commit includes the following changes:
- While inviting users for guest roles, we display an
empty channel list rather than the default channel list
and the default channels checkbox is unselected.
- While inviting users for non-guest roles we continue
to select the default channels checkbox.
- When switching between guest and non-guest roles, the
previous state of included channels for the guest role
is restored while inviting a user as a guest.
Fixes: #31988.
Co-authored-by: Aditya <113302312+userAdityaa@users.noreply.github.com>
Removed `invite_to_realm_policy` property, as the permission
to invite other users to the organization is now controlled by
`can_invite_users_group` setting.
This commit removes the final vestiges of `bootstrap-btn-default` class
from the codebase, by moving the relevant styles from the
`bootstrap-btn` and `bootstrap-btn-default` classes to the
`button-recent-filters` class.
Our user type field utilizes the contenteditable div which isn't a
labelable element, so clicking on its label doesn't do anything. Add
an event listener so that clicking on the label will focus on the input.
The cursor will always be placed at the start of the input if the field
is accessed in this way. This is the browser's default behavior.
Fixes part of #21769.
Flatpickr isn't a native input element, so clicking on its label
doesn't do anything. Add an event listener so that clicking on the
label will open the date picker.
Fixes part of #21769.
There is an case of flakiness in the test where we attempt to click on
an input field before it's even visible. Make sure the input field is
visible before attempting to click on it.
Prakhar Pratyush
Anders Kaseorg
Tim Abbott
Sahil Batra
Niloth P
Lauryn Menard
Sayam Samal
Aman Agrawal
Saubhagya Patel
Vector73
Karl Stolley
evykassirer
joseph