Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

compose: Remove "Drafts" button. 

Now that this is in the left sidebar, we can remove the now-redundant
compose area button for it.  This also changes where the "Saved as
draft" tooltip appears.
This commit is contained in:
Wesley Aptekar-Cassels 2021-07-04 15:06:50 -07:00 committed by Tim Abbott
parent df8f0b2afe
commit fe89dee284
3 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/puppeteer_tests/drafts.ts
View File

@ -20,7 +20,7 @@ async function get_drafts_count(page: Page): Promise<number> {
return await page.$$eval(".draft-row", (drafts) => drafts.length); return await page.$$eval(".draft-row", (drafts) => drafts.length);
} }
const drafts_button = ".compose_drafts_button"; const drafts_button = ".top_left_drafts";
const drafts_overlay = "#draft_overlay"; const drafts_overlay = "#draft_overlay";
const drafts_button_in_compose = "#below-compose-content .drafts-link"; const drafts_button_in_compose = "#below-compose-content .drafts-link";

7
static/js/drafts.js
View File

@ -26,9 +26,6 @@ import * as ui_util from "./ui_util";
import * as util from "./util"; import * as util from "./util";
function set_count(count) { function set_count(count) {
const draft_count = count.toString();
const text = $t({defaultMessage: "Drafts ({draft_count})"}, {draft_count});
$(".compose_drafts_button").text(text);
const drafts_li = $(".top_left_drafts"); const drafts_li = $(".top_left_drafts");
ui_util.update_unread_count_in_dom(drafts_li, count); ui_util.update_unread_count_in_dom(drafts_li, count);
} }
@ -147,10 +144,10 @@ export function restore_message(draft) {
function draft_notify() { function draft_notify() {
// Display a tooltip to notify the user about the saved draft. // Display a tooltip to notify the user about the saved draft.
const instance = tippy(".compose_drafts_button", { const instance = tippy(".top_left_drafts .unread_count", {
content: $t({defaultMessage: "Saved as draft"}), content: $t({defaultMessage: "Saved as draft"}),
arrow: true, arrow: true,
placement: "top", placement: "right",
})[0]; })[0];
instance.show(); instance.show();
function remove_instance() { function remove_instance() {

5
static/templates/compose.hbs
View File

@ -36,11 +36,6 @@
{{t 'Log in to send messages' }} {{t 'Log in to send messages' }}
</a> </a>
</span> </span>
<span class="new_message_button hidden-for-spectators">
<a class="drafts-link no-underline button small rounded compose_drafts_button" href="#drafts" title="{{t 'Drafts' }} (d)">
{{t 'Drafts' }}
</a>
</span>
</div> </div>
</div> </div>
<div class="message_comp"> <div class="message_comp">