From fda471ab80e0c116a420eafb4904837d91e78218 Mon Sep 17 00:00:00 2001
From: Sahil Batra <sahil@zulip.com>
Date: Sat, 24 Sep 2022 16:10:36 +0530
Subject: [PATCH] settings: Italicize text inside parens for presence_enabled
 setting.

---
 static/js/settings.js                                          | 3 ++-
 static/js/settings_config.ts                                   | 3 ++-
 static/templates/settings/account_settings.hbs                 | 1 +
 .../templates/settings/organization_user_settings_defaults.hbs | 1 +
 tools/lib/capitalization.py                                    | 2 ++
 5 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/static/js/settings.js b/static/js/settings.js
index fd28ba1ec2..dfe4345c17 100644
--- a/static/js/settings.js
+++ b/static/js/settings.js
@@ -45,8 +45,9 @@ function setup_settings_label() {
     settings_label = {
         // settings_notification
         presence_enabled: $t({
-            defaultMessage: "Display my availability to other users (invisible mode off)",
+            defaultMessage: "Display my availability to other users",
         }),
+        presence_enabled_parens_text: $t({defaultMessage: "invisible mode off"}),
         send_stream_typing_notifications: $t({
             defaultMessage: "Let subscribers see when I'm typing messages in streams",
         }),
diff --git a/static/js/settings_config.ts b/static/js/settings_config.ts
index 3abc3da7f6..548b1caedf 100644
--- a/static/js/settings_config.ts
+++ b/static/js/settings_config.ts
@@ -535,8 +535,9 @@ export const realm_user_settings_defaults_labels = {
     enable_digest_emails: $t({defaultMessage: "Send digest emails when user is away"}),
 
     realm_presence_enabled: $t({
-        defaultMessage: "Display availability to other users (invisible mode off)",
+        defaultMessage: "Display availability to other users",
     }),
+    realm_presence_enabled_parens_text: $t({defaultMessage: "invisible mode off"}),
     realm_enter_sends: $t({defaultMessage: "Enter sends when composing a message"}),
     realm_send_read_receipts: $t({defaultMessage: "Allow other users to view read receipts"}),
 };
diff --git a/static/templates/settings/account_settings.hbs b/static/templates/settings/account_settings.hbs
index 1ec3b2ddcf..0f44e29233 100644
--- a/static/templates/settings/account_settings.hbs
+++ b/static/templates/settings/account_settings.hbs
@@ -71,6 +71,7 @@
                   setting_name="presence_enabled"
                   is_checked=settings_object.presence_enabled
                   label=settings_label.presence_enabled
+                  label_parens_text=settings_label.presence_enabled_parens_text
                   help_link="/help/status-and-availability"
                   prefix="user_"}}
             </div>
diff --git a/static/templates/settings/organization_user_settings_defaults.hbs b/static/templates/settings/organization_user_settings_defaults.hbs
index ceb70a09a1..db44206572 100644
--- a/static/templates/settings/organization_user_settings_defaults.hbs
+++ b/static/templates/settings/organization_user_settings_defaults.hbs
@@ -19,6 +19,7 @@
           setting_name="presence_enabled"
           is_checked=settings_object.presence_enabled
           label=settings_label.realm_presence_enabled
+          label_parens_text=settings_label.realm_presence_enabled_parens_text
           help_link="/help/status-and-availability"
           prefix="realm_"}}
         {{> settings_checkbox
diff --git a/tools/lib/capitalization.py b/tools/lib/capitalization.py
index 19bd982a64..6858ce1f26 100644
--- a/tools/lib/capitalization.py
+++ b/tools/lib/capitalization.py
@@ -111,6 +111,8 @@ IGNORED_PHRASES = [
     r"to add a new line",
     # Used in showing Notification Bot read receipts message
     "Notification Bot",
+    # Used in presence_enabled setting label
+    r"invisible mode off",
 ]
 
 # Sort regexes in descending order of their lengths. As a result, the