Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

emoji: Use individual images for fallback emoji instead of spritesheet.

This commit is contained in:
evykassirer 2023-11-29 14:33:54 -08:00 committed by Tim Abbott
parent 63618e93f0
commit fd57a9033b
1 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tools/setup/emoji/build_emoji
View File

@ -76,11 +76,11 @@ EMOJI_POS_INFO_TEMPLATE = """\
}} }}
""" """
EMOJI_POS_INFO_OVERRIDE_TEMPLATE = """\ EMOJI_OVERRIDE_TEMPLATE = """\
.emoji-{codepoint} {{ .emoji-{codepoint} {{
background-image: url(~emoji-datasource-google/img/google/sheets-256/64.png) !important; background-image: url(../../../static/generated/emoji/images-google-64/{codepoint}.png) !important;
background-size: {background_size} !important; background-position: 0% 0% !important;
background-position: {pos_x} {pos_y}; background-size: contain !important;
}} }}
""" """
@ -238,19 +238,14 @@ def generate_sprite_css_files(
# fallback to Google Modern for any emoji not covered by Google Classic. # fallback to Google Modern for any emoji not covered by Google Classic.
if emojiset == "google-blob": if emojiset == "google-blob":
extra_emoji_positions = "" extra_emoji_positions = ""
n = get_square_size(fallback_emoji_data)
background_size = percent(n)
covered_emoji_codes = [ covered_emoji_codes = [
get_emoji_code(emoji) for emoji in emoji_data if emoji["has_img_google"] get_emoji_code(emoji) for emoji in emoji_data if emoji["has_img_google"]
] ]
for emoji in fallback_emoji_data: for emoji in fallback_emoji_data:
code = get_emoji_code(emoji) code = get_emoji_code(emoji)
if emoji["has_img_google"] and code not in covered_emoji_codes: if emoji["has_img_google"] and code not in covered_emoji_codes:
extra_emoji_positions += EMOJI_POS_INFO_OVERRIDE_TEMPLATE.format( extra_emoji_positions += EMOJI_OVERRIDE_TEMPLATE.format(
codepoint=code, codepoint=code,
pos_x=percent(emoji["sheet_x"] / (n - 1)),
pos_y=percent(emoji["sheet_y"] / (n - 1)),
background_size=background_size,
) )
with open(SPRITE_CSS_PATH, "a") as f: with open(SPRITE_CSS_PATH, "a") as f:
f.write(extra_emoji_positions) f.write(extra_emoji_positions)
@ -270,11 +265,8 @@ def generate_sprite_css_files(
for emoji in emoji_data: for emoji in emoji_data:
code = get_emoji_code(emoji) code = get_emoji_code(emoji)
if emoji["has_img_google"] and code not in twitter_covered_emoji_codes: if emoji["has_img_google"] and code not in twitter_covered_emoji_codes:
extra_emoji_positions += EMOJI_POS_INFO_OVERRIDE_TEMPLATE.format( extra_emoji_positions += EMOJI_OVERRIDE_TEMPLATE.format(
codepoint=code, codepoint=code,
pos_x=percent(emoji["sheet_x"] / (n - 1)),
pos_y=percent(emoji["sheet_y"] / (n - 1)),
background_size=background_size,
) )
with open(SPRITE_CSS_PATH, "a") as f: with open(SPRITE_CSS_PATH, "a") as f:
f.write(extra_emoji_positions) f.write(extra_emoji_positions)