Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

search pills: Add space before the colon and remove +. 

The + is HTML-encoding of the search operator for submission to the
server, and shouldn't appear visibly to users.
This commit is contained in:
evykassirer 2024-05-23 14:06:21 -07:00 committed by Tim Abbott
parent 11bb44c7cc
commit fc95987b8d
2 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
web/src/input_pill.ts
View File

@ -168,8 +168,25 @@ export function create<T>(opts: InputPillCreateOptions<T>): InputPillContainer<T
} else {
const has_image = item.img_src !== undefined;
let display_value = item.display_value;
// For search pills, we don't need to use + instead
// of spaces in the pill, since there is visual separation
// of pills. We also chose to add a space after the colon
// after the search operator.
//
// TODO: Ideally this code would live in search files, when
// we generate `item.display_value`, but we currently use
// `display_value` not only for visual representation but
// also for parsing the value a pill represents.
// In the future we should change all input pills to have
// a `value` as well as a `display_value`.
if (item.type === "search") {
display_value = display_value.replaceAll("+", " ");
display_value = display_value.replace(":", ": ");
}
const opts: InputPillRenderingDetails = {
display_value: item.display_value,
display_value,
has_image,
deactivated: item.deactivated,
should_add_guest_user_indicator: item.should_add_guest_user_indicator,

2
web/tests/search.test.js
View File

@ -249,7 +249,7 @@ run_test("initialize", ({override, override_rewire, mock_template}) => {
operand: "Verona",
},
];
expected_pill_display_value = "channel:Verona";
expected_pill_display_value = "channel: Verona";
_setup(terms);
input_pill_displayed = false;
mock_pill_removes(search.search_pill_widget);