Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

templates: Move page_params to a <div> at the bottom of <body>. 

In a gigantic realm where we send several MB of `page_params`, it’s
slightly better to have the rest of the `<body>` available to the
browser earlier, so it can show the “Loading…” spinner and start
fetching subresources.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg 2019-09-18 17:47:12 -07:00 committed by Tim Abbott
parent 935702b6ec
commit fbc2de157e
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
static/js/page_params.js
View File

@ -1,2 +1 @@
window.page_params = $(document.body).data("params");
$(document.body).removeAttr("data-params");
window.page_params = $("#page-params").remove().data("params");

6
templates/zerver/base.html
View File

@ -41,11 +41,11 @@
{% endblock %}
</head>
<body {% if night_mode %}class="night-mode"{% endif %}
data-params='{{ page_params|default({"debug_mode": false})|tojson }}'
>
<body {% if night_mode %}class="night-mode"{% endif %}>
{% block content %}
{% endblock %}
<div hidden id="page-params" data-params='{{ page_params|default({"debug_mode": false})|tojson }}'></div>
</body>
</html>

3
zerver/tests/test_home.py
View File

@ -354,7 +354,8 @@ class HomeTest(ZulipTestCase):
def _get_page_params(self, result: HttpResponse) -> Dict[str, Any]:
doc = lxml.html.document_fromstring(result.content)
page_params_json = doc.find("body").get("data-params")
[div] = doc.xpath("//div[@id='page-params']")
page_params_json = div.get("data-params")
page_params = ujson.loads(page_params_json)
return page_params