eslint: Fix @typescript-eslint/no-duplicate-type-constituents.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

web/src/blueslip.ts

@@ -85,7 +85,7 @@ export function warn(msg: string, more_info?: unknown): void {
     }
 }
 
-export function error(msg: string, more_info?: object | undefined, original_error?: unknown): void {
+export function error(msg: string, more_info?: object, original_error?: unknown): void {
     // Log the Sentry error before the console warning, so we don't
     // end up with a doubled message in the Sentry logs.
     Sentry.setContext("more_info", more_info ?? null);

web/src/blueslip_stacktrace.ts

@@ -8,7 +8,7 @@ import render_blueslip_stacktrace from "../templates/blueslip_stacktrace.hbs";
 export class BlueslipError extends Error {
     override name = "BlueslipError";
     more_info?: object;
-    constructor(msg: string, more_info?: object | undefined, cause?: unknown) {
+    constructor(msg: string, more_info?: object, cause?: unknown) {
         super(msg, {cause});
         if (more_info !== undefined) {
             this.more_info = more_info;

web/src/email_pill.ts

@@ -45,7 +45,7 @@ export function get_current_email(
 
 export function create_pills(
     $pill_container: JQuery,
-    pill_config?: InputPillConfig | undefined,
+    pill_config?: InputPillConfig,
 ): input_pill.InputPillContainer<EmailPill> {
     const pill_container = input_pill.create({
         $container: $pill_container,

web/src/emoji_picker.ts

@@ -711,7 +711,7 @@ function get_default_emoji_popover_options(): Partial<tippy.Props> {
 
 export function toggle_emoji_popover(
     target: tippy.ReferenceElement,
-    id?: number | undefined,
+    id?: number,
     additional_popover_options?: Partial<tippy.Props>,
 ): void {
     if (id) {

web/src/input_pill.ts

@@ -25,7 +25,7 @@ type InputPillCreateOptions<ItemType> = {
     create_item_from_text: (
         text: string,
         existing_items: ItemType[],
-        pill_config?: InputPillConfig | undefined,
+        pill_config?: InputPillConfig,
     ) => ItemType | undefined;
     get_text_from_item: (item: ItemType) => string;
     get_display_value_from_item: (item: ItemType) => string;

web/src/user_pill.ts

@@ -38,7 +38,7 @@ export type UserPillData = {type: "user"; user: User};
 export function create_item_from_email(
     email: string,
     current_items: CombinedPill[],
-    pill_config?: InputPillConfig | undefined,
+    pill_config?: InputPillConfig,
 ): UserPill | undefined {
     // For normal Zulip use, we need to validate the email for our realm.
     const user = people.get_by_email(email);
@@ -217,7 +217,7 @@ export function generate_pill_html(item: UserPill, show_user_status_emoji = fals
 
 export function create_pills(
     $pill_container: JQuery,
-    pill_config?: InputPillConfig | undefined,
+    pill_config?: InputPillConfig,
 ): input_pill.InputPillContainer<UserPill> {
     const pills = input_pill.create({
         $container: $pill_container,