Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

unread: Remove the TODO statement with an explanation.

This commit is contained in:
Aman Agrawal 2023-09-14 07:21:46 +00:00 committed by Tim Abbott
parent 5737c558cb
commit fa4f9c7eff
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
web/src/unread.js
View File

@ -283,12 +283,20 @@ class UnreadTopicCounter {
stream_count += topic_count;
}
// TODO: These don't agree with the else clause in how
// they handle muted streams/topics, and that's
// probably a bug.
// Note: The format of res.stream_count is completely
// different from the else clause; with objects
// containing data for individual topics rather than
// just muted/unmuted totals, and all muted
// streams/topics included so that the inbox view can
// easily show/hide topics when its filters are
// adjusted. This should be refactored before the
// TypeScript migration for this file.
res.stream_count.set(stream_id, topic_unread);
res.stream_unread_messages += stream_count;
} else {
// get_stream_count calculates both the number of
// unmuted unread as well as the number of muted
// unreads.
res.stream_count.set(stream_id, this.get_stream_count(stream_id));
res.stream_unread_messages += res.stream_count.get(stream_id).unmuted_count;
}