Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Drop email column on narrow screens. 

Since we access email through pills,to improve the
visibility on a narrow screen, if the screen width
goes below 'lg_min' or 992px drop the email column from users,
deactivated users, bots, channels, groups using a new classname
'settings-email-column'.
This commit is contained in:
sujal shah 2024-06-14 21:02:19 +05:30 committed by Tim Abbott
parent b5e215824b
commit fa16f7720f
11 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/styles/settings.css
View File

@ -1759,6 +1759,10 @@ $option_title_width: 180px;
}
@media (width < $lg_min) {
.settings-email-column {
display: none;
}
.upload-size {
display: none;
}

2
web/templates/settings/active_user_list_admin.hbs
View File

@ -13,7 +13,7 @@
<table class="table table-striped wrapped-table">
<thead class="table-sticky-headers">
<th class="active" data-sort="alphabetic" data-sort-prop="full_name">{{t "Name" }}</th>
<th data-sort="email">{{t "Email" }}</th>
<th class="settings-email-column" data-sort="email">{{t "Email" }}</th>
<th class="user_role" data-sort="role">{{t "Role" }}</th>
<th class="last_active" data-sort="last_active">{{t "Last active" }}</th>
{{#if is_admin}}

4
web/templates/settings/admin_user_list.hbs
View File

@ -3,11 +3,11 @@
{{> ../user_display_only_pill display_value=full_name user_id=user_id img_src=img_src}}
</td>
{{#if display_email}}
<td class="email">
<td class="email settings-email-column">
<span class="email">{{display_email}}</span>
</td>
{{else}}
<td class="email">
<td class="email settings-email-column">
<span class="hidden-email">{{t "(hidden)"}}</span>
</td>
{{/if}}

2
web/templates/settings/bot_list_admin.hbs
View File

@ -28,7 +28,7 @@
<table class="table table-striped wrapped-table">
<thead class="table-sticky-headers">
<th class="active" data-sort="alphabetic" data-sort-prop="full_name">{{t "Name" }}</th>
<th data-sort="email">{{t "Email" }}</th>
<th class="settings-email-column" data-sort="email">{{t "Email" }}</th>
<th class="user_role" data-sort="role">{{t "Role" }}</th>
<th data-sort="bot_owner">{{t "Owner" }}</th>
<th data-sort="alphabetic" data-sort-prop="bot_type" class="bot_type">{{t "Bot type" }}</th>

2
web/templates/settings/deactivated_users_admin.hbs
View File

@ -16,7 +16,7 @@
<table class="table table-striped wrapped-table">
<thead class="table-sticky-headers">
<th class="active" data-sort="alphabetic" data-sort-prop="full_name">{{t "Name" }}</th>
<th {{#if allow_sorting_deactivated_users_list_by_email}}data-sort="email"{{/if}}>{{t "Email" }}</th>
<th class="settings-email-column" {{#if allow_sorting_deactivated_users_list_by_email}}data-sort="email"{{/if}}>{{t "Email" }}</th>
<th class="user_role" data-sort="role">{{t "Role" }}</th>
{{#if is_admin}}
<th class="actions">{{t "Actions" }}</th>

2
web/templates/stream_settings/new_stream_user.hbs
View File

@ -3,7 +3,7 @@
{{> ../user_display_only_pill display_value=full_name strikethrough=soft_removed is_active=true}}
</td>
{{#if email}}
<td class="subscriber-email {{#if soft_removed}} strikethrough {{/if}}">{{email}}</td>
<td class="subscriber-email settings-email-column {{#if soft_removed}} strikethrough {{/if}}">{{email}}</td>
{{else}}
<td class="hidden-subscriber-email {{#if soft_removed}} strikethrough {{/if}}">{{t "(hidden)"}}</td>
{{/if}}

2
web/templates/stream_settings/new_stream_users.hbs
View File

@ -16,7 +16,7 @@
<table class="subscriber-list table table-striped">
<thead class="table-sticky-headers">
<th data-sort="alphabetic" data-sort-prop="full_name">{{t "Name" }}</th>
<th data-sort="email">{{t "Email" }}</th>
<th class="settings-email-column" data-sort="email">{{t "Email" }}</th>
<th>{{t "Action" }}</th>
</thead>
<tbody id="create_stream_subscribers" class="subscriber_table" data-empty="{{t 'This channel has no subscribers.' }}" data-search-results-empty="{{t 'No channel subscribers match your current filter.'}}"></tbody>

2
web/templates/stream_settings/stream_member_list_entry.hbs
View File

@ -3,7 +3,7 @@
{{> ../user_display_only_pill display_value=name is_active=true}}
</td>
{{#if email}}
<td class="subscriber-email">{{email}}</td>
<td class="subscriber-email settings-email-column">{{email}}</td>
{{else}}
<td class="hidden-subscriber-email">{{t "(hidden)"}}</td>
{{/if}}

2
web/templates/stream_settings/stream_members.hbs
View File

@ -22,7 +22,7 @@
<table id="stream_members_list" class="subscriber-list table table-striped">
<thead class="table-sticky-headers">
<th data-sort="alphabetic" data-sort-prop="full_name">{{t "Name" }}</th>
<th data-sort="email">{{t "Email" }}</th>
<th class="settings-email-column" data-sort="email">{{t "Email" }}</th>
{{#if can_remove_subscribers}}
<th>{{t "Actions" }}</th>
{{/if}}

2
web/templates/user_group_settings/new_user_group_users.hbs
View File

@ -17,7 +17,7 @@
<table class="member-list table table-striped">
<thead class="table-sticky-headers">
<th data-sort="alphabetic" data-sort-prop="full_name">{{t "Name" }}</th>
<th data-sort="email">{{t "Email" }}</th>
<th class="settings-email-column" data-sort="email">{{t "Email" }}</th>
<th>{{t "Action" }}</th>
</thead>
<tbody id="create_user_group_members" class="member_table" data-empty="{{t 'This group has no members.' }}" data-search-results-empty="{{t 'No group members match your current filter.'}}"></tbody>

2
web/templates/user_group_settings/user_group_members.hbs
View File

@ -21,7 +21,7 @@
<table class="member-list table table-striped">
<thead class="table-sticky-headers">
<th data-sort="alphabetic" data-sort-prop="full_name">{{t "Name" }}</th>
<th data-sort="email">{{t "Email" }}</th>
<th class="settings-email-column" data-sort="email">{{t "Email" }}</th>
<th class="user-remove-actions" {{#unless can_edit}}style="display:none"{{/unless}}>{{t "Actions" }}</th>
</thead>
<tbody class="member_table" data-empty="{{t 'This group has no members.' }}" data-search-results-empty="{{t 'No group members match your current filter.'}}"></tbody>