From f9ba4da012f9595cd07470b1a249908cdc3f4b1f Mon Sep 17 00:00:00 2001
From: vighneshbhat9945 <vighneshbhat625@gmail.com>
Date: Mon, 5 Feb 2024 18:51:49 +0530
Subject: [PATCH] stream-settings: Show indicator on notification settings.

In the Personal settings stream management panel,
when notification settings are changed, Saving/Saved
indicator are shown on personal settings heading instead
of notification settings heading.

Fix this issue by showing indicator on
notification settings heading.

Fixes: zulip#28728.
---
 dump.rdb                                         | Bin 0 -> 283 bytes
 web/src/stream_edit.js                           |   4 ++--
 .../stream_settings/stream_settings.hbs          |  15 +++++++++------
 3 files changed, 11 insertions(+), 8 deletions(-)
 create mode 100644 dump.rdb

diff --git a/dump.rdb b/dump.rdb
new file mode 100644
index 0000000000000000000000000000000000000000..9cd60ca68133936b7f77a931408803901fcced80
GIT binary patch
literal 283
zcmWG?b@2=~Ffg$E#aWb^l3A=<mRiJSre~mMX!eT>B9fF@QhdPS7i)4!W^U@CM-L99
z{^BStPEFCxP0c;DVk;-ZFP_BwG~I%t)WqDRoYVsh{}_HVG5ry=%CGEYWMJUYElMm&
z&B@HoEU^j#vV1_S)RfTT)FLZGL#xDs%=o0rc%XqrR#nBRC5P3FSd17L7-SWg#h4fv
z1P#p%%ngk#jVvtn3=AyH42^|_9&iXT8vch{z(>3VIhn;JjB;{7<GFws=r~N{|NlR)
L!h7wqtw=opAPii|

literal 0
HcmV?d00001

diff --git a/web/src/stream_edit.js b/web/src/stream_edit.js
index 23c9751848..f7c1e44248 100644
--- a/web/src/stream_edit.js
+++ b/web/src/stream_edit.js
@@ -304,13 +304,13 @@ function stream_notification_reset(e) {
 
     stream_settings_api.bulk_set_stream_property(
         data,
-        $(`#stream_change_property_status${CSS.escape(sub.stream_id)}`),
+        $(e.target).closest(".subsection-parent").find(".alert-notification"),
     );
 }
 
 function stream_setting_changed(e) {
     const sub = get_sub_for_target(e.target);
-    const $status_element = $(`#stream_change_property_status${CSS.escape(sub.stream_id)}`);
+    const $status_element = $(e.target).closest(".subsection-parent").find(".alert-notification");
     const setting = e.target.name;
     if (!sub) {
         blueslip.error("undefined sub in stream_setting_changed()");
diff --git a/web/templates/stream_settings/stream_settings.hbs b/web/templates/stream_settings/stream_settings.hbs
index 2825dd56c5..4da74cddb9 100644
--- a/web/templates/stream_settings/stream_settings.hbs
+++ b/web/templates/stream_settings/stream_settings.hbs
@@ -95,11 +95,11 @@
         </div>
 
         <div id="personal-stream-settings" class="stream_section" data-stream-section="personal">
-            <div class="subsection-header">
-                <h3 class="stream_setting_subsection_title inline-block">{{t "Personal settings" }}</h3>
-                <div id="stream_change_property_status{{sub.stream_id}}" class="stream_change_property_status alert-notification"></div>
-            </div>
             <div class="subsection-parent">
+                <div class="subsection-header">
+                    <h3 class="stream_setting_subsection_title inline-block">{{t "Personal settings" }}</h3>
+                    <div class="stream_change_property_status alert-notification"></div>
+                </div>
                 {{#each other_settings}}
                     <div class="input-group">
                         {{> stream_settings_checkbox
@@ -120,9 +120,12 @@
                     </span>
                 </div>
             </div>
-            <h4 class="stream_setting_subsection_title">{{t "Notification settings" }}</h4>
-            <p>{{t "In muted streams, stream notification settings apply only to unmuted topics." }}</p>
             <div class="subsection-parent">
+                <div class="subsection-header">
+                    <h4 class="stream_setting_subsection_title">{{t "Notification settings" }}</h4>
+                    <div class="stream_change_property_status alert-notification"></div>
+                    <p>{{t "In muted streams, stream notification settings apply only to unmuted topics." }}</p>
+                </div>
                 <div class="input-group">
                     <button class="button small rounded reset-stream-notifications-button" type="button">{{t "Reset to default notifications" }}</button>
                 </div>