Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

presence: Remove paranoid handling of falsy timestamps. 

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2023-12-21 17:23:31 -08:00 committed by Tim Abbott
parent a36ef0b593
commit f88e3b9735
2 changed files with 17 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/presence.ts
View File

@ -219,8 +219,8 @@ export function set_info(
const raw: RawPresence = {
server_timestamp,
active_timestamp: info.active_timestamp || undefined,
idle_timestamp: info.idle_timestamp || undefined,
active_timestamp: info.active_timestamp,
idle_timestamp: info.idle_timestamp,
};
raw_info.set(user_id, raw);

40
web/tests/presence.test.js
View File

@ -206,46 +206,36 @@ test("set_presence_info", () => {
assert.equal(presence.get_status(jane.user_id), "idle");
});
test("falsy values", () => {
test("missing values", () => {
/*
When a user does not have a relevant active timestamp,
the server just leaves off the `active_timestamp` field
to save bandwidth, which looks like `undefined` to us
if we try to dereference it.
Our code should just treat all falsy values the same way,
though, to defend against bugs where we say the person
was last online in 1970 or silly things like that.
*/
const now = 2000000;
const a_bit_ago = now - 5;
const presences = {};
for (const falsy_value of [undefined, 0, null]) {
presences[zoe.user_id.toString()] = {
active_timestamp: falsy_value,
idle_timestamp: a_bit_ago,
};
presences[zoe.user_id.toString()] = {
idle_timestamp: a_bit_ago,
};
presence.set_info(presences, now);
presence.set_info(presences, now);
assert.deepEqual(presence.presence_info.get(zoe.user_id), {
status: "idle",
last_active: a_bit_ago,
});
assert.deepEqual(presence.presence_info.get(zoe.user_id), {
status: "idle",
last_active: a_bit_ago,
});
presences[zoe.user_id.toString()] = {
active_timestamp: falsy_value,
idle_timestamp: falsy_value,
};
presences[zoe.user_id.toString()] = {};
presence.set_info(presences, now);
presence.set_info(presences, now);
assert.deepEqual(presence.presence_info.get(zoe.user_id), {
status: "offline",
last_active: undefined,
});
}
assert.deepEqual(presence.presence_info.get(zoe.user_id), {
status: "offline",
last_active: undefined,
});
});
test("big realms", ({override_rewire}) => {