Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

user_profile: Remove redundant call to popovers.hide_all. 

`show_user_profile` is only triggered by clicks. Even `enter`
keypress is triggers a click via
`popover_items_handle_keyboard_with_overrides`.
This commit is contained in:
Aman Agrawal 2023-10-03 13:51:42 +00:00 committed by Tim Abbott
parent 6cfb7239c8
commit f85f904fc1
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
web/src/user_profile.js
View File

@ -27,7 +27,6 @@ import * as loading from "./loading";
import * as overlays from "./overlays"; import * as overlays from "./overlays";
import {page_params} from "./page_params"; import {page_params} from "./page_params";
import * as people from "./people"; import * as people from "./people";
import * as popovers from "./popovers";
import * as settings_config from "./settings_config"; import * as settings_config from "./settings_config";
import * as settings_data from "./settings_data"; import * as settings_data from "./settings_data";
import * as settings_profile_fields from "./settings_profile_fields"; import * as settings_profile_fields from "./settings_profile_fields";
@ -317,8 +316,6 @@ function initialize_user_type_fields(user) {
} }
export function show_user_profile(user, default_tab_key = "profile-tab") { export function show_user_profile(user, default_tab_key = "profile-tab") {
popovers.hide_all();
const field_types = page_params.custom_profile_field_types; const field_types = page_params.custom_profile_field_types;
const profile_data = page_params.custom_profile_fields const profile_data = page_params.custom_profile_fields
.map((f) => get_custom_profile_field_data(user, f, field_types)) .map((f) => get_custom_profile_field_data(user, f, field_types))