Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

notifications: Fix blank notification sent when no text specified. 

When we send a message (for which notifications are enabled)
in format `[](file_url)`. A blank notification is sent.

Fixing this by checking if there is no text and adding
message  in that case.

Inspired from: #8796.
Fixes: #8087.
This commit is contained in:
Lakshay Mittal 2023-04-01 00:47:46 +05:30 committed by Tim Abbott
parent a90fa79bfc
commit f84de2212e
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
web/src/notifications.js
View File

@ -10,6 +10,7 @@ import * as favicon from "./favicon";
import * as hash_util from "./hash_util";
import {$t} from "./i18n";
import * as message_lists from "./message_lists";
import * as message_parser from "./message_parser";
import * as message_store from "./message_store";
import * as narrow from "./narrow";
import * as narrow_state from "./narrow_state";
@ -241,7 +242,16 @@ export function process_notification(notification) {
const $content = $("<div>").html(message.content);
ui.replace_emoji_with_text($content);
spoilers.hide_spoilers_in_notification($content);
content = $content.text();
if (
$content.text().trim() === "" &&
(message_parser.message_has_image(message) ||
message_parser.message_has_attachment(message))
) {
content = $t({defaultMessage: "(attached file)"});
} else {
content = $content.text();
}
const topic = message.topic;