From f82c5e9626fb40447ffeca0b09e4464ec1021f1f Mon Sep 17 00:00:00 2001
From: Anupam-dagar <dagaranupam@gmail.com>
Date: Sat, 9 Sep 2017 20:38:13 +0000
Subject: [PATCH] settings: Remove save changes button from "UI settings"
 section.

Fixes: #6330.
---
 static/js/settings_lab.js                     | 45 +++++++++----------
 .../templates/settings/ui-settings.handlebars | 10 +----
 2 files changed, 24 insertions(+), 31 deletions(-)

diff --git a/static/js/settings_lab.js b/static/js/settings_lab.js
index 1b7e784923..4a097d7451 100644
--- a/static/js/settings_lab.js
+++ b/static/js/settings_lab.js
@@ -5,35 +5,34 @@ var exports = {};
 exports.set_up = function () {
     $("#ui-settings-status").hide();
 
-    $("#ui-settings").on("click", "input[name='change_settings']", function (e) {
+    $("#ui-settings .change-setting").change(function (e) {
         e.preventDefault();
         var labs_updates = {};
         _.each(["autoscroll_forever", "default_desktop_notifications"],
             function (setting) {
                 labs_updates[setting] = $("#" + setting).is(":checked");
+            });
+
+            channel.patch({
+                url: '/json/settings/ui',
+                data: labs_updates,
+                success: function (resp, statusText, xhr) {
+                    var message = i18n.t("Updated settings!  You will need to reload for these changes to take effect.", page_params);
+                    var result = JSON.parse(xhr.responseText);
+                    var ui_settings_status = $('#ui-settings-status').expectOne();
+
+                    if (result.autoscroll_forever !== undefined) {
+                        page_params.autoscroll_forever = result.autoscroll_forever;
+                        resize.resize_page_components();
+                    }
+
+                    ui_report.success(message, ui_settings_status);
+                },
+                error: function (xhr) {
+                    ui_report.error(i18n.t("Error changing settings"), xhr, $('#ui-settings-status').expectOne());
+                },
+            });
         });
-
-        channel.patch({
-            url: '/json/settings/ui',
-            data: labs_updates,
-            success: function (resp, statusText, xhr) {
-                var message = i18n.t("Updated settings!  You will need to reload for these changes to take effect.", page_params);
-                var result = JSON.parse(xhr.responseText);
-                var ui_settings_status = $('#ui-settings-status').expectOne();
-
-                if (result.autoscroll_forever !== undefined) {
-                    page_params.autoscroll_forever = result.autoscroll_forever;
-                    resize.resize_page_components();
-                }
-
-                ui_report.success(message, ui_settings_status);
-            },
-            error: function (xhr) {
-                ui_report.error(i18n.t("Error changing settings"), xhr, $('#ui-settings-status').expectOne());
-            },
-        });
-    });
-
 };
 
 return exports;
diff --git a/static/templates/settings/ui-settings.handlebars b/static/templates/settings/ui-settings.handlebars
index ba44c2c14d..17ab00d8b4 100644
--- a/static/templates/settings/ui-settings.handlebars
+++ b/static/templates/settings/ui-settings.handlebars
@@ -8,7 +8,7 @@
         <div class="side-padded-container">
             <div class="input-group">
                 <label class="checkbox">
-                    <input type="checkbox" class="inline-block" name="autoscroll_forever" id="autoscroll_forever"
+                    <input type="checkbox" class="inline-block change-setting" name="autoscroll_forever" id="autoscroll_forever"
                            {{#if page_params.autoscroll_forever}}
                            checked="checked"
                          {{/if}} />
@@ -20,7 +20,7 @@
             </div>
             <div class="input-group">
                 <label class="checkbox">
-                    <input type="checkbox" class="inline-block" name="default_desktop_notifications" id="default_desktop_notifications"
+                    <input type="checkbox" class="inline-block change-setting" name="default_desktop_notifications" id="default_desktop_notifications"
                            {{#if page_params.default_desktop_notifications}}
                            checked="checked"
                         {{/if}} />
@@ -31,11 +31,5 @@
                 </label>
             </div>
         </div>
-
-        <div class="input-group no-border">
-            <div class="ui-submission">
-                <input type="submit" name="change_settings" value="{{t 'Save changes' }}" class="button rounded sea-green" />
-            </div>
-        </div>
     </form>
 </div>