From f7fe96f814a313d9342cebc3c5b394e14345d4de Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Fri, 15 Nov 2024 16:30:05 -0800 Subject: [PATCH] blueslip: Include message for abnormal traces. `ResizeObserver loop completed with undelivered notifications` errors have originalEvent.error=null; in that case, it's worth including the `message` in what we display. I think we probably want `message` in every case where this code path is relevant, so I just append it unconditionally. --- web/src/blueslip_stacktrace.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/src/blueslip_stacktrace.ts b/web/src/blueslip_stacktrace.ts index 48bd726ac0..40a129b6eb 100644 --- a/web/src/blueslip_stacktrace.ts +++ b/web/src/blueslip_stacktrace.ts @@ -123,7 +123,7 @@ export async function display_stacktrace(ex: unknown, message?: string): Promise "constructor" in prototype ? `thrown ${prototype.constructor.name}` : "thrown", - message: ex === undefined ? message : String(ex), + message: ex === undefined ? message : `${String(ex)}: ${message}`, stackframes: [], }); break;