Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

popovers: Fix 'u' keyboard shortcut on messages without avatars. 

In ab0c5f3092, it was missed that this
code depended on the sender_info_hover CSS class, which is no longer
an empty element on messages without a message sender avatar/name
element.

The logic is still hacky, as it relies on the position of an invisible
element, but we're rewriting the positioning logic using Tippy anyway,
so it's not worth doing much to make it nicer.

Fixes #25496.
This commit is contained in:
Tim Abbott 2023-05-10 16:58:14 -07:00
parent 3cc3fbc0c3
commit f6dde97ec9
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web/src/popovers.js
View File

@ -670,7 +670,12 @@ export function user_info_popover_manage_menu_handle_keyboard(key) {
export function show_sender_info() {
const $message = $(".selected_message");
const $sender = $message.find(".sender_info_hover");
let $sender = $message.find(".inline_profile_picture");
if ($sender.length === 0) {
// Messages without an avatar have an invisible message_sender
// element that's roughly in the right place.
$sender = $message.find(".message_sender");
}
const message = message_lists.current.get(rows.id($message));
const user = people.get_by_user_id(message.sender_id);