puppeteer_tests: Remove sequential numbers from test files.

The only downside of this is that it makes it harder to control the
order of these tests; which isn't that important.  And the structure
of naming each with its test order fundamentally requires renaming
files when adding/deleting tests, so if we want to control the default
test order, we'd be better off doing that by just hardcoding a list in
the test runner code.
This commit is contained in:
Riken Shah 2021-04-01 18:07:19 +05:30 committed by Tim Abbott
parent e05935a292
commit f6998d6fee
21 changed files with 8 additions and 8 deletions

View File

@ -73,7 +73,7 @@ integration](../testing/continuous-integration.md):
affects any of the selectors used in the tests? If so, the test may affects any of the selectors used in the tests? If so, the test may
just need to be updated for your changes. just need to be updated for your changes.
* Does the test fail deterministically when you run it locally using * Does the test fail deterministically when you run it locally using
E.g. `./tools/test-js-with-puppeteer 03`? If so, you can E.g. `./tools/test-js-with-puppeteer compose.ts`? If so, you can
iteratively debug to see the failure. iteratively debug to see the failure.
* Does the test fail nondeterministically? If so, the problem is * Does the test fail nondeterministically? If so, the problem is
likely that a `waitForSelector` statement is either missing or not likely that a `waitForSelector` statement is either missing or not

View File

@ -35,7 +35,7 @@ typically involve running subsets of the tests with commands like these:
./tools/lint zerver/lib/actions.py # Lint the file you just changed ./tools/lint zerver/lib/actions.py # Lint the file you just changed
./tools/test-backend zerver.tests.test_markdown.MarkdownTest.test_inline_youtube ./tools/test-backend zerver.tests.test_markdown.MarkdownTest.test_inline_youtube
./tools/test-backend MarkdownTest # Run `test-backend --help` for more options ./tools/test-backend MarkdownTest # Run `test-backend --help` for more options
./tools/test-js-with-puppeteer 07-navigation.js ./tools/test-js-with-puppeteer navigation.ts
./tools/test-js-with-node utils.js ./tools/test-js-with-node utils.js
``` ```

View File

@ -56,7 +56,7 @@ organization in Zulip). The following files are involved in the process:
zerver/lib/events.py implementation. zerver/lib/events.py implementation.
**Frontend testing** **Frontend testing**
- `frontend_tests/puppeteer_tests/08-admin.js`: end-to-end tests for the organization - `frontend_tests/puppeteer_tests/admin.ts`: end-to-end tests for the organization
admin settings pages. admin settings pages.
- `frontend_tests/node_tests/dispatch.js` - `frontend_tests/node_tests/dispatch.js`

View File

@ -26,7 +26,7 @@ if (options.messageId === undefined) {
process.exit(1); process.exit(1);
} }
// TODO: Refactor to share code with frontend_tests/puppeteer_tests/01-realm-creation.js // TODO: Refactor to share code with frontend_tests/puppeteer_tests/realm-creation.ts
async function run() { async function run() {
const browser = await puppeteer.launch({ const browser = await puppeteer.launch({
args: [ args: [

View File

@ -28,10 +28,10 @@ os.environ.pop("https_proxy", "")
usage = """test-js-with-puppeteer [options] usage = """test-js-with-puppeteer [options]
test-js-with-puppeteer # Run all test files test-js-with-puppeteer # Run all test files
test-js-with-puppeteer 09-navigation.js # Run a single test file test-js-with-puppeteer navigation.ts # Run a single test file
test-js-with-puppeteer 09 # Run a single test file 09-navigation.js test-js-with-puppeteer navi # Run a single test file navigation.ts
test-js-with-puppeteer 01-login.js 03-narrow.js # Run a few test files test-js-with-puppeteer login.ts compose.ts # Run a few test files
test-js-with-puppeteer 01 03 # Run a few test files, 01-login.js and 03-narrow.js here""" test-js-with-puppeteer login compose # Run a few test files, login.ts and compose.ts here"""
sys.path.insert(0, ZULIP_PATH) sys.path.insert(0, ZULIP_PATH)