mirror of https://github.com/zulip/zulip.git
user groups: Miscellaneous fixes to new user groups settings overlay.
We address few of the minor required change mentioned in https://github.com/zulip/zulip/issues/24443. * Sort user group list alphabetically by name on left panel. * Fix actions column items on member list on right panel. * Add tooltip to trash icon on right panel.
This commit is contained in:
parent
40a8ca2ced
commit
f494daba95
|
@ -51,7 +51,7 @@ function format_member_list_elem(person) {
|
||||||
user_id: person.user_id,
|
user_id: person.user_id,
|
||||||
is_current_user: person.user_id === page_params.user_id,
|
is_current_user: person.user_id === page_params.user_id,
|
||||||
email: person.delivery_email,
|
email: person.delivery_email,
|
||||||
can_edit_subscribers: user_group_edit.can_edit(current_group_id),
|
can_remove_subscribers: user_group_edit.can_edit(current_group_id),
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -217,6 +217,7 @@ export function setup_page(callback) {
|
||||||
);
|
);
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
|
init_sort: ["alphabetic", "name"],
|
||||||
$simplebar_container: $container,
|
$simplebar_container: $container,
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|
|
@ -2,7 +2,7 @@
|
||||||
<div class="tab-container"></div>
|
<div class="tab-container"></div>
|
||||||
<div class="button-group">
|
<div class="button-group">
|
||||||
{{#if can_edit}}
|
{{#if can_edit}}
|
||||||
<button class="button small rounded btn-danger deactivate" type="button" name="delete_button"> <i class="fa fa-trash-o" aria-hidden="true"></i></button>
|
<button class="button small rounded btn-danger deactivate tippy-zulip-tooltip" data-tippy-content="{{t 'Delete group'}}" type="button" name="delete_button"> <i class="fa fa-trash-o" aria-hidden="true"></i></button>
|
||||||
{{/if}}
|
{{/if}}
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
Loading…
Reference in New Issue